Re: [DISCUSS] Add unified newTableView method in PulsarClient

2023-01-19 Thread Haiting Jiang
+1 Haiting On Mon, Jan 16, 2023 at 3:14 PM Enrico Olivelli wrote: > > +1 > > Enrico > > Il Lun 16 Gen 2023, 03:11 PengHui Li ha scritto: > > > +1 > > > > And It might be a typo when adding the table view APIs > > From the example: > > > > > > https://github.com/apache/pulsar/blob/246c2701e5c43e

Re: [DISCUSS] Add unified newTableView method in PulsarClient

2023-01-15 Thread Enrico Olivelli
+1 Enrico Il Lun 16 Gen 2023, 03:11 PengHui Li ha scritto: > +1 > > And It might be a typo when adding the table view APIs > From the example: > > > https://github.com/apache/pulsar/blob/246c2701e5c43e02e9783c82d4d107d06b019951/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Pulsar

Re: Re: [DISCUSS] Add unified newTableView method in PulsarClient

2023-01-15 Thread Enrico Olivelli
+1 Enrico Il Lun 16 Gen 2023, 03:38 Ruguo Yu ha scritto: > Sorry,I forgot to paste the corresponding PR: > https://github.com/apache/pulsar/pull/19048 > > I have fixed the typo in above PR. > > > > On 2023/01/16 02:10:07 PengHui Li wrote: > > > +1 > > > > > > And It might be a typo when addin

RE: Re: [DISCUSS] Add unified newTableView method in PulsarClient

2023-01-15 Thread Ruguo Yu
Sorry,I forgot to paste the corresponding PR: https://github.com/apache/pulsar/pull/19048 I have fixed the typo in above PR. On 2023/01/16 02:10:07 PengHui Li wrote: > +1 > > And It might be a typo when adding the table view APIs > From the example: > > https://github.com/apache/pulsa

Re: [DISCUSS] Add unified newTableView method in PulsarClient

2023-01-15 Thread PengHui Li
+1 And It might be a typo when adding the table view APIs >From the example: https://github.com/apache/pulsar/blob/246c2701e5c43e02e9783c82d4d107d06b019951/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/PulsarClient.java#L232-L238 And from the proposal, the method name is newTableV