RE: [VOTE] Pulsar Node.js Client Release 1.1.0 Candidate 1

2020-02-17 Thread Masahiro Sakamoto
Subject: Re: [VOTE] Pulsar Node.js Client Release 1.1.0 Candidate 1 +1 non-binding install package build produce/consume Thanks, Guangning Nozomi Kurihara 于2020年2月14日周五 下午4:24写道: > +1 (binding) > > Checked: > > * build success > * lisence > * install an

Re: [VOTE] Pulsar Node.js Client Release 1.1.0 Candidate 1

2020-02-16 Thread Guangning E
+1 non-binding install package build produce/consume Thanks, Guangning Nozomi Kurihara 于2020年2月14日周五 下午4:24写道: > +1 (binding) > > Checked: > > * build success > * lisence > * install and run the npm package > * produce/consume > > Thanks, > Nozomi > > > Noz

Re: [VOTE] Pulsar Node.js Client Release 1.1.0 Candidate 1

2020-02-14 Thread Nozomi Kurihara
+1 (binding) Checked: * build success * lisence * install and run the npm package * produce/consume Thanks, Nozomi Nozomi Kurihara Cloud Platform Development Division System Management Group Yahoo Japan Corporation Kioi Tower, Tokyo Garden Terrace Kioicho,

Re: [VOTE] Pulsar Node.js Client Release 1.1.0 Candidate 1

2020-02-13 Thread Yuri Mizushima
+1 non binding I checked: * unit test, end-to-end test * package build * produce/consume - by package index.js - by downloaded client via npm and found no problem. nits * whether check test code format Currently, lint npm script checks production code and test code, and throws some warning a