+1 non binding
I checked:
* unit test, end-to-end test
* package build
* produce/consume
- by package index.js
- by downloaded client via npm
and found no problem.
nits
* whether check test code format
Currently, lint npm script checks production code and test code,
and throws some warning about test code is not formatted.
I seem we will expect that lint returns success when release commit is created.
Regards,
Yuri
--
Yuri Mizushima
yumiz...@yahoo-corp.jp
"Hiroyuki Sakai" <hsa...@yahoo-corp.jp> wrote:
This is the first release candidate for Apache Pulsar Node.js client,
version 1.1.0.
It fixes the following issues:
https://github.com/apache/pulsar-client-node/milestone/3?closed=1
*** Please download, test and vote on this release. This vote will stay open
for at least 72 hours ***
Note that we are voting upon the source (tag), the npm package is provided
for convenience.
The tag to be voted upon:
v1.1.0-rc.1
https://github.com/apache/pulsar-client-node/releases/tag/v1.1.0-rc.1
The npm package:
https://www.npmjs.com/package/pulsar-client/v/1.1.0-rc.1
Please download the source files, and follow the README to build
and run the Pulsar Node.js client.
--
Hiroyuki Sakai
Yahoo Japan Corp.
E-mail: hsa...@yahoo-corp.jp
