Hi Zixuan and Tison,
Thanks for your comments!
We're considering your suggestion and will turn the proposal into a PIP and
call a vote.
Yu, Max, mangoGoForward
On Mon, Aug 1, 2022 at 4:29 PM Zixuan Liu wrote:
> Hi Yu,
>
> This is a good idea, I noticed this thread for a long time.
>
> This PR
Hi Yu,
This is a good idea, I noticed this thread for a long time.
This PR title looks like convention message[1], it should be variant. If we use
the convention message, we can focus on other things, and reduce time on these
tools, but the developer gets used to the current standard. If we don
Hi Dave,
Thanks for your suggestions!
> Our guidelines should make it super easy to make contributions.
This guideline is quite easy to use/understand/find because:
1) If you review PRs recently, you'll find that many contributors start
following this guideline. This is the most positive feedba
Hi Lari,
Thanks for your suggestions!
> In Git, the convention is to have a subject line (title) with no more
than 50 characters. When you start adding all kinds of tags in brackets in
the title, there won't be much left for the actual content.
I think the guideline does not conflict with Git me
Hi -
I think that these guidelines are making it hard for new contributors. Our
guidelines should make it super easy to make contributions. The guidelines are
for contributions. Contributors are the community. Committers will review
contributors PRs and can gently fix mistakes for them to show
The problem with the "Pulsar PR Naming Convention" is that it can conflict with
general Git message conventions.
The PR title automatically becomes the Git commit's subject line. That's how
the PR title related to the Git commit's subject line (title).
In Git, the convention is to have a subje
#1
Thanks, Penghui, I'll add this guideline link in the contribution guide
after we make a consensus.
#2
Based on the suggestions from the community, I've made the following tweaks
to make info more clear:
- Change "type/enhancement" to "type/improvement"
- Change type abbreviation "enh" to "impro
It's better to update the contributing guideline,
so that all the new contributors can follow the guidelines
For the committers, we'd better try to update the PR
title as the guideline before merging it.
It's not easy to reach a consensus very fast,
but we can finally reach it :)
Thanks,
Penghui
Thanks for your suggestions, Penghui, Enrico, and Nicoló Boschi.
Yes, it might be hard to enforce but this is a good start.
Nothing can be accomplished without standards. It is recommended to follow
the rules defined in this guide after the community reaches a consensus.
On Thu, Mar 17, 2022 at
Thank you Yu,
I left some feedback on the gdoc
Overall it is a great proposal.
It will probably be hard to enforce, we will have to spend time and
fix the title when we see the wrong title.
but I totally agree with you, this effort will help the community in
understand better what we are doing (d
Hi Yu,
Thanks for the great guidance.
Overall looks good to me, just left a few minor comments.
Penghui
On Thu, Mar 17, 2022 at 10:12 AM Yu wrote:
> Hi Pulsarers,
>
> We submit or review PRs almost every day, we might see many vague and
> unclear PR titles that decrease team efficiency and pro
11 matches
Mail list logo
