Hi Zixuan and Tison,

Thanks for your comments!
We're considering your suggestion and will turn the proposal into a PIP and
call a vote.

Yu, Max, mangoGoForward

On Mon, Aug 1, 2022 at 4:29 PM Zixuan Liu <node...@gmail.com> wrote:

> Hi Yu,
>
> This is a good idea, I noticed this thread for a long time.
>
> This PR title looks like convention message[1], it should be variant. If
> we use the convention message, we can focus on other things, and reduce
> time on these tools, but the developer gets used to the current standard.
> If we don't consider these, I suggest using the convention message.
>
> Currently we have a draft PR[2] to check the PR title, I think we should
> make a dev guide to explain this format on Pulsar repository, then continue
> to start this PR.
>
>
> [1] https://www.conventionalcommits.org/en/v1.0.0/#summary
> [2] https://github.com/apache/pulsar/pull/16836
>
> Thanks,
> Zixuan
>
>
> On 2022/03/17 02:11:54 Yu wrote:
> > Hi Pulsarers,
> >
> > We submit or review PRs almost every day, we might see many vague and
> > unclear PR titles that decrease team efficiency and productivity.
> >
> > Good PR titles offer bring many benefits, such as speeding up the review
> > process and improving search efficiency.
> >
> > To solve the vague PR title issue and move *PIP 112: Generate Release
> Notes
> > Automatically* [1] forward, I've created *Guideline: Pulsar PR Naming
> > Convention* [2], which explains why you need good PR titles and how you
> do
> > that with various self-explanatory examples. Also, Pulsar and client
> > release notes will be generated automatically based on the rules defined
> in
> > this guide.
> >
> > Do not hesitate to comment if you have any questions or concerns.
> Feedback
> > before EOD 3/21 CST is highly appreciated, thanks!
> >
> > [1]
> >
> https://docs.google.com/document/d/1Ul2qIChDe8QDlDwJBICq1VviYZhdk1djKJJC5wXAGsI/edit#
> >
> > [2]
> >
> https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#
> >
> > Regards,
> > Anonymitaet
> >

Reply via email to