[RESULT][VOTE] PIP 198: Standardize PR Naming Convention using GitHub Actions

Hi team, Thanks for all your suggestions! I'll move PIP 198 forward since we get 3 binding votes (Penghui, Lari, Michael) [1]. [1] https://lists.apache.org/thread/m7hfgpdjthrk8ogz3mnkprs018tkkc0m Yu

Re: [Vote] PIP 198: Standardize PR Naming Convention using GitHub Actions

Hi team, This is a continued thread from the last one. Feel free to vote and comment on this issue, thank you! Vote: For PR titles, which convention should we follow? - Angular convention [1] - Our customized convention (it's customized based on Angular) [2]

Re: [Vote] PIP 198: Standardize PR Naming Convention using GitHub Actions

Hi team, Thanks for all your suggestions! I'll move PIP 198 forward since we get 3 binding votes (Penghui, Lari, Michael). For the implementation details, I've got many different suggestions, which can be summarized into 2 major issues: - Issue 1: which convention should we follow? Angular [1]

Re: [Vote] PIP 198: Standardize PR Naming Convention using GitHub Actions

Hi Lari, Thanks for your suggestions! Please see my replies inline. > Would it be possible to improve the proposal in a way that the valid prefixes for type and component are in a file in the repository and the possible checker would use this file as the source of truth? Yes, it's the same as we

Re: [Vote] PIP 198: Standardize PR Naming Convention using GitHub Actions

Hi tison, Thanks for your suggestions! > Currently, I'd suggest: feature -> feat workflow -> ci improve/cleanup -> > chore... I agree on some and will send votes step by step to let the community decide. On 2022/08/09 09:21:54 tison wrote: > Hi Yu, > > To be clear, the candidates of types an

Re: [Vote] PIP 198: Standardize PR Naming Convention using GitHub Actions

Hi tison, Thanks for your suggestions! > Although, we should later move the standard to our website where the whole > project can easily contribute to ... Sure. I'll move the [Guide] Pulsar Pull Request Naming Convention [1] to a public place where everyone can contribute after we finalize th

Re: [Vote] PIP 198: Standardize PR Naming Convention using GitHub Actions

+1 (binding) to the overall proposal. I also agree with the clarifications/requests raised by Tison and Lari. I prefer the abbreviated prefixes, and I think using a GitHub Action to enforce the formatting would guarantee that the formatting is correct. For example, when I review PRs and merge them,

Re: [Vote] PIP 198: Standardize PR Naming Convention using GitHub Actions

+1 (non-binding) Thanks, Xiaoyu Hou Yu 于2022年8月4日周四 16:13写道： > Hi team, > > It has been 4 months since we discussed the [Guideline] Pulsar PR Naming > Convention [1]. > > Nowadays, when reading the PR list [2], you’ll find more and more people > follow and get used to this rule. > > It improves

Re: [Vote] PIP 198: Standardize PR Naming Convention using GitHub Actions

+1, with some conditions about the details of PIP 198 that are listed below: Would it be possible to improve the proposal in a way that the valid prefixes for type and component are in a file in the repository and the possible checker would use this file as the source of truth? Tison already poi

Re: [Vote] PIP 198: Standardize PR Naming Convention using GitHub Actions

Hi Yu, To be clear, the candidates of types and components are a bit long which may waste space for meaningful information. For example, Angular names feature as feat to save letters. GitHub only shows the first 50 characters for PR title. I'd like to confirm that the name of types and component

Re: [Vote] PIP 198: Standardize PR Naming Convention using GitHub Actions

+1 (non-binding) I like the idea of check PR title as a job. Good job, Yu. tison 于2022年8月8日周一 22:07写道： > +1 (non-binding) to the proposal itself. > > Although, we should later move the standard to our website where the whole > project can easily contribute to and follow the general contribution

Re: [Vote] PIP 198: Standardize PR Naming Convention using GitHub Actions

+1 (non-binding) to the proposal itself. Although, we should later move the standard to our website where the whole project can easily contribute to and follow the general contribution process - that is, send a pull request, review, and merge. I regard current gdoc content as a temporary container

Re: [Vote] PIP 198: Standardize PR Naming Convention using GitHub Actions

+1 (non-binding) Thanks Zike Yang On Mon, Aug 8, 2022 at 1:06 PM Xiangying Meng wrote: > > +1(non-binding) > > yours sincerely, > xiangying Meng > > On Thu, Aug 4, 2022 at 4:13 PM Yu wrote: > > > Hi team, > > > > It has been 4 months since we discussed the [Guideline] Pulsar PR Naming > > Conve

Re: [Vote] PIP 198: Standardize PR Naming Convention using GitHub Actions

+1(non-binding) yours sincerely, xiangying Meng On Thu, Aug 4, 2022 at 4:13 PM Yu wrote: > Hi team, > > It has been 4 months since we discussed the [Guideline] Pulsar PR Naming > Convention [1]. > > Nowadays, when reading the PR list [2], you’ll find more and more people > follow and get used t

[Vote] PIP 198: Standardize PR Naming Convention using GitHub Actions

Hi team, It has been 4 months since we discussed the [Guideline] Pulsar PR Naming Convention [1]. Nowadays, when reading the PR list [2], you’ll find more and more people follow and get used to this rule. It improves collaboration efficiency, that is great! This makes us think about moving the