+1 (binding) to the overall proposal. I also agree with the
clarifications/requests raised by Tison and Lari. I prefer the
abbreviated prefixes, and I think using a GitHub Action to enforce the
formatting would guarantee that the formatting is correct. For
example, when I review PRs and merge them, I often forget to sanitize
the PR title because I am so focused on the PR's content itself, and
once it's committed, it's in the history forever.

> I hope we could get rid of the brackets too and simply use a similar format 
> as Angular does.

I do like the look of brackets :), but I agree that the current format
is more verbose than necessary, and if we want to target < 50 chars,
every char matters.

Thanks,
Michael

On Tue, Aug 9, 2022 at 7:57 AM Anon Hxy <anonhx...@gmail.com> wrote:
>
> +1 (non-binding)
>
> Thanks,
> Xiaoyu Hou
>
> Yu <li...@apache.org> 于2022年8月4日周四 16:13写道:
>
> > Hi team,
> >
> > It has been 4 months since we discussed the [Guideline] Pulsar PR Naming
> > Convention [1].
> >
> > Nowadays, when reading the PR list [2], you’ll find more and more people
> > follow and get used to this rule.
> >
> > It improves collaboration efficiency, that is great!
> >
> > This makes us think about moving the rule forward, that is, standardizing
> > PR title naming using GitHub Actions, which is a more efficient way.
> >
> > So we'd like to start a vote on PIP 198: Standardize PR Naming Convention
> > using GitHub Actions [3].
> >
> >
> > This proposal contains:
> >
> > - Why do this?
> >
> > - How do this?
> >
> > - Pre-discussions and other thoughts
> >
> > Feel free to comment, thank you!
> >
> > [1] https://lists.apache.org/thread/sk9ops3t94jmzc5tndk08y9khf7pj6so
> >
> > [2] https://github.com/apache/pulsar/pulls
> >
> > [3]
> >
> > https://docs.google.com/document/d/1sJlUNAHnYAbvu9UtEgCrn_oVTnVc1M5nHC19x1bFab4/edit?pli=1#
> >
> >
> > Yu, Max, mangoGoForward
> >

Reply via email to