Re: [VOTE] Pulsar Release 2.8.0 Candidate 2

2021-06-11 Thread Lari Hotari
There's a severe bug in Jetty 9.4.39 version when using TLS connections (bug details: https://github.com/eclipse/jetty.project/issues/6152#issuecomment-817134632 ). This problem shows up sporadically when creating Pulsar Functions where a jar file is uploaded over TLS. Issue reported as https://gi

Re: [VOTE] Pulsar Release 2.8.0 Candidate 2

2021-06-10 Thread Jonathan Ellis
Update: We discussed this on today's contributor call -- consensus was that this patch can go in if it can be rebased and merged before #10878 and RC3 is rolled. On Thu, Jun 10, 2021 at 10:31 AM Jonathan Ellis wrote: > Hi Sijie, > > This patch and the initial review was completed before the free

Re: [VOTE] Pulsar Release 2.8.0 Candidate 2

2021-06-10 Thread Jonathan Ellis
Hi Sijie, This patch and the initial review was completed before the freeze and we have only been waiting for a second review, like you asked. Given this situation, and given the very limited scope of the patch I mentioned, I think it's reasonable to proceed. Stepping outside the procedural deta

Re: [VOTE] Pulsar Release 2.8.0 Candidate 2

2021-06-10 Thread Sijie Guo
Once RC is started, we don't take new features. We only take critical fixes. That was documented as "Code Freeze" in the time-based release plan. I think we should stick to this plan. Otherwise, everyone would try to include features for different requirements. - Sijie On Thu, Jun 10, 2021 at 7:

Re: [VOTE] Pulsar Release 2.8.0 Candidate 2

2021-06-10 Thread Jonathan Ellis
As a heads up for anyone tracking the differences between (what I assume will soon be) RC3 and this RC2, we're planning to also merge https://github.com/apache/pulsar/pull/10410. This completes a feature that was introduced in the 2.8 dev cycle, and the patch is limited to files that were introduc

Re: [VOTE] Pulsar Release 2.8.0 Candidate 2

2021-06-09 Thread Enrico Olivelli
Jerry, Matteo Il giorno gio 10 giu 2021 alle ore 02:52 Matteo Merli ha scritto: > > I agree with Jerry on this one, since it impairs the classpath for > existing functions. I strongly believe that #10878 is to be discussed more, see my comments here https://github.com/apache/pulsar/pull/10878#pu

Re: [VOTE] Pulsar Release 2.8.0 Candidate 2

2021-06-09 Thread Matteo Merli
I agree with Jerry on this one, since it impairs the classpath for existing functions. -- Matteo Merli On Wed, Jun 9, 2021 at 5:40 PM Jerry Peng wrote: > > Hi all, > > I noticed another issue with the current release candidate. The > java-instance.jar that is used as the root classloader for

Re: [VOTE] Pulsar Release 2.8.0 Candidate 2

2021-06-09 Thread Matteo Merli
On Wed, Jun 9, 2021 at 5:39 PM Chris Bartholomew wrote: > > If we are going to let the release go out with a known regression, I think > we need to clearly document it in the release notes so that folks can make a > proper decision about whether or not they want to upgrade to this release. I t

Re: [VOTE] Pulsar Release 2.8.0 Candidate 2

2021-06-09 Thread Jerry Peng
Hi all, I noticed another issue with the current release candidate. The java-instance.jar that is used as the root classloader for Pulsar Functions still contains too many dependencies. It should only contain the following deps: 1. pulsar-io-core 2. pulsar-functions-api 3. pulsar-cli

Re: [VOTE] Pulsar Release 2.8.0 Candidate 2

2021-06-09 Thread Chris Bartholomew
If we are going to let the release go out with a known regression, I think we need to clearly document it in the release notes so that folks can make a proper decision about whether or not they want to upgrade to this release. Chris On Wednesday, June 9, 2021, 05:42:13 PM EDT, Matteo Merli

Re: [VOTE] Pulsar Release 2.8.0 Candidate 2

2021-06-09 Thread Andrey Yegorov
We talked about having pulsar-adapters released at the same time as 2.8 / being a part of the release process. https://github.com/apache/pulsar-adapters I don't see artifacts from the pulsar-adapters among the staged maven artifacts. I.e. pulsar-log4j2-appender is not there. pulsar-adapters were m

Re: [VOTE] Pulsar Release 2.8.0 Candidate 2

2021-06-09 Thread Matteo Merli
Since transactions is a new feature and auto-creation of topics is by default enabled, I'd be more inclined to let the current RC go through. There is an easy workaround for this issue if someone wants to use transactions with no auto topic creation, which is to manually create these topics. We ca

Re: [VOTE] Pulsar Release 2.8.0 Candidate 2

2021-06-09 Thread Michael Marshall
> But I found this problem while trying to upgrade a project that uses > Transactions (Pulsar JMS client), it may be a showstopper for the > adoption of Transactions. > https://github.com/apache/pulsar/issues/10871 I put together a PR that will allow the transaction topic to get created regardless

Re: [VOTE] Pulsar Release 2.8.0 Candidate 2

2021-06-09 Thread Hang Chen
Hi Penghui, I have do the following testing, * build bin package form source code * deploy on our test cluster and run pub-sub with pulsar-perf * deploy KoP on Pulsar cluster and run pub-sub with kafka-perf all works well. However, when i import `pulsar-common` and `pulsar-

Re: [VOTE] Pulsar Release 2.8.0 Candidate 2

2021-06-09 Thread Enrico Olivelli
PengHui, I am testing the release and at the moment everything is good. But I found this problem while trying to upgrade a project that uses Transactions (Pulsar JMS client), it may be a showstopper for the adoption of Transactions. https://github.com/apache/pulsar/issues/10871 The problem is ab

Re: [VOTE] Pulsar Release 2.8.0 Candidate 2

2021-06-09 Thread Guangning E
+1(non-binding) * Build bin package and image * pub/sub * Run as a cluster Thanks, Guangning Yuri Mizushima 于2021年6月9日周三 下午5:09写道: > +1 (non-binding) > > I checked > * shasum and signature > * pub/sub and Java Functions > * connectors > * stateful functions > > Thank you for your work! > > --

Re: [VOTE] Pulsar Release 2.8.0 Candidate 2

2021-06-09 Thread Yuri Mizushima
+1 (non-binding) I checked * shasum and signature * pub/sub and Java Functions * connectors * stateful functions Thank you for your work! -- Yuri Mizushima yumiz...@yahoo-corp.jp "PengHui Li" wrote: Sorry for the typo, ``` 9f7304c3d35db97998a16a46362433c43c61d20eb3d2f51eb431

Re: [VOTE] Pulsar Release 2.8.0 Candidate 2

2021-06-08 Thread Matteo Merli
+1 binding Checked: * Signatures * Bin distribution: - NOTICE, README, LICENSE - Start standalone service and producer/consumer test * Src distribution: - NOTICE, README, LICENSE - Compile and unit tests - Start standalone service * Checked staging maven repository ar

Re: [VOTE] Pulsar Release 2.8.0 Candidate 2

2021-06-08 Thread PengHui Li
Sorry for the typo, ``` 9f7304c3d35db97998a16a46362433c43c61d20eb3d2f51eb43175fa79728925175d4646c2cd72ad39fc614e425814af1b9a8a8635545cea291a28e28d57 apache-pulsar-2.8.0-SNAPSHOT-bin.tar.gz 8fe7e30c3cda0993114996dced0bf49986365a76bcc69b2e68160d6a9e52c9e9a2bc174eba7eb0c7467f6a62e009ee7d8a3457e0

[VOTE] Pulsar Release 2.8.0 Candidate 2

2021-06-08 Thread PengHui Li
This is the second release candidate for Apache Pulsar, version 2.8.0. It fixes the following issues: https://github.com/apache/pulsar/pulls?q=is%3Apr+milestone%3A2.8.0+-label%3Arelease%2F2.7.1+-label%3Arelease%2F2.7.2+is%3Aclosed *** Please download, test and vote on this release. This vote will