Jerry, Matteo Il giorno gio 10 giu 2021 alle ore 02:52 Matteo Merli <matteo.me...@gmail.com> ha scritto: > > I agree with Jerry on this one, since it impairs the classpath for > existing functions.
I strongly believe that #10878 is to be discussed more, see my comments here https://github.com/apache/pulsar/pull/10878#pullrequestreview-680377047 Enrico > > > -- > Matteo Merli > <matteo.me...@gmail.com> > > On Wed, Jun 9, 2021 at 5:40 PM Jerry Peng <jerry.boyang.p...@gmail.com> wrote: > > > > Hi all, > > > > I noticed another issue with the current release candidate. The > > java-instance.jar that is used as the root classloader for Pulsar Functions > > still contains too many dependencies. It should only contain the following > > deps: > > > > 1. pulsar-io-core > > 2. pulsar-functions-api > > 3. pulsar-client-api > > 4. slf4j-api > > 5. log4j-slf4j-impl > > 6. log4j-api > > 7. log4j-core > > > > No additional 3rd party libraries should be included as that could cause > > dependency conflicts with user code. > > > > I have created a PR to fix this issue: > > > > https://github.com/apache/pulsar/pull/10878 > > > > Let's also include this fix in 2.8 > > > > Best, > > > > Jerry > > > > On Wed, Jun 9, 2021 at 4:09 PM Andrey Yegorov <andrey.yego...@datastax.com> > > wrote: > > > > > We talked about having pulsar-adapters released at the same time as 2.8 / > > > being a part of the release process. > > > https://github.com/apache/pulsar-adapters > > > > > > I don't see artifacts from the pulsar-adapters among the staged maven > > > artifacts. > > > I.e. pulsar-log4j2-appender is not there. > > > pulsar-adapters were missed in 2.7.x releases. > > > > > > Have I missed the plan change to release them separately? > > > > > > > > > On Wed, Jun 9, 2021 at 2:42 PM Matteo Merli <mme...@apache.org> wrote: > > > > > > > Since transactions is a new feature and auto-creation of topics is by > > > > default enabled, I'd be more inclined to let the current RC go > > > > through. > > > > > > > > There is an easy workaround for this issue if someone wants to use > > > > transactions with no auto topic creation, which is to manually create > > > > these topics. We can add documentation around this. > > > > > > > > We will surely encounter more of these issues and we'll fix them for > > > > 2.8.1 (which we should do soon enough). > > > > > > > > I would suggest not to stop the release unless we encounter that: > > > > * Some new major feature is broken in ways that renders it useless > > > > * Some existing functionality or behavior is impacted. > > > > > > > > > > > > Matteo > > > > > > > > -- > > > > Matteo Merli > > > > <mme...@apache.org> > > > > > > > > On Wed, Jun 9, 2021 at 11:06 AM Michael Marshall <mikemars...@gmail.com> > > > > wrote: > > > > > > > > > > > But I found this problem while trying to upgrade a project that uses > > > > > > Transactions (Pulsar JMS client), it may be a showstopper for the > > > > > > adoption of Transactions. > > > > > > https://github.com/apache/pulsar/issues/10871 > > > > > > > > > > I put together a PR that will allow the transaction topic to get > > > created > > > > > regardless of the value of `allowAutoTopicCreation`: > > > > > https://github.com/apache/pulsar/pull/10876. > > > > > > > > > > Please take a look. > > > > > > > > > > Best, > > > > > Michael > > > > > > > > > > On Wed, Jun 9, 2021 at 4:52 AM Enrico Olivelli <eolive...@gmail.com> > > > > wrote: > > > > > > > > > > > PengHui, > > > > > > I am testing the release and at the moment everything is good. > > > > > > > > > > > > But I found this problem while trying to upgrade a project that uses > > > > > > Transactions (Pulsar JMS client), it may be a showstopper for the > > > > > > adoption of Transactions. > > > > > > > > > > > > https://github.com/apache/pulsar/issues/10871 > > > > > > > > > > > > The problem is about using allowAutoTopicCreation=false together > > > > > > with > > > > > > transactionCoordinatorEnabled=true > > > > > > > > > > > > In the meantime I will continue my testing > > > > > > > > > > > > Enrico > > > > > > > > > > > > Can you please take a look ? > > > > > > > > > > > > Il giorno mer 9 giu 2021 alle ore 12:36 Guangning E > > > > > > <eguangn...@gmail.com> ha scritto: > > > > > > > > > > > > > > +1(non-binding) > > > > > > > > > > > > > > * Build bin package and image > > > > > > > * pub/sub > > > > > > > * Run as a cluster > > > > > > > > > > > > > > Thanks, > > > > > > > Guangning > > > > > > > > > > > > > > Yuri Mizushima <yumiz...@yahoo-corp.jp> 于2021年6月9日周三 下午5:09写道： > > > > > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > > > > > I checked > > > > > > > > * shasum and signature > > > > > > > > * pub/sub and Java Functions > > > > > > > > * connectors > > > > > > > > * stateful functions > > > > > > > > > > > > > > > > Thank you for your work! > > > > > > > > > > > > > > > > -- > > > > > > > > Yuri Mizushima > > > > > > > > yumiz...@yahoo-corp.jp > > > > > > > > > > > > > > > > > > > > > > > > "PengHui Li" <peng...@apache.org> wrote: > > > > > > > > > > > > > > > > Sorry for the typo, > > > > > > > > > > > > > > > > ``` > > > > > > > > > > > > > > > > > > > > > > > > > > > > > 9f7304c3d35db97998a16a46362433c43c61d20eb3d2f51eb43175fa79728925175d47777646c2cd72ad39fc614e425814af1b9a8a8635545cea291a28e28d57 > > > > > > > > apache-pulsar-2.8.0-SNAPSHOT-bin.tar.gz > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > 8fe7e30c3cda0993114996dced0bf49986365a76bcc69b2e68160d6a9e52c9e9a2bc174eba7eb0c7467f6a62e009ee7d8a3457e0e46657ecf8f79f665549a176 > > > > > > > > apache-pulsar-2.8.0-SNAPSHOT-src.tar.gz > > > > > > > > ``` > > > > > > > > > > > > > > > > it should be > > > > > > > > > > > > > > > > ``` > > > > > > > > > > > > > > > > > > > > > > > > > > > > > 9f7304c3d35db97998a16a46362433c43c61d20eb3d2f51eb43175fa79728925175d47777646c2cd72ad39fc614e425814af1b9a8a8635545cea291a28e28d57 > > > > > > > > apache-pulsar-2.8.0-bin.tar.gz > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > 8fe7e30c3cda0993114996dced0bf49986365a76bcc69b2e68160d6a9e52c9e9a2bc174eba7eb0c7467f6a62e009ee7d8a3457e0e46657ecf8f79f665549a176 > > > > > > > > apache-pulsar-2.8.0-src.tar.gz > > > > > > > > ``` > > > > > > > > > > > > > > > > Thanks, > > > > > > > > Penghui > > > > > > > > > > > > > > > > PengHui Li <peng...@apache.org> 于2021年6月8日周二 下午6:37写道： > > > > > > > > > > > > > > > > > This is the second release candidate for Apache Pulsar, > > > > version > > > > > > > > 2.8.0. > > > > > > > > > > > > > > > > > > It fixes the following issues: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/pulsar/pulls?q=is%3Apr+milestone%3A2.8.0+-label%3Arelease%2F2.7.1+-label%3Arelease%2F2.7.2+is%3Aclosed > > > > > > > > > > > > > > > > > > *** Please download, test and vote on this release. This > > > vote > > > > > > will > > > > > > > > stay > > > > > > > > > open > > > > > > > > > for at least 72 hours *** > > > > > > > > > > > > > > > > > > Note that we are voting upon the source (tag), binaries > > > > > > > > are > > > > > > provided > > > > > > > > for > > > > > > > > > convenience. > > > > > > > > > > > > > > > > > > Source and binary files: > > > > > > > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.8.0-candidate-2/ > > > > > > > > > > > > > > > > > > SHA-512 checksums: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > 9f7304c3d35db97998a16a46362433c43c61d20eb3d2f51eb43175fa79728925175d47777646c2cd72ad39fc614e425814af1b9a8a8635545cea291a28e28d57 > > > > > > > > > apache-pulsar-2.8.0-SNAPSHOT-bin.tar.gz > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > 8fe7e30c3cda0993114996dced0bf49986365a76bcc69b2e68160d6a9e52c9e9a2bc174eba7eb0c7467f6a62e009ee7d8a3457e0e46657ecf8f79f665549a176 > > > > > > > > > apache-pulsar-2.8.0-SNAPSHOT-src.tar.gz > > > > > > > > > > > > > > > > > > Maven staging repo: > > > > > > > > > > > > > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachepulsar-1089/ > > > > > > > > > > > > > > > > > > The tag to be voted upon: > > > > > > > > > v2.8.0-candidate-2 > > > (63126b9d6606863c1b889f75737623e1fa9e1638) > > > > > > > > > > > > > https://github.com/apache/pulsar/releases/tag/v2.8.0-candidate-2 > > > > > > > > > > > > > > > > > > Pulsar's KEYS file containing PGP keys we use to sign the > > > > > > release: > > > > > > > > > https://dist.apache.org/repos/dist/dev/pulsar/KEYS > > > > > > > > > > > > > > > > > > Please download the the source package, and follow the > > > > README to > > > > > > > > build > > > > > > > > > and run the Pulsar standalone service. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > Andrey Yegorov > > >
