Re: [VOTE] Pulsar Release 2.6.3 Candidate 1

2021-01-13 Thread PengHui Li
Close this vote, and start the second release candidate. PengHui Li 于2021年1月12日周二 下午4:05写道: > Cool, Thanks Enrico. > > Penghui > On Jan 12, 2021, 4:04 PM +0800, Enrico Olivelli , > wrote: > > Penghui > I am working on the patch now, hopefully it will be an easy fix and it will > be ready in a co

Re: [VOTE] Pulsar Release 2.6.3 Candidate 1

2021-01-12 Thread PengHui Li
Cool, Thanks Enrico. Penghui On Jan 12, 2021, 4:04 PM +0800, Enrico Olivelli , wrote: > Penghui > I am working on the patch now, hopefully it will be an easy fix and it will > be ready in a couple of hours > > Enrico > > Il giorno mar 12 gen 2021 alle ore 04:33 PengHui Li > ha scritto: > > > Hi E

Re: [VOTE] Pulsar Release 2.6.3 Candidate 1

2021-01-12 Thread Enrico Olivelli
Penghui I am working on the patch now, hopefully it will be an easy fix and it will be ready in a couple of hours Enrico Il giorno mar 12 gen 2021 alle ore 04:33 PengHui Li ha scritto: > Hi Enrico, Sijie, > > We found another break change introduced in 2.6.3 and I have push a fix for > Fixing t

Re: [VOTE] Pulsar Release 2.6.3 Candidate 1

2021-01-11 Thread PengHui Li
Hi Enrico, Sijie, We found another break change introduced in 2.6.3 and I have push a fix for Fixing this problem, you can get more details at  https://github.com/apache/pulsar/pull/9182 I will start a new vote candidate after the #9182 merged. @Enrico, if you are interested in provide a patch f

Re: [VOTE] Pulsar Release 2.6.3 Candidate 1

2021-01-11 Thread Sijie Guo
Hi Enrico, > and especially they are missing important files needed at build time for instance, this file is important because it impacts the final binaries I don't think this is a blocker for a release. The lombok config is a setting for configuring how the code was generated. It doesn't direct

Re: [VOTE] Pulsar Release 2.6.3 Candidate 1

2021-01-11 Thread PengHui Li
Hi Enrico, Thanks for point out this. If this is a problem that already exists before not break in 2.6.3 It’s better to keep moving forward the 2.6.3 release. We can fix it in the master branch and On board the fix in 2.7.1. This will facilitate rapid iteration. If this is a break change introd

Re: [VOTE] Pulsar Release 2.6.3 Candidate 1

2021-01-11 Thread Lari Hotari
Hi, I was checking the list of changes for 2.6.3 and spotted a possible unintended change in behavior introduced as part of PR #9113. I added a comment on the PR about the change: https://github.com/apache/pulsar/pull/9113#discussion_r555021563 I'd assume that the impact is that BatchReceivePoli

Re: [VOTE] Pulsar Release 2.6.3 Candidate 1

2021-01-11 Thread Enrico Olivelli
Hi, thank you PengHui Li, I am validating the release, most of my tests are passing: - checksums/signatures - smoke tests with the binaries But I think I have come to a blocker for a release basically the staged sources do not match the git tag, and especially they are missing important files nee

[VOTE] Pulsar Release 2.6.3 Candidate 1

2021-01-10 Thread PengHui Li
This is the first release candidate for Apache Pulsar, version 2.6.3. It fixes the following issues:https://github.com/apache/pulsar/pulls?q=is%3Apr+label%3Arelease%2F2.6.3+is%3Aclosed *** Please download, test and vote on this release. This vote will stay open for at least 72 hours *** Note tha