Penghui I am working on the patch now, hopefully it will be an easy fix and it will be ready in a couple of hours
Enrico Il giorno mar 12 gen 2021 alle ore 04:33 PengHui Li <codelipeng...@gmail.com> ha scritto: > Hi Enrico, Sijie, > > We found another break change introduced in 2.6.3 and I have push a fix for > Fixing this problem, you can get more details at > https://github.com/apache/pulsar/pull/9182 > > I will start a new vote candidate after the #9182 merged. > > @Enrico, if you are interested in provide a patch for fixing source code > problem, very grateful. > We can consider onboard this fix if it can done soon. If you don’t have > time to deal with this stuff, > I will take a look and try to fix it. > > Thanks, > Penghui > > Penghui > On Jan 12, 2021, 9:22 AM +0800, Sijie Guo <guosi...@gmail.com>, wrote: > > Hi Enrico, > > > > > and especially they > > are missing important files needed at build time > > for instance, this file is important because it impacts the final > > binaries > > > > I don't think this is a blocker for a release. The lombok config is a > > setting for configuring how the code was generated. > > > > It doesn't directly impact both source and binary releases. So my > > suggestion is moving forward and we can include this in future releases. > > > > - Sijie > > > > > > On Mon, Jan 11, 2021 at 4:48 PM PengHui Li <codelipeng...@gmail.com> > wrote: > > > > > Hi Enrico, > > > > > > Thanks for point out this. If this is a problem that already exists > before > > > not break in 2.6.3 > > > It’s better to keep moving forward the 2.6.3 release. We can fix it in > the > > > master branch and > > > On board the fix in 2.7.1. This will facilitate rapid iteration. If > this > > > is a break change introduced > > > In 2.6.3. we should stop this candidate and start a new candidate with > the > > > fix. > > > > > > > I will be happy to provide a patch. > > > > > > Thanks, looking forward to your patch. > > > > > > Thanks, > > > Penghui > > > On Jan 11, 2021, 9:06 PM +0800, Enrico Olivelli <eolive...@gmail.com>, > > > wrote: > > > > Hi, > > > > thank you PengHui Li, > > > > I am validating the release, most of my tests are passing: > > > > - checksums/signatures > > > > - smoke tests with the binaries > > > > > > > > But I think I have come to a blocker for a release > > > > > > > > basically the staged sources do not match the git tag, and especially > > > they > > > > are missing important files needed at build time > > > > for instance this file that is important because it impact the final > > > > binaries > > > > > > > > https://github.com/apache/pulsar/blob/master/pulsar-io/jdbc/lombok.config > > > > > > > > AFAIK It would be okay to have a source release that does not > perfectly > > > > match the git tag, by removing useless stuff for the build (like > .github > > > > folder...) > > > > but users that download that source tarball must be able to build the > > > > project and use the resulting binaries. > > > > > > > > I have dug into the problem and basically from my point of view the > > > problem > > > > is that we are not using the maven-source-plugin, that by default > works > > > > very well > > > > but we have a custom packager in > distribution/server/src/assemble/src.xml > > > > that is manually selecting the files to include/exclude > > > > > > > > As we are an Apache project, my suggestion it to simply use the > artifact > > > > pulsar-source-release.zip that is automatically crated into "target" > > > > directory during the release process > > > > If you want to test it just do: > > > > mvn package -Papache-release -N > > > > you can configure the name and the type in pom.xml (overriding > > > > maven-source-release plugin configuration) > > > > I will be happy to provide a patch. > > > > > > > > I am still validating the release, but I wanted to point out this > issue > > > as > > > > soon as possible > > > > > > > > Best regards > > > > Enrico > > > > > > > > Il giorno lun 11 gen 2021 alle ore 07:36 PengHui Li < > peng...@apache.org> > > > ha > > > > scritto: > > > > > > > > > This is the first release candidate for Apache Pulsar, version > 2.6.3. > > > > > > > > > > It fixes the following > > > > > issues: > > > > > > > > > https://github.com/apache/pulsar/pulls?q=is%3Apr+label%3Arelease%2F2.6.3+is%3Aclosed > > > > > > > > > > *** Please download, test and vote on this release. This vote will > stay > > > > > open > > > > > for at least 72 hours *** > > > > > > > > > > Note that we are voting upon the source (tag), binaries are > provided > > > for > > > > > convenience. > > > > > > > > > > Source and binary > > > > > files: > > > > > > > > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.6.3-candidate-1/ > > > > > > > > > > SHA-1 checksums: > > > > > > > > > > e620672cb560b5947069e4e22be9b0e1bd08c327 > > > > > apache-pulsar-2.6.3-SNAPSHOT-bin.tar.gz > > > > > dc8a5e38fed5ae81e01e3a9a3e97a921c2b49607 > > > > > apache-pulsar-2.6.3-SNAPSHOT-src.tar.gz > > > > > > > > > > Maven staging repo: > > > > > > > > > https://repository.apache.org/content/repositories/orgapachepulsar-1077/ > > > > > > > > > > The tag to be voted upon: > > > > > v2.6.3-candidate-1 > > > > > (a63f90059cf1209d33a79811dd08cdf277261453) > > > > > https://github.com/apache/pulsar/releases/tag/v2.6.3-candidate-1 > > > > > > > > > > Pulsar's KEYS file containing PGP keys we use to sign the > > > > > release:https://dist.apache.org/repos/dist/release/pulsar/KEYS > > > > > > > > > > Please download the the source package, and follow the README to > build > > > > > and run the Pulsar standalone service. > > > > > > > > >
