Re: [VOTE] Pulsar Release 2.4.2 Candidate 1

2019-11-24 Thread xiaolong ran
> It seems that 5308 > was already cherry-picked to branch-2.4. Why didn't it go out with 2.4.2 > rc1? Hi Sijie: Yes, the #5308 was cherry-picked to branch-2.4, but it is not in 2.4.2-candidate-1(I missed #5308), so we need to package #5308 to v2.4.2-candidate-2. -- Thanks Xiaolong Ran > 在 2

Re: [VOTE] Pulsar Release 2.4.2 Candidate 1

2019-11-24 Thread Sijie Guo
Xiaolong, I checked https://github.com/apache/pulsar/pull/5308 . It seems that 5308 was already cherry-picked to branch-2.4. Why didn't it go out with 2.4.2 rc1? - Sijie On Sun, Nov 24, 2019 at 7:58 PM xiaolong ran wrote: > Thanks Chris Bartholomew work for this. > > > This should be changed b

Re: [VOTE] Pulsar Release 2.4.2 Candidate 1

2019-11-24 Thread xiaolong ran
Thanks Chris Bartholomew work for this. > This should be changed back to non-partitioned before releasing 2.4.2. It has > already been reverted in master: This feature looks more like enhancement than break, it allows user-defined topics to be partition or non-partition. I will cherry-pick the

Re: [VOTE] Pulsar Release 2.4.2 Candidate 1

2019-11-22 Thread Chris Bartholomew
-1 It looks like the default auto-created topic type has changed from non-partitioned to partitioned. This is a significant change that breaks things. One example is the function trigger command. When the function output topic is auto-created as partitioned, the trigger command which uses a rea

Re: [VOTE] Pulsar Release 2.4.2 Candidate 1

2019-11-22 Thread 丛搏
+1 (non-bind) https://github.com/apache/pulsar/wiki/Release-Candidate-Validation Validate checksum Validate the binary distribution Validate Pub/Sub and Java Functions Validate Connectors Validate Stateful Functions Validate RPM and DEB packages Thanks! -- Bo Cong xiaolong ran 于2019年11月22日周五 上午11

Re: [VOTE] Pulsar Release 2.4.2 Candidate 1

2019-11-22 Thread 丛搏
+1 (non-bind) https://github.com/apache/pulsar/wiki/Release-Candidate-Validation Validate checksum Validate the binary distribution Validate Pub/Sub and Java Functions Validate Connectors Validate Stateful Functions Validate RPM and DEB packages Thanks! -- Bo Cong Guangning E 于2019年11月22日周五 下午1:1

Re: [VOTE] Pulsar Release 2.4.2 Candidate 1

2019-11-21 Thread Guangning E
+1 (non-bind) https://github.com/apache/pulsar/wiki/Release-Candidate-Validation Validate checksum Validate the binary distribution Validate Pub/Sub and Java Functions Validate Connectors Validate Stateful Functions Validate RPM and DEB packages Guangning, Thanks xiaolong ran 于2019年11月22日周五 上午11

[VOTE] Pulsar Release 2.4.2 Candidate 1

2019-11-21 Thread xiaolong ran
Hi everyone, This is the first release candidate for Apache Pulsar, version 2.4.2. as follows: - [ ] +1, Approve the release - [ ] -1, Do not approve the release (please provide specific comments) It fixes the following issues: https://github.com/apache/pulsar/milestone/25?closed=1 *** Please d