Xiaolong,

I checked https://github.com/apache/pulsar/pull/5308 . It seems that 5308
was already cherry-picked to branch-2.4. Why didn't it go out with 2.4.2
rc1?

- Sijie

On Sun, Nov 24, 2019 at 7:58 PM xiaolong ran <ranxiaolong...@gmail.com>
wrote:

> Thanks Chris Bartholomew work for this.
>
> > This should be changed back to non-partitioned before releasing 2.4.2.
> It has already been reverted in master:
>
> This feature looks more like enhancement than break, it allows
> user-defined topics to be partition or non-partition.
> I will cherry-pick the #5308 to branch-2.4, make sure that the type of
> topic created automatically in `branch-2.4` is non-partition.
>
> --
>
> Thanks
> Xiaolong Ran
>
> > 在 2019年11月23日,上午1:28,Chris Bartholomew <c_bartholo...@yahoo.com.INVALID>
> 写道:
> >
> > -1
> > It looks like the default auto-created topic type has changed from
> non-partitioned to partitioned. This is a significant change that breaks
> things. One example is the function trigger command. When the function
> output topic is auto-created as partitioned, the trigger command which uses
> a reader interface can no longer connect and the command always returns a
> 500 error. This just the first example I found, there are probably others.
> > This should be changed back to non-partitioned before releasing 2.4.2.
> It has already been reverted in master:
> > https://github.com/apache/pulsar/pull/5308
> >
> > Cheers,Chris
> >    On Friday, November 22, 2019, 12:15:28 AM EST, Guangning E <
> eguangn...@gmail.com> wrote:
> >
> > +1 (non-bind)
> > https://github.com/apache/pulsar/wiki/Release-Candidate-Validation
> > Validate checksum
> > Validate the binary distribution
> > Validate Pub/Sub and Java Functions
> > Validate Connectors
> > Validate Stateful Functions
> > Validate RPM and DEB packages
> >
> > Guangning,
> > Thanks
> >
> > xiaolong ran <ranxiaolong...@gmail.com> 于2019年11月22日周五 上午11:05写道:
> >
> >> Hi everyone,
> >>
> >> This is the first release candidate for Apache Pulsar, version 2.4.2.
> >>
> >> as follows:
> >> - [ ] +1, Approve the release
> >> - [ ] -1, Do not approve the release (please provide specific comments)
> >>
> >> It fixes the following issues:
> >> https://github.com/apache/pulsar/milestone/25?closed=1
> >>
> >> *** Please download, test and vote on this release. This vote will stay
> >> open
> >> for at least 72 hours ***
> >>
> >> Note that we are voting upon the source (tag), binaries are provided for
> >> convenience.
> >>
> >> Source and binary files:
> >> https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.4.2-candidate-1/
> >>
> >> SHA-512 checksums:
> >> -
> >>
> 5a8711ab6266143fa131c4c35136c66e32e1e2d482092c4ee007e68098d6bcef3c420d71ff78a0ef5e8a9fb50241f03288ec673cfc020392380b18802a96b438
> >> apache-pulsar-2.4.2-bin.tar.gz
> >> -
> >>
> 8b291f80372e13ddada1cf84226afa8242bf603b50be5e567aca3adfa31316a15a3d2f2ec3f38d7f26e253ad27b4810072759ae660c1b5dea8fe7c053cb135e1
> >> apache-pulsar-2.4.2-src.tar.gz
> >>
> >> Maven staging repo:
> >>
> https://repository.apache.org/content/repositories/orgapachepulsar-1054/
> >>
> >> The tag to be voted upon:
> >> v2.4.2-candidate-1
> >> https://github.com/apache/pulsar/releases/tag/v2.4.2-candidate-1
> >>
> >> Pulsar's KEYS file containing PGP keys we use to sign the release:
> >> https://dist.apache.org/repos/dist/dev/pulsar/KEYS
> >>
> >> Please download the the source package, and follow the README to build
> >> and run the Pulsar standalone service.
> >>
> >>
> >> --
> >>
> >> Thanks
> >> Xiaolong ran
> >>
> >>
>
>

Reply via email to