Re: [VOTE] Pulsar Node.js Client Release 1.8.2 Candidate 1

2023-04-11 Thread Baodi Shi
Hi, all The 1.8.2-rc.2 has been released. Please help verify it. It contains the following two PRs: - https://github.com/apache/pulsar-client-node/pull/316 - https://github.com/apache/pulsar-client-node/pull/309 https://lists.apache.org/thread/72240tgq5bct78rdslzc689w6h9nb8z0 Thanks, B

Re: [VOTE] Pulsar Node.js Client Release 1.8.2 Candidate 1

2023-04-11 Thread Zike Yang
Hi, all I have created a PR https://github.com/apache/pulsar-client-node/pull/316 for that issue. PTAL and help review. Thanks, Zike Yang On Tue, Apr 11, 2023 at 5:57 PM Baodi Shi wrote: > > Hi, @Nozomi Kurihara > > Ok, We can wait for this issue fixed > https://github.com/apache/pulsar-client

Re: [VOTE] Pulsar Node.js Client Release 1.8.2 Candidate 1

2023-04-11 Thread Baodi Shi
Hi, @Nozomi Kurihara Ok, We can wait for this issue fixed https://github.com/apache/pulsar-client-node/issues/315. Thanks, Baodi Shi On Apr 11, 2023 at 17:54:56, Nozomi Kurihara wrote: > Hi Baodi, Zike, > > Thank you for clarifying the issue status. > Although this is not a regression bug,

Re: [VOTE] Pulsar Node.js Client Release 1.8.2 Candidate 1

2023-04-11 Thread Nozomi Kurihara
Hi Baodi, Zike, Thank you for clarifying the issue status. Although this is not a regression bug, I prefer including the fix to the current 1.8.2 release since it is easily reproducible and causes unlimited memory usage increase. Thanks, Nozomi 2023年4月11日(火) 18:01 Zike Yang : > Hi, > > https://

Re: [VOTE] Pulsar Node.js Client Release 1.8.2 Candidate 1

2023-04-11 Thread Zike Yang
Hi, https://github.com/apache/pulsar-client-node/issues/308 is not a regression bug. I don't think we need to block this RC. > May you share the link to the issue? There seems no such reference in PR-309. I have created an issue to track it: https://github.com/apache/pulsar-client-node/issues/31

Re: [VOTE] Pulsar Node.js Client Release 1.8.2 Candidate 1

2023-04-11 Thread tison
Hi Baodi, > there is one Reader related issue May you share the link to the issue? There seems no such reference in PR-309. Best, tison. Baodi Shi 于2023年4月11日周二 16:17写道: > Hi, > I noticed that there is one Reader related issue for this that needs to be > fixed, so I guess it could be include

Re: [VOTE] Pulsar Node.js Client Release 1.8.2 Candidate 1

2023-04-11 Thread Baodi Shi
Hi, I noticed that there is one Reader related issue for this that needs to be fixed, so I guess it could be included in 1.8.3. Thanks Baodi Shi On Tue, Apr 11, 2023 at 15:39 Nozomi Kurihara wrote: > Hi Baodi, > > Thank you for starting the release process. > > I think https://github.com/apache

Re: [VOTE] Pulsar Node.js Client Release 1.8.2 Candidate 1

2023-04-11 Thread Nozomi Kurihara
Hi Baodi, Thank you for starting the release process. I think https://github.com/apache/pulsar-client-node/pull/309 seems an important fix. Should we include it in the 1.8.2 release or postpone it to the next release? Thanks, Nozomi

Re: [VOTE] Pulsar Node.js Client Release 1.8.2 Candidate 1

2023-04-10 Thread Yunze Xu
+1 (binding) * Checked signatures and checksums * Build from source and run e2e examples (Ubuntu 20.04 and Node.js v16.19.0) * Install from NPM and run e2e examples with OAuth2 authentication through StreamNative cloud (Ubuntu 20.04 and Node.js v16.19.0, node:19-bullseye container) Thanks, Yunze

[VOTE] Pulsar Node.js Client Release 1.8.2 Candidate 1

2023-04-09 Thread Baodi Shi
Hi everyone, This is the first release candidate for Apache Pulsar Node.js client, version 1.8.2. It fixes the following issues: https://github.com/apache/pulsar-client-node/pulls?q=is%3Apr+label%3Arelease%2Fv1.8.2+is%3Aclosed