Hi, all I have created a PR https://github.com/apache/pulsar-client-node/pull/316 for that issue. PTAL and help review.
Thanks, Zike Yang On Tue, Apr 11, 2023 at 5:57 PM Baodi Shi <ba...@apache.org> wrote: > > Hi, @Nozomi Kurihara <nkuri...@apache.org> > > Ok, We can wait for this issue fixed > https://github.com/apache/pulsar-client-node/issues/315. > > > Thanks, > Baodi Shi > > > On Apr 11, 2023 at 17:54:56, Nozomi Kurihara <nkuri...@apache.org> wrote: > > > Hi Baodi, Zike, > > > > Thank you for clarifying the issue status. > > Although this is not a regression bug, I prefer including the fix to the > > current 1.8.2 release since it is easily reproducible and causes unlimited > > memory usage increase. > > > > Thanks, > > Nozomi > > > > 2023年4月11日(火) 18:01 Zike Yang <z...@apache.org>: > > > > Hi, > > > > > > https://github.com/apache/pulsar-client-node/issues/308 is not a > > > > regression bug. I don't think we need to block this RC. > > > > > > > May you share the link to the issue? There seems no such reference in > > > > PR-309. > > > > > > I have created an issue to track it: > > > > https://github.com/apache/pulsar-client-node/issues/315 > > > > > > But if you all want to include that fix, I can push a PR soon. > > > > > > Thanks, > > > > Zike Yang > > > > > > On Tue, Apr 11, 2023 at 4:29 PM tison <wander4...@gmail.com> wrote: > > > > > > > > > > Hi Baodi, > > > > > > > > > > > there is one Reader related issue > > > > > > > > > > May you share the link to the issue? There seems no such reference in > > > > > PR-309. > > > > > > > > > > Best, > > > > > tison. > > > > > > > > > > > > > > > Baodi Shi <ba...@apache.org> 于2023年4月11日周二 16:17写道： > > > > > > > > > > > Hi, > > > > > > I noticed that there is one Reader related issue for this that needs > > > > to be > > > > > > fixed, so I guess it could be included in 1.8.3. > > > > > > > > > > > > Thanks > > > > > > Baodi Shi > > > > > > > > > > > > On Tue, Apr 11, 2023 at 15:39 Nozomi Kurihara <nkuri...@apache.org> > > > > wrote: > > > > > > > > > > > > > Hi Baodi, > > > > > > > > > > > > > > Thank you for starting the release process. > > > > > > > > > > > > > > I think https://github.com/apache/pulsar-client-node/pull/309 seems > > > > an > > > > > > > important fix. > > > > > > > Should we include it in the 1.8.2 release or postpone it to the next > > > > > > > release? > > > > > > > > > > > > > > Thanks, > > > > > > > Nozomi > > > > > > > > > > > > > -- > > > > > > > > > > > > Thanks > > > > > > Baodi Shi > > > > > > > > > > > >
