Re: [VOTE] Pulsar Client Go Release 0.12.0 Candidate 2

2024-01-21 Thread Yunze Xu
I agree with retaining this file in this 0.12.0 release to avoid some unexpected changes. We can estimate whether it's safe to remove the VERSION file later. Thanks, Yunze On Mon, Jan 22, 2024 at 10:18 AM Zike Yang wrote: > > Hi yunze, > > Thanks for reporting this. Actually, the `VERSION` file

Re: [VOTE] Pulsar Client Go Release 0.12.0 Candidate 2

2024-01-21 Thread Zike Yang
Hi yunze, Thanks for reporting this. Actually, the `VERSION` file is not used in the code even before that PR. We currently have two hardcoded version files in place: `VERSION` which represents the current version and `stable.txt` which represents the current stable version. However, I'm curious

Re: [VOTE] Pulsar Client Go Release 0.12.0 Candidate 2

2024-01-19 Thread Yunze Xu
The VERSION file is still 0.11.1, which is not updated. But it seems that this VERSION file is not used anywhere. I checked the stats and found the "clientVersion" is "Pulsar Go v0.12.0-candidate-2", which is expected. I see https://github.com/apache/pulsar-client-go/pull/856 supports getting the

[VOTE] Pulsar Client Go Release 0.12.0 Candidate 2

2024-01-14 Thread Zike Yang
Hi everyone, Please review and vote on the release candidate #2 for the version 0.12.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) This is the second release candidate for Apache Pulsar Go client, version 0.12.0. The release note/