I agree with retaining this file in this 0.12.0 release to avoid some unexpected changes. We can estimate whether it's safe to remove the VERSION file later.
Thanks, Yunze On Mon, Jan 22, 2024 at 10:18 AM Zike Yang <z...@apache.org> wrote: > > Hi yunze, > > Thanks for reporting this. Actually, the `VERSION` file is not used in > the code even before that PR. We currently have two hardcoded version > files in place: `VERSION` which represents the current version and > `stable.txt` which represents the current stable version. However, I'm > curious about the intended function of these files. Are they merely > for developers to conveniently reference the current and stable > versions? And what is our approach to managing these files? For > instance, how do we determine what constitutes a stable version? If > there's no compelling reason to keep these files, I'd support their > removal. > > Regarding the current 0.12.0 release, before we make a consensus on > whether we should remove these files. I can update the current version > in those files in the next release candidate. > > Thanks, > Zike Yang > > On Fri, Jan 19, 2024 at 4:27 PM Yunze Xu <x...@apache.org> wrote: > > > > The VERSION file is still 0.11.1, which is not updated. But it seems > > that this VERSION file is not used anywhere. I checked the stats and > > found the "clientVersion" is "Pulsar Go v0.12.0-candidate-2", which is > > expected. > > > > I see https://github.com/apache/pulsar-client-go/pull/856 supports > > getting the version from the dependency, then the hard-coded VERSION > > file is no longer needed. I think we can remove that file in the > > 0.12.0 or next release. But we should not maintain a file that could > > make users confused (i.e. the source code of 0.12.0 contains a version > > file of 0.11.1) > > > > Thanks, > > Yunze > > > > On Mon, Jan 15, 2024 at 2:41 PM Zike Yang <z...@apache.org> wrote: > > > > > > Hi everyone, > > > Please review and vote on the release candidate #2 for the version > > > 0.12.0, as follows: > > > [ ] +1, Approve the release > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > This is the second release candidate for Apache Pulsar Go client, > > > version 0.12.0. > > > > > > The release note/changelog for Go client 0.12.0: > > > https://github.com/apache/pulsar-client-go/pull/1153/files > > > > > > Pulsar Client Go's KEYS file contains PGP keys we used to sign this > > > release: > > > https://downloads.apache.org/pulsar/KEYS > > > > > > Please download these packages and review this release candidate: > > > - Review release notes: > > > https://github.com/apache/pulsar-client-go/pull/1153 > > > - Download the source package (verify shasum, and asc) and follow the > > > README.md to build and run the pulsar-client-go. > > > > > > The vote will be open for at least 72 hours. It is adopted by majority > > > approval, with at least 3 PMC affirmative votes. > > > > > > Source file: > > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-go-0.12.0-candidate-2/ > > > > > > The tag to be voted upon: > > > v0.12.0-candidate-2 > > > https://github.com/apache/pulsar-client-go/tree/v0.12.0-candidate-2 > > > > > > SHA-512 checksums: > > > e3c0845f60989b9ca4f6cf683d750c9361ca0e15ae7f8d990cfe14d7af86bd80475aeeda95870f2b8ef6fe8ec5fdbd59c67876546e282d76baae9a1737c6a7aa > > > apache-pulsar-client-go-0.12.0-src.tar.gz
