Re: [VOTE] Pulsar Client C++ Release 3.4.0 Candidate 2

2023-11-12 Thread Yunze Xu
Closing this vote by 3 binding +1s: - Penghui - Yunze - Mattison Thanks, Yunze On Mon, Nov 13, 2023 at 11:14 AM Yunze Xu wrote: > > In addition to Mattison's failure. The > `LookupServiceTest.testMultiAddresses` failed because the HTTP proxy > is enabled. See https://github.com/apache/pulsar-c

Re: [VOTE] Pulsar Client C++ Release 3.4.0 Candidate 2

2023-11-12 Thread Yunze Xu
In addition to Mattison's failure. The `LookupServiceTest.testMultiAddresses` failed because the HTTP proxy is enabled. See https://github.com/apache/pulsar-client-cpp/issues/343 In addition, I edited the wiki to note proxy should be disabled because many failed tests could be caused by the proxy:

Re: [VOTE] Pulsar Client C++ Release 3.4.0 Candidate 2

2023-11-12 Thread mattison chao
+1(binding) Some failing tests are unstable and state-dependent, and the test passes after retrying. Best, Mattison > On Nov 12, 2023, at 22:10, mattison chao wrote: > > Hi, Yunze > > I’ve got several failed tests. > > [--] Global test environment tear-down > [==] 528 tests

Re: [VOTE] Pulsar Client C++ Release 3.4.0 Candidate 2

2023-11-12 Thread mattison chao
Hi, Yunze I’ve got several failed tests. [--] Global test environment tear-down [==] 528 tests from 85 test suites ran. (888193 ms total) [ PASSED ] 525 tests. [ FAILED ] 3 tests, listed below: [ FAILED ] CustomLoggerTest.testCustomLogger [ FAILED ] LookupServiceTest.testM

Re: [VOTE] Pulsar Client C++ Release 3.4.0 Candidate 2

2023-11-09 Thread PengHui Li
+1 (binding) - Checked the signature - Build from source and run the tests Regards, Penghui On Thu, Nov 9, 2023 at 5:15 PM Yunze Xu wrote: > +1 (binding) > > - Verified checksum and signatures > - Built from source and run unit tests against the test standalone on > macOS Ventura 13.4 and Appl

Re: [VOTE] Pulsar Client C++ Release 3.4.0 Candidate 2

2023-11-09 Thread Yunze Xu
+1 (binding) - Verified checksum and signatures - Built from source and run unit tests against the test standalone on macOS Ventura 13.4 and Apple Clang 14.0.3 A tip for the failed LookupServiceTest.testMultiAddresses I mentioned before, it's because this test has a too strict requirement that th

Re: [VOTE] Pulsar Client C++ Release 3.4.0 Candidate 2

2023-11-08 Thread Yunze Xu
Hi Penghui, It's caused by the relative path and I explained it that issue. Here is an improvement for tests: https://github.com/apache/pulsar-client-cpp/pull/340. Thanks, Yunze

Re: [VOTE] Pulsar Client C++ Release 3.4.0 Candidate 2

2023-11-08 Thread PengHui Li
Hi Yunze, Thanks for the reminder. I enabled the proxy on my laptop. After disabling the proxy, the timeout issue is gone. Now, all the tests get passed except two consistently failed tests related to the token test. I have created a GitHub issue. https://github.com/apache/pulsar-client-cpp/iss

Re: [VOTE] Pulsar Client C++ Release 3.4.0 Candidate 2

2023-11-08 Thread Yunze Xu
I think it's caused by the ClientTest.testConnectTimeout. The resources seem not cleaned well in this test so it affected the tests later. Could you try the following command that ignores this test? ```bash ./pulsar-tests --gtest_filter='-ClientTest.testConnectTimeout' ``` If the rest of the tes

Re: [VOTE] Pulsar Client C++ Release 3.4.0 Candidate 2

2023-11-08 Thread PengHui Li
Hi Yunze, I got an error when running the pulsar-tests (I tried multiple times, same error) ``` 2023-11-08 22:56:43.676 INFO [0x16db63000] ProducerImpl:216 | [persistent://public/default/testPartitionedConsumerUnexpectedAckTimeout1699455403-partition-1, ] Created producer on broker [[::1]:58479

Re: [VOTE] Pulsar Client C++ Release 3.4.0 Candidate 2

2023-11-08 Thread Yubiao Feng
Hi all Sorry, I'll send another email explaining what tests were done. Please ignore the previous email. Thanks Yubiao Feng On Wed, Nov 8, 2023 at 11:48 AM Yubiao Feng wrote: > +1 (no-binding) > > Thanks > Yubiao Feng > > On Tue, Nov 7, 2023 at 3:03 PM Yunze Xu wrote: > >> This is the secon

Re: [VOTE] Pulsar Client C++ Release 3.4.0 Candidate 2

2023-11-07 Thread Yubiao Feng
+1 (no-binding) Thanks Yubiao Feng On Tue, Nov 7, 2023 at 3:03 PM Yunze Xu wrote: > This is the second release candidate for Apache Pulsar Client C++, > version 3.4.0. > > It fixes the following issues: > https://github.com/apache/pulsar-client-cpp/milestone/5?closed=1 > > *** Please download,

[VOTE] Pulsar Client C++ Release 3.4.0 Candidate 2

2023-11-06 Thread Yunze Xu
This is the second release candidate for Apache Pulsar Client C++, version 3.4.0. It fixes the following issues: https://github.com/apache/pulsar-client-cpp/milestone/5?closed=1 *** Please download, test and vote on this release. This vote will stay open for at least 72 hours *** Note that we ar