In addition to Mattison's failure. The
`LookupServiceTest.testMultiAddresses` failed because the HTTP proxy
is enabled. See https://github.com/apache/pulsar-client-cpp/issues/343

In addition, I edited the wiki to note proxy should be disabled
because many failed tests could be caused by the proxy:
https://github.com/apache/pulsar-client-cpp/wiki/Committer-Release-Guide#run-the-vote

Thanks,
Yunze

On Mon, Nov 13, 2023 at 10:05 AM mattison chao <mattisonc...@gmail.com> wrote:
>
> +1(binding)
>
> Some failing tests are unstable and state-dependent, and the test passes 
> after retrying.
>
>
> Best,
> Mattison
>
> > On Nov 12, 2023, at 22:10, mattison chao <mattisonc...@gmail.com> wrote:
> >
> > Hi, Yunze
> >
> > I’ve got several failed tests.
> >
> > [----------] Global test environment tear-down
> > [==========] 528 tests from 85 test suites ran. (888193 ms total)
> > [  PASSED  ] 525 tests.
> > [  FAILED  ] 3 tests, listed below:
> > [  FAILED  ] CustomLoggerTest.testCustomLogger
> > [  FAILED  ] LookupServiceTest.testMultiAddresses
> > [  FAILED  ] c_ConsumerTest.testCDeadLetterTopic
> >
> >
> > After rerun, the second and third tests still failed.
> >
> > /Users/mattisonchao/projects/apache/pulsar-client-cpp/tests/c/c_ConsumerTest.cc:182:
> >  Failure
> > Expected equality of these values:
> >   pulsar_result_Timeout
> >     Which is: 3
> >   res
> >     Which is: 0
> >
> > [  FAILED  ] c_ConsumerTest.testCDeadLetterTopic (75 ms)
> > [----------] 1 test from c_ConsumerTest (75 ms total)
> >
> > [----------] Global test environment tear-down
> > [==========] 1 test from 1 test suite ran. (75 ms total)
> > [  PASSED  ] 0 tests.
> > [  FAILED  ] 1 test, listed below:
> > [  FAILED  ] c_ConsumerTest.testCDeadLetterTopic
> >
> >
> > Expected equality of these values:
> >   std::count(results.cbegin(), results.cend(), ResultRetryable)
> >     Which is: 0
> >   numRequests / 2
> >     Which is: 3
> >
> > 2023-11-12 22:10:03.538 INFO  [0x1e483d300] ClientConnection:268 | [<none> 
> > -> pulsar://localhost:9999] Destroyed connection to pulsar://localhost:9999
> > [  FAILED  ] LookupServiceTest.testMultiAddresses (89 ms)
> > [----------] 1 test from LookupServiceTest (89 ms total)
> >
> > [----------] Global test environment tear-down
> > [==========] 1 test from 1 test suite ran. (89 ms total)
> > [  PASSED  ] 0 tests.
> > [  FAILED  ] 1 test, listed below:
> > [  FAILED  ] LookupServiceTest.testMultiAddresses
> >
> >
> >
> > Best,
> > Mattison
> >
> >> On Nov 7, 2023, at 15:03, Yunze Xu <x...@apache.org> wrote:
> >>
> >> This is the second release candidate for Apache Pulsar Client C++,
> >> version 3.4.0.
> >>
> >> It fixes the following issues:
> >> https://github.com/apache/pulsar-client-cpp/milestone/5?closed=1
> >>
> >> *** Please download, test and vote on this release. This vote will stay 
> >> open
> >> for at least 72 hours ***
> >>
> >> Note that we are voting upon the source (tag), binaries are provided for
> >> convenience.
> >>
> >> Source and binary files:
> >> https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-cpp/pulsar-client-cpp-3.4.0-candidate-2/
> >>
> >> SHA-512 checksums:
> >>
> >> 10517590a2e4296d6767a044e58dd32c79e404a5136cf41126f4cb2416ed0ef8fb1ad7aa7da54c37c12ed71b05a527ed08bfac9d50d3550fa5d475c1e8c00950
> >> apache-pulsar-client-cpp-3.4.0.tar.gz
> >>
> >>
> >> The tag to be voted upon:
> >> v3.4.0-candidate-2 (f337eff7caae93730ec1260810655cbb5a345e70)
> >> https://github.com/apache/pulsar-client-cpp/releases/tag/v3.4.0-candidate-2
> >>
> >> Pulsar's KEYS file containing PGP keys you use to sign the release:
> >> https://downloads.apache.org/pulsar/KEYS
> >>
> >> Please download the source package, and follow the README to compile and 
> >> test.
> >
>

Reply via email to