Re: [VOTE] PIP-357: Correct the conf name in load balance module.

2024-06-06 Thread PengHui Li
+1 (binding) Regards, Penghui On Thu, Jun 6, 2024 at 3:25 PM thetumbled wrote: > The vote is approved with 3 binding votes and close now. > Votes: > - Kai Wang(non-binding) > - Yunze Xu(binding) > - guo jiwei(binding) > - Yubiao Feng(binding) > > Thank you all for verifying and voting! > Wenzhi

Re: [VOTE] PIP-357: Correct the conf name in load balance module.

2024-06-06 Thread thetumbled
The vote is approved with 3 binding votes and close now. Votes: - Kai Wang(non-binding) - Yunze Xu(binding) - guo jiwei(binding) - Yubiao Feng(binding) Thank you all for verifying and voting! Wenzhi Feng. On 2024/06/06 07:19:34 Yubiao Feng wrote: > +1 binding > > Thanks > Yubiao Feng > > On We

Re: [VOTE] PIP-357: Correct the conf name in load balance module.

2024-06-06 Thread Yubiao Feng
+1 binding Thanks Yubiao Feng On Wed, Jun 5, 2024 at 10:33 AM thetumbled wrote: > Hi, Pulsar Community. > I would like to start the voting thread for PIP-357: Correct the conf > name in load balance module. > Proposal PR: https://github.com/apache/pulsar/pull/22823 > Implementation PR: h

Re: [VOTE] PIP-357: Correct the conf name in load balance module.

2024-06-06 Thread guo jiwei
+1 (binding) Regards Jiwei Guo (Tboy) On Thu, Jun 6, 2024 at 3:05 PM Yunze Xu wrote: > +1 (binding) > > Thanks, > Yunze > > On Wed, Jun 5, 2024 at 6:25 PM thetumbled wrote: > > > > Hi PengHui, > > The current design is not to remove the old one directly, but deprecate > it. We are still comp

Re: [VOTE] PIP-357: Correct the conf name in load balance module.

2024-06-06 Thread Yunze Xu
+1 (binding) Thanks, Yunze On Wed, Jun 5, 2024 at 6:25 PM thetumbled wrote: > > Hi PengHui, > The current design is not to remove the old one directly, but deprecate it. > We are still comptible with the old cluster in following way: > - If a configuration is not the default configuration, use

Re: [VOTE] PIP-357: Correct the conf name in load balance module.

2024-06-05 Thread thetumbled
Hi PengHui, The current design is not to remove the old one directly, but deprecate it. We are still comptible with the old cluster in following way: - If a configuration is not the default configuration, use that configuration. - If both the new and the old are configured different from the defau

Re: [VOTE] PIP-357: Correct the conf name in load balance module.

2024-06-05 Thread PengHui Li
Hi Wenzhi, Thanks for driving the proposal. The old configuration name should not be removed directly. It might break users when they upgrade to the new cluster. Instead, we can move it to the `Deprecated settings` section and use `-1` as the default value. If the user sets it to a positive numbe

Re: [VOTE] PIP-357: Correct the conf name in load balance module.

2024-06-04 Thread Kai Wang
+1 non-binding Thank you, Kai On 2024/06/05 02:32:51 thetumbled wrote: > Hi, Pulsar Community. > I would like to start the voting thread for PIP-357: Correct the conf name > in load balance module. > Proposal PR: https://github.com/apache/pulsar/pull/22823 > Implementation PR: https://git

[VOTE] PIP-357: Correct the conf name in load balance module.

2024-06-04 Thread thetumbled
Hi, Pulsar Community. I would like to start the voting thread for PIP-357: Correct the conf name in load balance module. Proposal PR: https://github.com/apache/pulsar/pull/22823 Implementation PR: https://github.com/apache/pulsar/pull/22824 Thanks, Wenzhi Feng(thetumbled).