[Result][Vote] PIP-222: Add CommandPartitionedTopicMetadata metrics

2022-11-24 Thread Jiuming Tao
Thanks for vote this PIP, closing the vote 3 bindings: Enrico Olivelli Haiting Jiang Penghui Li 1 non-bindings: Ran Gao Thanks, Tao Jiuming

Re: [VOTE] PIP-222: Add CommandPartitionedTopicMetadata metrics

2022-11-24 Thread Haiting Jiang
+1 binding Thanks, Haiting On Thu, Nov 24, 2022 at 1:05 AM Jiuming Tao wrote: > > > Bump > > > > 2022年11月22日 下午4:03,Ran Gao 写道: > > > > +1 (unbinding) > > > > Thanks, > > Ran > > > > On 2022/11/17 09:06:50 Jiuming Tao wrote: > >> Dear Pulsar Community, > >> > >> Please review and vote on this P

Re: [VOTE] PIP-222: Add CommandPartitionedTopicMetadata metrics

2022-11-23 Thread Jiuming Tao
Bump > 2022年11月22日 下午4:03,Ran Gao 写道: > > +1 (unbinding) > > Thanks, > Ran > > On 2022/11/17 09:06:50 Jiuming Tao wrote: >> Dear Pulsar Community, >> >> Please review and vote on this PIP. >> >> PIP link: https://github.com/apache/pulsar/issues/18319 >>

Re: [VOTE] PIP-222: Add CommandPartitionedTopicMetadata metrics

2022-11-22 Thread Ran Gao
+1 (unbinding) Thanks, Ran On 2022/11/17 09:06:50 Jiuming Tao wrote: > Dear Pulsar Community, > > Please review and vote on this PIP. > > PIP link: https://github.com/apache/pulsar/issues/18319 > > > Discuss thread: > https://lists.apache.org/t

Re: [VOTE] PIP-222: Add CommandPartitionedTopicMetadata metrics

2022-11-17 Thread PengHui Li
+1 Penghui On Fri, Nov 18, 2022 at 12:51 AM Jiuming Tao wrote: > My understanding is that the PIP will add a generic mechanism to track > commands ("pulsar_broker_command_execution_latency" with label > "code”) > > > pulsar_broker_command_execution_latency with `command` label to track the > c

Re: [VOTE] PIP-222: Add CommandPartitionedTopicMetadata metrics

2022-11-17 Thread Jiuming Tao
My understanding is that the PIP will add a generic mechanism to track commands ("pulsar_broker_command_execution_latency" with label "code”) pulsar_broker_command_execution_latency with `command` label to track the command execution latency pulsar_broker_command_execution_failed with `command`

Re: [VOTE] PIP-222: Add CommandPartitionedTopicMetadata metrics

2022-11-17 Thread Enrico Olivelli
+1 (binding) My understanding is that the PIP will add a generic mechanism to track commands ("pulsar_broker_command_execution_latency" with label "code") but we will implement it only for CommandPartitionedTopicMetadata Enrico Il giorno gio 17 nov 2022 alle ore 10:36 Jiuming Tao ha scritto: >

Re: [VOTE] PIP-222: Add CommandPartitionedTopicMetadata metrics

2022-11-17 Thread Jiuming Tao
Hi Enrico, Tracking all the cmds will lead to a lot of changes, BrokerInterceptors only triggered when the cmd entering. This PIP only tracks CommandPartitionedTopicMetadata cmd, but I’ll find a way to track all the cmds, and I’ll create another PIP the do it. Thanks, Tao Jiuming > 2022年11月1

Re: [VOTE] PIP-222: Add CommandPartitionedTopicMetadata metrics

2022-11-17 Thread Enrico Olivelli
Tao, before voting on this proposal, I think that we should change the title. Now the PIP refers to tracking all the commands and not only CommandPartitionedTopicMetadata, is this correct? Enrico Il giorno gio 17 nov 2022 alle ore 10:07 Jiuming Tao ha scritto: > > Dear Pulsar Community, > > Plea

[VOTE] PIP-222: Add CommandPartitionedTopicMetadata metrics

2022-11-17 Thread Jiuming Tao
Dear Pulsar Community, Please review and vote on this PIP. PIP link: https://github.com/apache/pulsar/issues/18319 Discuss thread: https://lists.apache.org/thread/sybl4nno4503w42hzt7b5lsyk6m2rbo6