Re: [PROPOSAL] Website precommit and move the source of docs to the site repo

2022-12-30 Thread tison
is >> > >>>> actually >> > >>>> > updated separately. Thus, from that perspective, maybe it’s not a >> > con. >> > >>>> >> > >>>> Then we can do this refactor thoroughgoing. >> > >>>> >> > >>>>

Re: [PROPOSAL] Website precommit and move the source of docs to the site repo

2022-12-29 Thread tison
es in the main repo. We still > > >>>> have shortcomings: > > >>>> > > >>>> 1. Duplicated CI workflows. > > >>>> 2. Cumbersome preview scaffolding in the main repo. > > >>>> > > >>>> ... w

Re: [PROPOSAL] Website precommit and move the source of docs to the site repo

2022-12-29 Thread Yu
'd like to overcome. > >>>> > >>>> Best, > >>>> tison. > >>>> > >>>> > >>>> Jun Ma 于2022年12月21日周三 11:19写道: > >>>> > >>>>> Is it possible to come up with a comprom

Re: [PROPOSAL] Website precommit and move the source of docs to the site repo

2022-12-29 Thread tison
;>>> >>>>> Is it possible to come up with a compromised solution that has the >>>>> pros of both sides but minimizes the side effect? I'm thinking maybe it's >>>>> not necessary to sacrifice the current contribution process, as long as

Re: [PROPOSAL] Website precommit and move the source of docs to the site repo

2022-12-29 Thread tison
x27;m thinking maybe it's not >>>> necessary to sacrifice the current contribution process, as long as it can >>>> greatly reduce the load of back-end actions and source size. For example, >>>> if we only move out the versioned docs to the site repo but ke

Re: [PROPOSAL] Website precommit and move the source of docs to the site repo

2022-12-29 Thread tison
thinking maybe it's not >>> necessary to sacrifice the current contribution process, as long as it can >>> greatly reduce the load of back-end actions and source size. For example, >>> if we only move out the versioned docs to the site repo but keep the source >>&

Re: [PROPOSAL] Website precommit and move the source of docs to the site repo

2022-12-26 Thread tison
tion of those pros when people can still contribute as usual? >> >> ________ >> From: Jiaqi Shen >> Sent: Tuesday, December 20, 2022 17:15 >> To: dev@pulsar.apache.org >> Subject: Re: [PROPOSAL] Website precommit and move the source o

Re: [PROPOSAL] Website precommit and move the source of docs to the site repo

2022-12-20 Thread tison
__ > From: Jiaqi Shen > Sent: Tuesday, December 20, 2022 17:15 > To: dev@pulsar.apache.org > Subject: Re: [PROPOSAL] Website precommit and move the source of docs to > the site repo > > +1, it makes sense to me. > > Thanks, > Jiaqi Shen > > &

Re: [PROPOSAL] Website precommit and move the source of docs to the site repo

2022-12-20 Thread Jun Ma
0, 2022 17:15 To: dev@pulsar.apache.org Subject: Re: [PROPOSAL] Website precommit and move the source of docs to the site repo +1, it makes sense to me. Thanks, Jiaqi Shen Yu 于2022年12月19日周一 20:57写道: > Hi tison, > > Thanks for raising this up! > > Our community had a similar

Re: [PROPOSAL] Website precommit and move the source of docs to the site repo

2022-12-20 Thread Jiaqi Shen
+1, it makes sense to me. Thanks, Jiaqi Shen Yu 于2022年12月19日周一 20:57写道: > Hi tison, > > Thanks for raising this up! > > Our community had a similar discussion previously and chose to "keep" the > doc repo stay in the Pulsar main repo at that time. > > [1] lists the pros and cons of "keep" and

Re: [PROPOSAL] Website precommit and move the source of docs to the site repo

2022-12-19 Thread Yu
Hi tison, Thanks for raising this up! Our community had a similar discussion previously and chose to "keep" the doc repo stay in the Pulsar main repo at that time. [1] lists the pros and cons of "keep" and "not keep" solutions. I'm +0 on this proposal because I think the total scores of these t

Re: [PROPOSAL] Website precommit and move the source of docs to the site repo

2022-12-19 Thread tison
Thanks for your feedback! @Asaf > pre-commit I mean CI checks before merging a patch. Currently, we don't run checks for the content before merging them. This causes a series of syntax errors and broken links issues. If we hold docs under site2 folder in the main repo and then copied to the site

Re: [PROPOSAL] Website precommit and move the source of docs to the site repo

2022-12-19 Thread PengHui Li
+1 I support moving them to the website repo. Thanks, Penghui On Mon, Dec 19, 2022 at 12:04 PM Yunze Xu wrote: > +1. The most significant point to me is that we can preview all the > content of the website without synchronizing contents from the > apache/pulsar repo. > > Thanks, > Yunze > > On

Re: [PROPOSAL] Website precommit and move the source of docs to the site repo

2022-12-18 Thread Yunze Xu
+1. The most significant point to me is that we can preview all the content of the website without synchronizing contents from the apache/pulsar repo. Thanks, Yunze On Mon, Dec 19, 2022 at 9:53 AM Li Li wrote: > > +1, That’s a good idea. > > > On Dec 16, 2022, at 07:07, tison wrote: > > > > Hi,

Re: [PROPOSAL] Website precommit and move the source of docs to the site repo

2022-12-18 Thread Li Li
+1, That’s a good idea. > On Dec 16, 2022, at 07:07, tison wrote: > > Hi, > > After several works around the build flow of our official website[1][2][3], > the content sync and site build flow is debuggable and reproducible now. > > However, compared to other Apache projects' websites' project

Re: [PROPOSAL] Website precommit and move the source of docs to the site repo

2022-12-18 Thread Li Li
+1, That’s a good idea. Thanks, Li Li > On Dec 16, 2022, at 07:07, tison wrote: > > Hi, > > After several works around the build flow of our official website[1][2][3], > the content sync and site build flow is debuggable and reproducible now. > > However, compared to other Apache projects' we

Re: [PROPOSAL] Website precommit and move the source of docs to the site repo

2022-12-18 Thread Asaf Mesika
> > We don't have a pre-commit workflow for any website-related changes. > Thus, we don't detect broken links or syntax errors when reviewing new > patches[4][5][6]. When you say "pre-commit work-flow,” do you mean what exactly? Usually, a pre-commit is something you run locally upon committing. D

Re: [PROPOSAL] Website precommit and move the source of docs to the site repo

2022-12-15 Thread tison
About the final status, you can take the inlong-website repo as a reference: https://github.com/apache/inlong-website Best, tison. tison 于2022年12月16日周五 07:07写道: > Hi, > > After several works around the build flow of our official > website[1][2][3], the content sync and site build flow is debug

[PROPOSAL] Website precommit and move the source of docs to the site repo

2022-12-15 Thread tison
Hi, After several works around the build flow of our official website[1][2][3], the content sync and site build flow is debuggable and reproducible now. However, compared to other Apache projects' websites' project layouts and workflow, we still meet two challenges on the Pulsar site: 1. We don'