Re: [Discussion] Add a new default method to to the ManagedLedgerInterceptor

2023-03-14 Thread Haiting Jiang
+1, It's a bug fix and the impact of adding this method is minimal. Thanks, Haiting On Tue, Mar 14, 2023 at 7:14 PM Yunze Xu wrote: > > +1. I support cherry-picking it to release branches even if new > default methods are added. It won't affect any existing use because > the interface is customi

Re: [Discussion] Add a new default method to to the ManagedLedgerInterceptor

2023-03-14 Thread Yunze Xu
+1. I support cherry-picking it to release branches even if new default methods are added. It won't affect any existing use because the interface is customized by the 3rd party provider. No compatibility issue will happen. Thanks, Yunze On Tue, Mar 14, 2023 at 4:27 PM Enrico Olivelli wrote: > >

Re: [Discussion] Add a new default method to to the ManagedLedgerInterceptor

2023-03-14 Thread Enrico Olivelli
Il giorno mar 14 mar 2023 alle ore 06:47 Gavin gao ha scritto: > > The issue is: https://github.com/apache/pulsar/pull/19727 > > This issue tries to address the index generator rolled back problem when > entries add failed. > > A new default method `afterFailedAddEntry` is added to interface > Man

[Discussion] Add a new default method to to the ManagedLedgerInterceptor

2023-03-13 Thread Gavin gao
The issue is: https://github.com/apache/pulsar/pull/19727 This issue tries to address the index generator rolled back problem when entries add failed. A new default method `afterFailedAddEntry` is added to interface ManagedLedgerInterceptor. And this change should be also cherry-picked to releas