Re: [Discuss] Disable `Rebase and Merge` on Pulsar Repo

2023-11-05 Thread Heesung Sohn
Hi, Thank you for the quick resonse. Raised a PR here, https://github.com/apache/pulsar/pull/21517. If there is no other opinion, I guess we can disable it. Thanks, Heesung On Sun, Nov 5, 2023 at 8:14 PM tison wrote: > As it's a low traffic requirement, I agree that we can disable it and > e

Re: [Discuss] Disable `Rebase and Merge` on Pulsar Repo

2023-11-05 Thread tison
As it's a low traffic requirement, I agree that we can disable it and enable it temporarily when necessary. Although it introduces a bit chore commits to toggle the button, due to its low frequency, it should be fine. Best, tison. Heesung Sohn 于2023年11月6日周一 12:07写道: > Hi, > > This is the previ

Re: [Discuss] Disable `Rebase and Merge` on Pulsar Repo

2023-11-05 Thread Heesung Sohn
Hi, This is the previous discussion of why we enabled the `rebase and merge` option. https://github.com/apache/pulsar/pull/20325 The example(https://github.com/apache/pulsar/pull/20321) seems to be a legit case for `rebase and merge.` Maybe we should be just careful(especially when using github

Re: [Discuss] Disable `Rebase and Merge` on Pulsar Repo

2023-11-05 Thread Rajan Dhabalia
I remember, It was always disabled since we open sourced Pulsar. Who enabled it and what was the reason for enabling that option? It's definitely not a good option and we should disable it asap. Thanks, Rajan On Sun, Nov 5, 2023 at 7:36 PM Heesung Sohn wrote: > Hi, > > I recently merged my PR w

[Discuss] Disable `Rebase and Merge` on Pulsar Repo

2023-11-05 Thread Heesung Sohn
Hi, I recently merged my PR without squash by mistake. https://github.com/apache/pulsar/pull/21408 To prevent this human error, can we disable `rebase and merge` option, like below? [image: Screen Shot 2023-11-05 at 7.21.34 PM.png] How to disable Rebase and merge: https://docs.github.com/en/re