Re: [DISCUSSION] PIP-118: Do not restart brokers when ZooKeeper session expires

2021-12-21 Thread Matteo Merli
On Mon, Dec 20, 2021 at 2:24 PM Michael Marshall wrote: > I haven't been able to follow the PIP 45 work, so I have some high > level questions. Do we have documentation on the implementation of > these re-acquirable resource locks? I'd like to understand how these > work. There is admittedly not

Re: [DISCUSSION] PIP-118: Do not restart brokers when ZooKeeper session expires

2021-12-20 Thread PengHui Li
Hi Lin Lin Which version you are working on the test? Do you have any steps to reproduce the issue? We'd better fix the problem in 2.10. Regards, Penghui On Tue, Dec 21, 2021 at 11:06 AM Lin Lin wrote: > > > On 2021/12/14 18:03:20 Matteo Merli wrote: > > https://github.com/apache/pulsar/issues

Re: [DISCUSSION] PIP-118: Do not restart brokers when ZooKeeper session expires

2021-12-20 Thread Lin Lin
On 2021/12/14 18:03:20 Matteo Merli wrote: > https://github.com/apache/pulsar/issues/13304 > > > Pasted below for quoting convenience. > > --- > > > ## Motivation > > After all the work done for PIP-45 that was already included in 2.8 and 2.9 > releases, it enabled the concept of re-ac

Re: [DISCUSSION] PIP-118: Do not restart brokers when ZooKeeper session expires

2021-12-20 Thread Michael Marshall
+1 sounds like a great improvement. > With the re-acquirable resource locks, that problem was solved and thoroughly > tested to be robust. I haven't been able to follow the PIP 45 work, so I have some high level questions. Do we have documentation on the implementation of these re-acquirable reso

Re: [DISCUSSION] PIP-118: Do not restart brokers when ZooKeeper session expires

2021-12-16 Thread Enrico Olivelli
+1 Enrico Il Ven 17 Dic 2021, 05:36 Sijie Guo ha scritto: > +1 > > On Tue, Dec 14, 2021 at 10:03 AM Matteo Merli wrote: > > > https://github.com/apache/pulsar/issues/13304 > > > > > > Pasted below for quoting convenience. > > > > --- > > > > > > ## Motivation > > > > After all the work don

Re: [DISCUSSION] PIP-118: Do not restart brokers when ZooKeeper session expires

2021-12-16 Thread Sijie Guo
+1 On Tue, Dec 14, 2021 at 10:03 AM Matteo Merli wrote: > https://github.com/apache/pulsar/issues/13304 > > > Pasted below for quoting convenience. > > --- > > > ## Motivation > > After all the work done for PIP-45 that was already included in 2.8 and 2.9 > releases, it enabled the concept o

Re: [DISCUSSION] PIP-118: Do not restart brokers when ZooKeeper session expires

2021-12-15 Thread Matteo Merli
On Wed, Dec 15, 2021 at 5:47 PM Haiting Jiang wrote: > Small question about new parameter "zookeeperSessionExpiredPolicy", now we > have Etcd implementation for metadata store, is it better to use > "metadataStoreExpiredPolicy" ? Good point, we should also use this occasion to deprecate the `zo

Re: [DISCUSSION] PIP-118: Do not restart brokers when ZooKeeper session expires

2021-12-15 Thread Haiting Jiang
+1 Great PIP. Long expected. Small question about new parameter "zookeeperSessionExpiredPolicy", now we have Etcd implementation for metadata store, is it better to use "metadataStoreExpiredPolicy" ? On 2021/12/14 18:03:20 Matteo Merli wrote: > https://github.com/apache/pulsar/issues/13304 >

Re: [DISCUSSION] PIP-118: Do not restart brokers when ZooKeeper session expires

2021-12-14 Thread Hang Chen
+1 Thanks, Hang PengHui Li 于2021年12月15日周三 07:59写道: > > +1 > > Penghui > > On Wed, Dec 15, 2021 at 2:03 AM Matteo Merli wrote: > > > https://github.com/apache/pulsar/issues/13304 > > > > > > Pasted below for quoting convenience. > > > > --- > > > > > > ## Motivation > > > > After all the wor

Re: [DISCUSSION] PIP-118: Do not restart brokers when ZooKeeper session expires

2021-12-14 Thread PengHui Li
+1 Penghui On Wed, Dec 15, 2021 at 2:03 AM Matteo Merli wrote: > https://github.com/apache/pulsar/issues/13304 > > > Pasted below for quoting convenience. > > --- > > > ## Motivation > > After all the work done for PIP-45 that was already included in 2.8 and 2.9 > releases, it enabled the c

[DISCUSSION] PIP-118: Do not restart brokers when ZooKeeper session expires

2021-12-14 Thread Matteo Merli
https://github.com/apache/pulsar/issues/13304 Pasted below for quoting convenience. --- ## Motivation After all the work done for PIP-45 that was already included in 2.8 and 2.9 releases, it enabled the concept of re-acquirable resource locks and leader election. Another important change