Aloys,
Thank you for your confirmation and updates! I have updated the PIP to
https://github.com/apache/pulsar/wiki/PIP-70%3A-Introduce-lightweight-broker-entry-metadata
I will review your PR closely.
- Sijie
On Thu, Dec 10, 2020 at 1:10 AM Aloys Zhang wrote:
> Sijie,
>
> "Broker Metadata" i
Sijie,
"Broker Metadata" is more precise for understanding.
I have modify the PIP-70 in google docs
https://docs.google.com/document/d/1IgnF9AJzL6JG6G4EL_xcoQxvOpd7bUXcgxFApBiPOFY/edit,
please correct me if anything is inappropriate.
Sijie Guo 于2020年12月10日周四 下午1:45写道：
> Matteo,
>
> Improvin
Matteo,
Improving Protobuf serialization and deserialization can be a separate PIP
because it doesn't solve the problems that this PIP tries to solve.
This PIP probably doesn't state the problem clearly. "Raw Metadata" is
probably an inaccurate name. It should probably be called "Broker Metadata"
The goal of this proposal can be achieved automatically by using a
better ser/de generator that doesn't have overhead for ignored fields.
I'm preparing a revamping of the current Protobuf serialization and
I'll send a proposal soon.
Matteo
--
Matteo Merli
On Sun, Nov 8, 2020 at 10:25 PM Aloys
Yunze,
Thanks for you suggestion. Protobuf does have the ability to check whether
a field is existed. But if we want to use this ability, we should get a
Protobuf object first.
In this proposal, RAW_METADATA_MAGIC_NUMBER is used to indicate what type
object we can get from the bytebuf of Entry. I
I think protobuf has the ability to check if a field is enabled. i.e.
RAW_METADATA_MAGIC_NUMBER and RAW_METADATA_SIZE are included in the protobuf-ed
struct. In Kafka, a magic number represents the version of protocol not if the
feature is enabled. If we need a *real* magic number, we must make
Aloys - Thank you! Will take a look and provide my feedback.
- Sijie
On Tue, Nov 10, 2020 at 2:36 AM Aloys Zhang wrote:
> Sijie,
>
> Sorry for the mistake, already update google doc content.
>
> Sijie Guo 于2020年11月10日周二 下午5:25写道：
>
> > Aloys,
> >
> > It seems that you are attaching the wrong
Sijie,
Sorry for the mistake, already update google doc content.
Sijie Guo 于2020年11月10日周二 下午5:25写道：
> Aloys,
>
> It seems that you are attaching the wrong google doc for this PIP. Isn't
> it?
>
> - Sijie
>
> On Sun, Nov 8, 2020 at 11:25 PM Aloys Zhang wrote:
>
> > Hi all,
> >
> > We have draf
google doc updated
Best Regards.
Jia Zhai
Beijing, China
Mobile: +86 15810491983
On Tue, Nov 10, 2020 at 5:25 PM Sijie Guo wrote:
> Aloys,
>
> It seems that you are attaching the wrong google doc for this PIP. Isn't
> it?
>
> - Sijie
>
> On Sun, Nov 8, 2020 at 11:25 PM Aloys Zhang wrote
Aloys,
It seems that you are attaching the wrong google doc for this PIP. Isn't it?
- Sijie
On Sun, Nov 8, 2020 at 11:25 PM Aloys Zhang wrote:
> Hi all,
>
> We have drafted a proposal for supporting lightweight raw Message metadata
> which can be found at
>
> https://github.com/apache/pulsar/w
👍
Best Regards.
Jia Zhai
Beijing, China
Mobile: +86 15810491983
On Mon, Nov 9, 2020 at 2:24 PM Aloys Zhang wrote:
> Hi all,
>
> We have drafted a proposal for supporting lightweight raw Message metadata
> which can be found at
>
> https://github.com/apache/pulsar/wiki/PIP-70%3A-Introduce
Hi all,
We have drafted a proposal for supporting lightweight raw Message metadata
which can be found at
https://github.com/apache/pulsar/wiki/PIP-70%3A-Introduce-lightweight-raw-Message-metadata
and
https://docs.google.com/document/d/1IgnF9AJzL6JG6G4EL_xcoQxvOpd7bUXcgxFApBiPOFY
Also， I copy it
12 matches
Mail list logo
