Re: [DISCUSS] PIP-383: Support granting/revoking permissions for multiple topics

2024-09-28 Thread Yubiao Feng
Hi Jiwei I think it is very useful Thanks Yubiao Feng On Thu, Sep 26, 2024 at 10:06 PM guo jiwei wrote: > Hello, > > I have created a PIP for supporting granting/revoking permissions for > multiple topics. > > In AuthorizationProvider, the authorization interface > `grantPermissionAsync(TopicN

Re: [DISCUSS] PIP-383: Support granting/revoking permissions for multiple topics

2024-09-28 Thread guo jiwei
Hi Lari, We have added the default implementation, so we can go into other branches if needed. Regards Jiwei Guo (Tboy) On Fri, Sep 27, 2024 at 5:33 PM Lari Hotari wrote: > I think it's necessary to mention the target versions in the proposal. > > I'd say that this proposal shouldn't go int

Re: [DISCUSS] PIP-383: Support granting/revoking permissions for multiple topics

2024-09-27 Thread Lari Hotari
I think it's necessary to mention the target versions in the proposal. I'd say that this proposal shouldn't go into branch-3.0 since it breaks existing implementations of the AuthorizationProvider interface. This could be avoided by providing a compatible default implementation of the interface me

Re: [DISCUSS] PIP-383: Support granting/revoking permissions for multiple topics

2024-09-27 Thread Baodi Shi
+1 @lari For this type of improved API, which is clearer and more decoupled, can we include it in version 3.3? Thanks, Baodi Shi Lari Hotari 于2024年9月27日周五 00:42写道: > > Thanks for driving this Jiwei. > This will be useful in addressing the current challenge with concurrent > modifications. > Is

Re: [DISCUSS] PIP-383: Support granting/revoking permissions for multiple topics

2024-09-26 Thread Lari Hotari
Thanks for driving this Jiwei. This will be useful in addressing the current challenge with concurrent modifications. Is this targeted for Pulsar 4.0? -Lari On 2024/09/26 14:04:35 guo jiwei wrote: > Hello, > > I have created a PIP for supporting granting/revoking permissions for > multiple topi

[DISCUSS] PIP-383: Support granting/revoking permissions for multiple topics

2024-09-26 Thread guo jiwei
Hello, I have created a PIP for supporting granting/revoking permissions for multiple topics. In AuthorizationProvider, the authorization interface `grantPermissionAsync(TopicName topicName, Set actions, String role, String authDataJson)` currently only supports granting permissions to a single t