Re: [DISCUSS] PIP-349: Add systemCursorNames ignore list for TTL check

2024-05-06 Thread Hang Chen
Hi guys, If there are no objections, I will send out the vote. Best, Hang Hang Chen 于2024年5月7日周二 11:17写道: > > >It seems that we only need to keep `additionalSystemCursorNames`. > > Yes, we just use the `additionalSystemCursorNames` > > Best, > Hang > > Zixuan Liu 于2024年5月6日周一 23:52写道: > >

Re: [DISCUSS] PIP-349: Add systemCursorNames ignore list for TTL check

2024-05-06 Thread Hang Chen
>It seems that we only need to keep `additionalSystemCursorNames`. Yes, we just use the `additionalSystemCursorNames` Best, Hang Zixuan Liu 于2024年5月6日周一 23:52写道: > > It seems that we only need to keep `additionalSystemCursorNames`. > > `systemCursorNames` is unnecessary, which should be built-i

Re: [DISCUSS] PIP-349: Add systemCursorNames ignore list for TTL check

2024-05-06 Thread Zixuan Liu
It seems that we only need to keep `additionalSystemCursorNames`. `systemCursorNames` is unnecessary, which should be built-in and immutable. Thanks, Zixuan Hang Chen 于2024年5月6日周一 22:22写道: > >We can make this "configurable", but the well known names should be always > handled automatically > >

Re: [DISCUSS] PIP-349: Add systemCursorNames ignore list for TTL check

2024-05-06 Thread Hang Chen
>We can make this "configurable", but the well known names should be always handled automatically I changed the configuration name to `additionalSystemCursorNames`. I think the user should be defined as a Pulsar administrator. For cursors that need to be ignored by TTL should be owned by Pulsar in

Re: [DISCUSS] PIP-349: Add systemCursorNames ignore list for TTL check

2024-05-06 Thread Enrico Olivelli
Il giorno lun 6 mag 2024 alle ore 09:07 PengHui Li ha scritto: > For the backlog quota check, I think we also need the same capacity. > > For configurable. I think the reason is users can have their plugins > running > with the broker which relies on the Pulsar topic. They don't want the > applic

Re: [DISCUSS] PIP-349: Add systemCursorNames ignore list for TTL check

2024-05-06 Thread PengHui Li
For the backlog quota check, I think we also need the same capacity. For configurable. I think the reason is users can have their plugins running with the broker which relies on the Pulsar topic. They don't want the application to change the TTL or backlog policies for some subscription/cursor. Bu

Re: [DISCUSS] PIP-349: Add systemCursorNames ignore list for TTL check

2024-05-05 Thread Enrico Olivelli
Overall I support this idea, but the name 'systemCursorsNames' is not good and we should not make it configurable. First, we have to make a call to the TTL thing, otherwise we will end up in using that for other stuff, and not only TTL. Second, we shouldn't make this configurable. Those cursors d

Re: [DISCUSS] PIP-349: Add systemCursorNames ignore list for TTL check

2024-05-05 Thread PengHui Li
LGTM, Regards, Penghui On Mon, May 6, 2024 at 2:02 PM Lari Hotari wrote: > LGTM, very useful. Thanks for driving this. > > -Lari > > On 2024/05/04 16:01:41 Hang Chen wrote: > > Hi guys, > > I proposed a new proposal to improve the TTL impact on system > > cursors. Please help take a look, t

Re: [DISCUSS] PIP-349: Add systemCursorNames ignore list for TTL check

2024-05-05 Thread Lari Hotari
LGTM, very useful. Thanks for driving this. -Lari On 2024/05/04 16:01:41 Hang Chen wrote: > Hi guys, > I proposed a new proposal to improve the TTL impact on system > cursors. Please help take a look, thanks. > > PIP: https://github.com/apache/pulsar/pull/22651 > > Thanks, > Hang >

Re: [DISCUSS] PIP-349: Add systemCursorNames ignore list for TTL check

2024-05-05 Thread Yubiao Feng
Hi Hang Agree with you. Thanks Yubiao Feng On Sun, May 5, 2024 at 12:01 AM Hang Chen wrote: > Hi guys, > I proposed a new proposal to improve the TTL impact on system > cursors. Please help take a look, thanks. > > PIP: https://github.com/apache/pulsar/pull/22651 > > Thanks, > Hang >

Re: [DISCUSS] PIP-349: Add systemCursorNames ignore list for TTL check

2024-05-04 Thread 太上玄元道君
looks good Hang Chen 于2024年5月5日 周日00:02写道: > Hi guys, > I proposed a new proposal to improve the TTL impact on system > cursors. Please help take a look, thanks. > > PIP: https://github.com/apache/pulsar/pull/22651 > > Thanks, > Hang >

[DISCUSS] PIP-349: Add systemCursorNames ignore list for TTL check

2024-05-04 Thread Hang Chen
Hi guys, I proposed a new proposal to improve the TTL impact on system cursors. Please help take a look, thanks. PIP: https://github.com/apache/pulsar/pull/22651 Thanks, Hang