Hi guys,
If there are no objections, I will send out the vote.
Best,
Hang
Hang Chen <chenh...@apache.org> 于2024年5月7日周二 11:17写道：
>
> >It seems that we only need to keep `additionalSystemCursorNames`.
>
> Yes, we just use the `additionalSystemCursorNames`
>
> Best,
> Hang
>
> Zixuan Liu <node...@gmail.com> 于2024年5月6日周一 23:52写道：
> >
> > It seems that we only need to keep `additionalSystemCursorNames`.
> >
> > `systemCursorNames` is unnecessary, which should be built-in and immutable.
> >
> > Thanks,
> > Zixuan
> >
> > Hang Chen <chenh...@apache.org> 于2024年5月6日周一 22:22写道：
> >
> > > >We can make this "configurable", but the well known names should be
> > > >always
> > > handled automatically
> > >
> > > I changed the configuration name to `additionalSystemCursorNames`. I
> > > think the user should be defined as a Pulsar administrator. For
> > > cursors that need to be ignored by TTL should be owned by Pulsar
> > > internal service or Pulsar plugins owned by Pulsar administrators. For
> > > application users, they should not touch this part.
> > >
> > > Thanks,
> > > Hang
> > >
> > > Enrico Olivelli <eolive...@gmail.com> 于2024年5月6日周一 15:17写道：
> > > >
> > > > Il giorno lun 6 mag 2024 alle ore 09:07 PengHui Li <peng...@apache.org>
> > > ha
> > > > scritto:
> > > >
> > > > > For the backlog quota check, I think we also need the same capacity.
> > > > >
> > > > > For configurable. I think the reason is users can have their plugins
> > > > > running
> > > > > with the broker which relies on the Pulsar topic. They don't want the
> > > > > application to
> > > > > change the TTL or backlog policies for some subscription/cursor. But
> > > now,
> > > > > if user set
> > > > > the TTL or backlog policy for a namespace, all the subscriptions will
> > > be
> > > > > affected.
> > > > >
> > > >
> > > > I see.
> > > > We can make this "configurable", but the well known names should be
> > > always
> > > > handled automatically
> > > >
> > > > Enrico
> > > >
> > > >
> > > > >
> > > > > Penghui
> > > > >
> > > > >
> > > > >
> > > > > On Mon, May 6, 2024 at 2:51 PM Enrico Olivelli <eolive...@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > Overall I support this idea, but the name 'systemCursorsNames' is
> > > > > > not
> > > > > good
> > > > > > and we should not make it configurable.
> > > > > >
> > > > > > First, we have to make a call to the TTL thing, otherwise we will
> > > end up
> > > > > in
> > > > > > using that for other stuff, and not only TTL.
> > > > > >
> > > > > > Second, we shouldn't make this configurable. Those cursors depend on
> > > the
> > > > > > version of Pulsar and users who upgrade from previous versions won't
> > > > > update
> > > > > > the configuration and this will lead to problems. And we cannot ask
> > > users
> > > > > > to update the configuration when updating
> > > > > >
> > > > > > Enrico
> > > > > >
> > > > > > Il Lun 6 Mag 2024, 08:02 Lari Hotari <lhot...@apache.org> ha
> > > scritto:
> > > > > >
> > > > > > > LGTM, very useful. Thanks for driving this.
> > > > > > >
> > > > > > > -Lari
> > > > > > >
> > > > > > > On 2024/05/04 16:01:41 Hang Chen wrote:
> > > > > > > > Hi guys,
> > > > > > > > I proposed a new proposal to improve the TTL impact on
> > > > > > > > system
> > > > > > > > cursors. Please help take a look, thanks.
> > > > > > > >
> > > > > > > > PIP: https://github.com/apache/pulsar/pull/22651
> > > > > > > >
> > > > > > > > Thanks,
> > > > > > > > Hang
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > >
