Re: [DISCUSS] PIP-237: Make PulsarAdmin accessible in SinkContext and SourceContext

2023-02-07 Thread Michael Marshall
This proposal makes sense to me. I am +1 on option B. Thanks, Michael On Wed, Feb 1, 2023 at 2:42 AM Alexander Preuss wrote: > > Thanks to everyone for providing their input. Please vote on the VOTE > thread https://lists.apache.org/thread/ykfnfb1pv4bcxwr6lwb4klc3byq71t13 > > Many thanks, > Alex

Re: [DISCUSS] PIP-237: Make PulsarAdmin accessible in SinkContext and SourceContext

2023-02-01 Thread Alexander Preuss
Thanks to everyone for providing their input. Please vote on the VOTE thread https://lists.apache.org/thread/ykfnfb1pv4bcxwr6lwb4klc3byq71t13 Many thanks, Alexander On Thu, Jan 19, 2023 at 5:01 AM r...@apache.org wrote: > Hello Alexander, thanks your work for this. > It seems that all agrees wi

Re: [DISCUSS] PIP-237: Make PulsarAdmin accessible in SinkContext and SourceContext

2023-01-18 Thread r...@apache.org
Hello Alexander, thanks your work for this. It seems that all agrees with this PIP, maybe we can enter the VOTE thread to initiate a VOTE process for this PIP. -- Thanks Xiaolong Ran r...@apache.org 于2023年1月19日周四 11:57写道: > +1 > > We can imitate the PulsarClient object, and in the BaseContext i

Re: [DISCUSS] PIP-237: Make PulsarAdmin accessible in SinkContext and SourceContext

2023-01-18 Thread r...@apache.org
+1 We can imitate the PulsarClient object, and in the BaseContext interface, add PulsarAdmin and PulsarAdminBuilder as interfaces at the same time. -- Thanks Xiaolong Ran Neng Lu 于2023年1月19日周四 02:28写道: > The proposal makes sense to me. > > The only note I want to add is to make sure the Pulsar

Re: [DISCUSS] PIP-237: Make PulsarAdmin accessible in SinkContext and SourceContext

2023-01-18 Thread Neng Lu
The proposal makes sense to me. The only note I want to add is to make sure the PulsarAdmin access in Source and Sink is also controlled by the flag `exposePulsarAdminClientEnabled`. Similar to the following: https://github.com/apache/pulsar/blob/master/pulsar-functions/runtime/src/main/java/or

Re: [DISCUSS] PIP-237: Make PulsarAdmin accessible in SinkContext and SourceContext

2023-01-18 Thread Alexander Preuss
Enrico, >I suggest to put option B into the API changes and move option A to"Alternatives" Thanks for your input, I updated the GitHub issue accordingly. Best, Alexander On Tue, Jan 17, 2023 at 3:17 AM Bonan Hou wrote: > +1 for option b. > > Bonan Hou > > On Tue, Jan 3, 2023 at 10:32 PM Alexan

Re: [DISCUSS] PIP-237: Make PulsarAdmin accessible in SinkContext and SourceContext

2023-01-16 Thread Bonan Hou
+1 for option b. Bonan Hou On Tue, Jan 3, 2023 at 10:32 PM Alexander Preuss wrote: > Hi all, > > I opened a PIP to discuss making PulsarAdmin accessible in Pulsar IO > connectors through SinkContext and SourceContext: > https://github.com/apache/pulsar/issues/19123 > > Looking forward to hearin

Re: [DISCUSS] PIP-237: Make PulsarAdmin accessible in SinkContext and SourceContext

2023-01-16 Thread Enrico Olivelli
The proposal makes sense to me. I suggest to put option B into the API changes and move option A to "Alternatives" Enrico Il giorno mar 3 gen 2023 alle ore 15:32 Alexander Preuss ha scritto: > > Hi all, > > I opened a PIP to discuss making PulsarAdmin accessible in Pulsar IO > connectors throug

[DISCUSS] PIP-237: Make PulsarAdmin accessible in SinkContext and SourceContext

2023-01-03 Thread Alexander Preuss
Hi all, I opened a PIP to discuss making PulsarAdmin accessible in Pulsar IO connectors through SinkContext and SourceContext: https://github.com/apache/pulsar/issues/19123 Looking forward to hearing your thoughts, Alex