Re: [DISCUSS] PIP-223: Add metrics for all Rest Endpoints

2022-12-09 Thread Jiuming Tao
;>> 2022年11月23日 上午9:37，PengHui Li 写道： > > > > > >>> > > > > > >>> Hi, Jiuming > > > > > >>> > > > > > >>> Thanks for starting the proposal. > > > > > >>> > > > > >

Re: [DISCUSS] PIP-223: Add metrics for all Rest Endpoints

2022-12-09 Thread Jiuming Tao
;>> 2022年11月23日 上午9:37，PengHui Li 写道： > > > > > >>> > > > > > >>> Hi, Jiuming > > > > > >>> > > > > > >>> Thanks for starting the proposal. > > > > > >>> > > > > >

Re: [DISCUSS] PIP-223: Add metrics for all Rest Endpoints

2022-12-08 Thread Michael Marshall
gt; > >>> I noticed the existing jetty metrics are based on > > > > >>> `org.eclipse.jetty.server.handler.StatisticsHandler`. > > > > >>> Can we just have a new StatisticsHandler? e.g. > > > EndpointStatisticsHandler. > > > > >&g

Re: [DISCUSS] PIP-223: Add metrics for all Rest Endpoints

2022-11-24 Thread Haiting Jiang
? e.g. > > EndpointStatisticsHandler. > > > >>> So that we can > > > >>> get the request path from the handle method > > > >>> `public void handle(String path, Request baseRequest, > > HttpServletRequest > > > >>> request, Htt

Re: [DISCUSS] PIP-223: Add metrics for all Rest Endpoints

2022-11-24 Thread Jiuming Tao
t; >>> > > >>> Thanks, > > >>> Penghui > > >>> > > >>> On Tue, Nov 22, 2022 at 5:20 PM Jiuming Tao > > > >>> wrote: > > >>> > > >>>> Hi Haiting, > > >>>> > > >>>> I'm sorry I didn't explain FAILED, the FAILED means the HTTP > response code > > >>>>> = 400, and I’ll update the PIP later. > > >>>> > > >>>> Thanks, > > >>>> Tao Jiuming > > >>>> > > >>>>> 2022年11月22日 下午5:15，Haiting Jiang 写道： > > >>>>> > > >>>>> Hi Jiuming, > > >>>>> > > >>>>> Overall, this PIP makes sense to me. > > >>>>> About the metric "pulsar_broker_rest_endpoint_failed", please > provide > > >>>>> a more clear definition of "fail". Are redirects like 403 included? > > >>>>> > > >>>>> Thanks, > > >>>>> Haiting > > >>>>> > > >>>>> On Tue, Nov 22, 2022 at 3:17 AM Jiuming Tao > > >>>>> wrote: > > >>>>>> > > >>>>>> Hi pulsar community, > > >>>>>> > > >>>>>> I’ve opened a PIP to discuss: PIP-223: Add metrics for all Rest > > >>>> Endpoints > > >>>>>> > > >>>>>> The PIP link: https://github.com/apache/pulsar/issues/18560 < > > >>>> https://github.com/apache/pulsar/issues/18560> > > >>>>>> > > >>>>>> Thanks, > > >>>>>> Tao Jiuming > > >>>> > > >>>> > > >> > > >

Re: [DISCUSS] PIP-223: Add metrics for all Rest Endpoints

2022-11-24 Thread Haiting Jiang
;> Penghui > >>> > >>> On Tue, Nov 22, 2022 at 5:20 PM Jiuming Tao > >>> > >>> wrote: > >>> > >>>> Hi Haiting, > >>>> > >>>> I'm sorry I didn't explain FAILED, the FAILED means the HT

Re: [DISCUSS] PIP-223: Add metrics for all Rest Endpoints

2022-11-23 Thread Jiuming Tao
ans the HTTP response code >>>>> = 400, and I’ll update the PIP later. >>>> >>>> Thanks, >>>> Tao Jiuming >>>> >>>>> 2022年11月22日 下午5:15，Haiting Jiang 写道： >>>>> >>>>> Hi Jiuming, >>>>&

Re: [DISCUSS] PIP-223: Add metrics for all Rest Endpoints

2022-11-22 Thread Haiting Jiang
iang 写道： > >>> > >>> Hi Jiuming, > >>> > >>> Overall, this PIP makes sense to me. > >>> About the metric "pulsar_broker_rest_endpoint_failed", please provide > >>> a more clear definition of "fail". Are redirects like 403 included? > >>> > >>> Thanks, > >>> Haiting > >>> > >>> On Tue, Nov 22, 2022 at 3:17 AM Jiuming Tao > >>> wrote: > >>>> > >>>> Hi pulsar community, > >>>> > >>>> I’ve opened a PIP to discuss: PIP-223: Add metrics for all Rest > >> Endpoints > >>>> > >>>> The PIP link: https://github.com/apache/pulsar/issues/18560 < > >> https://github.com/apache/pulsar/issues/18560> > >>>> > >>>> Thanks, > >>>> Tao Jiuming > >> > >> >

Re: [DISCUSS] PIP-223: Add metrics for all Rest Endpoints

2022-11-22 Thread Jiuming Tao
iuming, >>> >>> Overall, this PIP makes sense to me. >>> About the metric "pulsar_broker_rest_endpoint_failed", please provide >>> a more clear definition of "fail". Are redirects like 403 included? >>> >>> Thanks, >>

Re: [DISCUSS] PIP-223: Add metrics for all Rest Endpoints

2022-11-22 Thread PengHui Li
> > > Overall, this PIP makes sense to me. > > About the metric "pulsar_broker_rest_endpoint_failed", please provide > > a more clear definition of "fail". Are redirects like 403 included? > > > > Thanks, > > Haiting > > > > On Tue, Nov 22, 2022 at 3:

Re: [DISCUSS] PIP-223: Add metrics for all Rest Endpoints

2022-11-22 Thread Jiuming Tao
se to me. > About the metric "pulsar_broker_rest_endpoint_failed", please provide > a more clear definition of "fail". Are redirects like 403 included? > > Thanks, > Haiting > > On Tue, Nov 22, 2022 at 3:17 AM Jiuming Tao > wrote: >> >> Hi pulsar community, >> &

Re: [DISCUSS] PIP-223: Add metrics for all Rest Endpoints

2022-11-22 Thread Haiting Jiang
community, > > I’ve opened a PIP to discuss: PIP-223: Add metrics for all Rest Endpoints > > The PIP link: https://github.com/apache/pulsar/issues/18560 > <https://github.com/apache/pulsar/issues/18560> > > Thanks, > Tao Jiuming

[DISCUSS] PIP-223: Add metrics for all Rest Endpoints

2022-11-21 Thread Jiuming Tao
Hi pulsar community, I’ve opened a PIP to discuss: PIP-223: Add metrics for all Rest Endpoints The PIP link: https://github.com/apache/pulsar/issues/18560 <https://github.com/apache/pulsar/issues/18560> Thanks, Tao Jiuming