Re: [DISCUSS] Enable message deduplication for replicator by default

2022-09-05 Thread Dave Fisher
Excellent point Rajan! We had a significant decrease in performance with consumption in 2.8.3 which was not fixed until 2.10.1. Let’s take care to solve problems without surprising users and impacting performance. Best, Dave Sent from my iPhone > On Sep 5, 2022, at 5:11 PM, Rajan Dhabalia w

Re: [DISCUSS] Enable message deduplication for replicator by default

2022-09-05 Thread Rajan Dhabalia
Message deduplication always comes with memory and CPU cost and making it default means charging this penalty to every user without having this requirement. Enabling by default means you are impacting every user who is not aware about this feature after upgrading the release. This is purely requir

Re: [DISCUSS] Enable message deduplication for replicator by default

2022-09-05 Thread lordcheng10
+1 Haiting Jiang 于2022年8月26日周五 09:52写道: > +1 > > Thanks, > Haiting > > On Thu, Aug 25, 2022 at 9:52 AM Baodi Shi > wrote: > > > +1 > > > > Thanks, > > Baodi Shi > > > > > On Aug 24, 2022, at 20:1312, Qiang Huang > > wrote: > > > > > > +1 > > > > > > Zike Yang 于2022年8月22日周一 15:32写道: > > > > >

Re: [DISCUSS] Enable message deduplication for replicator by default

2022-08-25 Thread Haiting Jiang
+1 Thanks, Haiting On Thu, Aug 25, 2022 at 9:52 AM Baodi Shi wrote: > +1 > > Thanks, > Baodi Shi > > > On Aug 24, 2022, at 20:1312, Qiang Huang > wrote: > > > > +1 > > > > Zike Yang 于2022年8月22日周一 15:32写道: > > > >> +1 > >> > >> Thanks, > >> Zike Yang > >> > >> On Mon, Aug 22, 2022 at 3:16 PM m

Re: [DISCUSS] Enable message deduplication for replicator by default

2022-08-24 Thread Baodi Shi
+1 Thanks, Baodi Shi > On Aug 24, 2022, at 20:1312, Qiang Huang wrote: > > +1 > > Zike Yang 于2022年8月22日周一 15:32写道: > >> +1 >> >> Thanks, >> Zike Yang >> >> On Mon, Aug 22, 2022 at 3:16 PM mattison chao >> wrote: >>> >>> +1 >>> >>> Best, >>> Mattison >>> >>> On Fri, 19 Aug 2022 at 01:40

Re: [DISCUSS] Enable message deduplication for replicator by default

2022-08-24 Thread Qiang Huang
+1 Zike Yang 于2022年8月22日周一 15:32写道: > +1 > > Thanks, > Zike Yang > > On Mon, Aug 22, 2022 at 3:16 PM mattison chao > wrote: > > > > +1 > > > > Best, > > Mattison > > > > On Fri, 19 Aug 2022 at 01:40, Enrico Olivelli > wrote: > > > > > I agree > > > > > > Enrico > > > > > > Il Gio 18 Ago 2022,

Re: [DISCUSS] Enable message deduplication for replicator by default

2022-08-22 Thread Zike Yang
+1 Thanks, Zike Yang On Mon, Aug 22, 2022 at 3:16 PM mattison chao wrote: > > +1 > > Best, > Mattison > > On Fri, 19 Aug 2022 at 01:40, Enrico Olivelli wrote: > > > I agree > > > > Enrico > > > > Il Gio 18 Ago 2022, 18:23 PengHui Li ha scritto: > > > > > Hi all, > > > > > > When I tried to fix

Re: [DISCUSS] Enable message deduplication for replicator by default

2022-08-22 Thread mattison chao
+1 Best, Mattison On Fri, 19 Aug 2022 at 01:40, Enrico Olivelli wrote: > I agree > > Enrico > > Il Gio 18 Ago 2022, 18:23 PengHui Li ha scritto: > > > Hi all, > > > > When I tried to fix a problem related to replicator > > https://github.com/apache/pulsar/pull/17154 > > It surprised me that th

Re: [DISCUSS] Enable message deduplication for replicator by default

2022-08-18 Thread Enrico Olivelli
I agree Enrico Il Gio 18 Ago 2022, 18:23 PengHui Li ha scritto: > Hi all, > > When I tried to fix a problem related to replicator > https://github.com/apache/pulsar/pull/17154 > It surprised me that the message deduplication will not work by default > with the replicator. > I always thought it

[DISCUSS] Enable message deduplication for replicator by default

2022-08-18 Thread PengHui Li
Hi all, When I tried to fix a problem related to replicator https://github.com/apache/pulsar/pull/17154 It surprised me that the message deduplication will not work by default with the replicator. I always thought it was enabled for replicators by default. Details to see [0]. I think we should en