Re: [DISCUSS] Enable "Always suggest updating pull request branches" for pulsar-site

2023-06-19 Thread Zili Chen
FYI - the proposal is applied https://issues.apache.org/jira/browse/INFRA-24636. On 2023/06/02 02:25:55 Dave Fisher wrote: > I think that INFRA would accept a DISCUSSION that looks for LAZY CONSENSUS. > > Sent from my iPhone > > > On Jun 1, 2023, at 7:18 PM, tison wrote: > > > > While we can

Re: [DISCUSS] Enable "Always suggest updating pull request branches" for pulsar-site

2023-06-01 Thread tison
OK. Let me share the updates to INFRA members then. BTW, I saw this direct commit that may be better to go through a PR for better visibility :D - https://github.com/apache/pulsar-site/commit/04d5b02c48a7a49f9159d8c6f5c82e2537ae2caa Best, tison. Dave Fisher 于2023年6月2日周五 10:26写道: > I think th

Re: [DISCUSS] Enable "Always suggest updating pull request branches" for pulsar-site

2023-06-01 Thread Dave Fisher
I think that INFRA would accept a DISCUSSION that looks for LAZY CONSENSUS. Sent from my iPhone > On Jun 1, 2023, at 7:18 PM, tison wrote: > > While we can vote for these two simultaneously to ask for INFRA members to > enable them at once. I agree that it can help since PRs is more open than

Re: [DISCUSS] Enable "Always suggest updating pull request branches" for pulsar-site

2023-06-01 Thread tison
While we can vote for these two simultaneously to ask for INFRA members to enable them at once. I agree that it can help since PRs is more open than commit only changes - I experience that even in a review after merge pattern a PR is more easily to get comments and response while commits are always

Re: [DISCUSS] Enable "Always suggest updating pull request branches" for pulsar-site

2023-06-01 Thread tison
> I committed a change directly to the main branch when I was expecting to be forced to create a PR. This seems a different topic. What we're talking about is "Always suggest updating pull request branches ", ... while you're referring to "Require a pull request before merging". Best, tison.

Re: [DISCUSS] Enable "Always suggest updating pull request branches" for pulsar-site

2023-06-01 Thread Dave Fisher
I committed a change directly to the main branch when I was expecting to be forced to create a PR. There are times when a quick commit can make life easier, but PRs make it easier to follow changes. Best, Dave Sent from my iPhone > On Jun 1, 2023, at 6:12 PM, tison wrote: > > Hi, > > Here

[DISCUSS] Enable "Always suggest updating pull request branches" for pulsar-site

2023-06-01 Thread tison
Hi, Here is some background - [1][2]. Briefly, @dave2wave and I agree on Enable "Always suggest updating pull request branches" for pulsar-site GitHub repo. We did the same for the main repo while reverting later. Now INFRA team members want to see an explicit consensus among the community to do