While we can vote for these two simultaneously to ask for INFRA members to
enable them at once. I agree that it can help since PRs is more open than
commit only changes - I experience that even in a review after merge
pattern a PR is more easily to get comments and response while commits are
always overwhelmed.

Best,
tison.


tison <wander4...@gmail.com> 于2023年6月2日周五 10:15写道:

> > I committed a change directly to the main branch when I was expecting
> to be forced to create a PR.
>
> This seems a different topic.
>
> What we're talking about is "Always suggest updating pull request branches
>  ",
>
> ... while you're referring to "Require a pull request before merging".
>
> Best,
> tison.
>
>
> Dave Fisher <wave4d...@comcast.net> 于2023年6月2日周五 10:10写道:
>
>> I committed a change directly to the main branch when I was expecting to
>> be forced to create a PR.
>>
>> There are times when a quick commit can make life easier, but PRs make it
>> easier to follow changes.
>>
>> Best,
>> Dave
>>
>> Sent from my iPhone
>>
>> > On Jun 1, 2023, at 6:12 PM, tison <wander4...@gmail.com> wrote:
>> >
>> > Hi,
>> >
>> > Here is some background - [1][2].
>> >
>> > Briefly, @dave2wave and I agree on Enable "Always suggest updating pull
>> > request branches" for pulsar-site GitHub repo. We did the same for the
>> main
>> > repo while reverting later. Now INFRA team members want to see an
>> explicit
>> > consensus among the community to do so for the site repo.
>> >
>> > Thus, I come here to ask you to share your thoughts sincerely.
>> >
>> > Thank you!
>> >
>> > Best,
>> > tison.
>> >
>> > [1]
>> https://github.com/apache/pulsar-site/pull/543#issuecomment-1562151294
>> > [2] https://issues.apache.org/jira/browse/INFRA-24636
>>
>>

Reply via email to