Re: [DISCUSS] Cherry-pick topic load failed count metrics to release branches

2024-05-14 Thread Zixuan Liu
The master metric name differs because we didn't add a metric with the pulsar prefix. https://github.com/apache/pulsar/pull/20720 fixes that. Another thing is that this cherry-pick broke the branch-2.10 CI: https://github.com/apache/pulsar/pull/13785 upgrades prometheus-client on the branch-2.11

Re: [DISCUSS] Cherry-pick topic load failed count metrics to release branches

2024-05-02 Thread Yubiao Feng
Hi all Both #19236 and #22580 have been cherry-picked. But the metric name in the `branch-3.0`, `branch-2.11`, and `branch-2.10` is `topic_load_failed_total`, it is named `pulsar_topic_load_failed_count` on the branch `master`. Thanks Yubiao Feng On Mon, Apr 22, 2024 at 5:40 PM PengHui Li wrote

Re: [DISCUSS] Cherry-pick topic load failed count metrics to release branches

2024-04-29 Thread Yubiao Feng
Hi all The fix https://github.com/apache/pulsar/pull/22580 has been merged, I will cherry-pick #19236 and #22580 in to other branches Thanks Yubiao Feng On Mon, Apr 22, 2024 at 5:40 PM PengHui Li wrote: > Hi, all > > I would like to start a discussion to cherry-pick > https://github.com/apache

Re: [DISCUSS] Cherry-pick topic load failed count metrics to release branches

2024-04-24 Thread Yubiao Feng
@PengHui The test `BrokerServiceTest.testBrokerStatsTopicLoadFailed` that was introduced by https://github.com/apache/pulsar/pull/19236 always fails, and https://github.com/apache/pulsar/pull/20494 disabled it. We need to fix it before cherry-picking it into other branches. Please review the PR h

Re: [DISCUSS] Cherry-pick topic load failed count metrics to release branches

2024-04-24 Thread Haiting Jiang
+1, It's great for LTS versions. Thanks Haiting On Tue, Apr 23, 2024 at 9:07 PM Yubiao Feng wrote: > > Hi Penghui > > Agree with you > > Thanks > Yubiao Feng > > On Mon, Apr 22, 2024 at 5:40 PM PengHui Li wrote: > > > Hi, all > > > > I would like to start a discussion to cherry-pick > > https:/

Re: [DISCUSS] Cherry-pick topic load failed count metrics to release branches

2024-04-23 Thread Yubiao Feng
Hi Penghui Agree with you Thanks Yubiao Feng On Mon, Apr 22, 2024 at 5:40 PM PengHui Li wrote: > Hi, all > > I would like to start a discussion to cherry-pick > https://github.com/apache/pulsar/pull/19236 > to the release branches > > - branch-3.0 > - branch-2.11 > - branch-2.10 > > The topic

[DISCUSS] Cherry-pick topic load failed count metrics to release branches

2024-04-22 Thread PengHui Li
Hi, all I would like to start a discussion to cherry-pick https://github.com/apache/pulsar/pull/19236 to the release branches - branch-3.0 - branch-2.11 - branch-2.10 The topic load is a critical operation in Pulsar. If the topic not able to be loaded, the producer or consumer will not able to c