The master metric name differs because we didn't add a metric with the pulsar prefix.
https://github.com/apache/pulsar/pull/20720 fixes that. Another thing is that this cherry-pick broke the branch-2.10 CI: https://github.com/apache/pulsar/pull/13785 upgrades prometheus-client on the branch-2.11, which means we must take care of the metric name. Thanks, Zixuan Yubiao Feng <yubiao.f...@streamnative.io.invalid> 于2024年5月2日周四 23:44写道： > Hi all > > Both #19236 and #22580 have been cherry-picked. But the metric name in the > `branch-3.0`, `branch-2.11`, and `branch-2.10` is > `topic_load_failed_total`, it is named `pulsar_topic_load_failed_count` on > the branch `master`. > > Thanks > Yubiao Feng > > On Mon, Apr 22, 2024 at 5:40 PM PengHui Li <peng...@apache.org> wrote: > > > Hi, all > > > > I would like to start a discussion to cherry-pick > > https://github.com/apache/pulsar/pull/19236 > > to the release branches > > > > - branch-3.0 > > - branch-2.11 > > - branch-2.10 > > > > The topic load is a critical operation in Pulsar. If the topic > > not able to be loaded, the producer or consumer will not > > able to connect to the topic. > > > > Publishing and consumption are the staple features of Pulsar. > > So I think it should be worth having #19236 in all the release > > branches to allow users to monitor the topic load failures > > > > And the change is low risky with only a few line changes. > > > > The thread will keep open for 48 hours. If there is no objections, > > I will perform the cherry-picking. > > > > Regards, > > Penghui > > >
