Re: [DISCUSS] Add Common Integ Test Modules

2024-11-01 Thread Heesung Sohn
Hi, I agree with your points that there are tradeoffs between in-memory vs container test clusters, and that we should add more "unit" tests to cover behavior and avoid deep state checks. We should smartly move/add integ tests in in-memory or container test clusters, without increasing the test ex

Re: [DISCUSS] Add Common Integ Test Modules

2024-11-01 Thread Lari Hotari
I guess the problem is that most Pulsar tests are integration tests and there aren't many actual unit tests for the most important parts of the Pulsar code base. There's also a lot of tests which test the implementation and not publicly observable behaviors that is typically a recommendation. F

Re: [DISCUSS] Add Common Integ Test Modules

2024-11-01 Thread Lari Hotari
I agree, it's not optimal. In Pulsar, most tests that we call "unit tests" are actually integration tests. Since there a lot of such tests which rely on clean state (state cleared after every method), switching to some other solution for these tests could potentially increase test times. That's

Re: [DISCUSS] Add Common Integ Test Modules

2024-11-01 Thread Lari Hotari
Sounds good. Looking forward to it! btw. We currently have 2 modules that are test libraries: "testmocks" and "pulsar-testclient". The pom.xmls of those projects could be useful when splitting out the test libraries. -Lari On 2024/10/31 22:15:03 Heesung Sohn wrote: > Hi all, > > I think we can