Re: [VOTE] PIP-342: Support OpenTelemetry metrics in Pulsar client

2024-03-14 Thread Zixuan Liu
+1 (non-binding) Thanks, Zixuan PengHui Li 于2024年3月15日周五 09:47写道: > +1 (binding) > > Regards, > Penghui > > On Fri, Mar 15, 2024 at 2:32 AM Asaf Mesika wrote: > > > +1 (non-binding) > > > > On Thu, Mar 14, 2024 at 8:29 PM Apurva Telang > > wrote: > > > > > +1 (non-binding) > > > > > > On Thu,

Re: [DISCUSS] PIP-345: Optimize finding message by timestamp

2024-03-14 Thread 太上玄元道君
Hi, Girish, Thanks for your feedback! In general, it's a very good suggestion, we can just use one single `beginPublishTimestamp` to achieve our goal, but the actual problem will be a bit more complex. Actually, the naming of `beginPublishTimestamp` and `endPublishTimestamp` has a little problem

Re: [DISCUSS] PIP-345: Optimize finding message by timestamp

2024-03-14 Thread Girish Sharma
One suggestion, I think you can make do with storing just begin timestamp. Any search utilising these values will work the same way with just one of those timestamps compared to both begin and end. Any particular reason you need both the timestamps? Regards On Fri, Mar 15, 2024, 9:39 AM 太上玄元道君

Re: [DISCUSS] PIP-345: Optimize finding message by timestamp

2024-03-14 Thread 太上玄元道君
bump 太上玄元道君 于2024年3月10日 周日06:41写道: > Hi Pulsar community, > > A new PIP is opened, this thread is to discuss PIP-345: Optimize finding > message by timestamp. > > Motivation: > Finding message by timestamp is widely used in Pulsar: > * It is used by the `pulsar-admin` tool to get the message id b

Re: [VOTE] Pulsar Client C++ Release 3.5.0 Candidate 2

2024-03-14 Thread guo jiwei
+1 (binding) - Verified checksum and signatures - Built from source on macOS m1 - Ran the tests Regards Jiwei Guo (Tboy) On Thu, Mar 14, 2024 at 9:12 PM Yunze Xu wrote: > +1 (binding) > > - Verified checksum and signatures > - Built from source on macOS m1 > - Upgrade the dependency of the py

Re: [VOTE] Pulsar Client C++ Release 3.5.0 Candidate 2

2024-03-14 Thread PengHui Li
+1 (binding) - Checked the signature - Tested the pre-build binaries on Mac (m2 pro) Regards, Penghui On Thu, Mar 14, 2024 at 9:12 PM Yunze Xu wrote: > +1 (binding) > > - Verified checksum and signatures > - Built from source on macOS m1 > - Upgrade the dependency of the python client and veri

Re: [VOTE] PIP-342: Support OpenTelemetry metrics in Pulsar client

2024-03-14 Thread PengHui Li
+1 (binding) Regards, Penghui On Fri, Mar 15, 2024 at 2:32 AM Asaf Mesika wrote: > +1 (non-binding) > > On Thu, Mar 14, 2024 at 8:29 PM Apurva Telang > wrote: > > > +1 (non-binding) > > > > On Thu, Mar 14, 2024 at 2:12 AM mattison chao > > wrote: > > > > > +1 (binding) > > > > > > Best, > > >

Re: [VOTE] PIP-342: Support OpenTelemetry metrics in Pulsar client

2024-03-14 Thread Asaf Mesika
+1 (non-binding) On Thu, Mar 14, 2024 at 8:29 PM Apurva Telang wrote: > +1 (non-binding) > > On Thu, Mar 14, 2024 at 2:12 AM mattison chao > wrote: > > > +1 (binding) > > > > Best, > > Mattison > > On Mar 14, 2024 at 15:55 +0800, Lari Hotari , wrote: > > > +1 (binding) > > > > > > -Lari > > > >

Re: [VOTE] PIP-342: Support OpenTelemetry metrics in Pulsar client

2024-03-14 Thread Apurva Telang
+1 (non-binding) On Thu, Mar 14, 2024 at 2:12 AM mattison chao wrote: > +1 (binding) > > Best, > Mattison > On Mar 14, 2024 at 15:55 +0800, Lari Hotari , wrote: > > +1 (binding) > > > > -Lari > > > > On Thu, 14 Mar 2024 at 03:45, Matteo Merli > wrote: > > > > > > PIP: https://github.com/apache/

Re: [VOTE] Pulsar Client C++ Release 3.5.0 Candidate 2

2024-03-14 Thread Yunze Xu
+1 (binding) - Verified checksum and signatures - Built from source on macOS m1 - Upgrade the dependency of the python client and verified the issues are fixed (https://github.com/apache/pulsar-client-python/pull/202) Thanks, Yunze On Thu, Mar 14, 2024 at 6:13 PM Yunze Xu wrote: > > The vcpkg s

Pulsar community meeting today: please add agenda items

2024-03-14 Thread Lari Hotari
Hi all, Please note that the Pulsar community meeting scheduled for today will take place 1 hour earlier than usual for at least European participants. This is because the meeting is scheduled in a calendar that follows a North American timezone, where the daylight saving time change occurred l

Re: [DISCUSS] 2.10 & 2.11 EOL - pulsar.apache.org website shows that support has ended

2024-03-14 Thread Lari Hotari
There's also a PR to change the GitHub issue template for bug reports: https://github.com/apache/pulsar/pull/22267 This is to ensure that bug reporters are aware that bugs won't get fixed in unsupported versions and that they would do the work to first reproduce the issue on a supported version

Re: [DISCUSS] 2.10 & 2.11 EOL - pulsar.apache.org website shows that support has ended

2024-03-14 Thread Lari Hotari
Thanks for documenting this, Frank. I have created a PR to update the release policy, https://github.com/apache/pulsar-site/pull/848 . Please review. The last set of CVEs were raising questions about breaking our release policy when we provided upgrades for unsupported versions of Pulsar by rele

Re: [VOTE] Pulsar Client C++ Release 3.5.0 Candidate 2

2024-03-14 Thread Yunze Xu
The vcpkg submodule is just convenient for development. You can just run `git clone https://github.com/microsoft/vcpkg.git` in the source directory instead of fetching the submodule. BTW, I just found that when INTEGRATE_VCPKG is ON, we cannot customize the CMAKE_TOOLCHAIN_FILE. So I opened a PR t

Re: [VOTE] PIP-342: Support OpenTelemetry metrics in Pulsar client

2024-03-14 Thread mattison chao
+1 (binding) Best, Mattison On Mar 14, 2024 at 15:55 +0800, Lari Hotari , wrote: > +1 (binding) > > -Lari > > On Thu, 14 Mar 2024 at 03:45, Matteo Merli wrote: > > > > PIP: https://github.com/apache/pulsar/pull/22178 > > > > WIP PR: https://github.com/apache/pulsar/pull/22179 > > > > > > > > > >

Re: [VOTE] PIP-342: Support OpenTelemetry metrics in Pulsar client

2024-03-14 Thread Lari Hotari
+1 (binding) -Lari On Thu, 14 Mar 2024 at 03:45, Matteo Merli wrote: > > PIP: https://github.com/apache/pulsar/pull/22178 > > WIP PR: https://github.com/apache/pulsar/pull/22179 > > > > > -- > Matteo Merli >

Re: [DISCUSS] Pulsar Client Go - Avro Schema

2024-03-14 Thread Zike Yang
Hi, > A) Should the Consumer / Reader be allowed to override the Schema creation after schema-definition is retrieved from Schema Registry ? Are you suggesting we adjust the schema creator, allowing the Consumer/Reader to use a different Avro library? I'm interested in others' thoughts. > B) Sho

Re: [VOTE] Pulsar Client C++ Release 3.5.0 Candidate 2

2024-03-14 Thread Baodi Shi
Hi, yunze https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-cpp/pulsar-client-cpp-3.5.0-candidate-2/apache-pulsar-client-cpp-3.5.0.tar.gz This source code not include vcpkg, If we unzip it and run the command cmake -B build -DINTEGRATE_VCPKG=ON, it throws an error. Do we need to include

Re: [DISCUSS] Clarify the relation between supported Pulsar versions and versioned docs

2024-03-14 Thread Kiryl Valkovich
I submitted the PR https://github.com/apache/pulsar-site/pull/843 Best, Kiryl > On Mar 10, 2024, at 10:02 PM, Kiryl Valkovich wrote: > > Asaf and Dave, thank you for your responses. > > The proposed version menu structure looks good to me: > - Next > - active versions still in support > - O