Re: [DISCUSS] Make the API compatibility guarantee clear

Hi Enrico, > Also adding it to all the existing classes is a big task. Yes. I don't support adding it to existing classes as well. But we need to apply the annotation for new code. > because basically we wouldn't be able to commit change if we prevent > adding/removing methods that are marked

Re: [DISCUSS] Make the API compatibility guarantee clear

Commenting on bringing up the example of PR https://github.com/apache/pulsar/pull/20733 . It isn't a good example of breaking compatibility at all. The WebSocketPingPongServlet and PingPongHandler never made any sense. The issue eclipse/jetty.project#4880 [1] explains that Websocket Pong is provid

Re: [DISCUSS] Make the API compatibility guarantee clear

Yunze, I agree overall with the proposal, I added some comments inline below Enrico Il giorno ven 14 lug 2023 alle ore 13:25 Yunze Xu ha scritto: > > Good suggestion. We can try that. > > Thanks, > Yunze > > On Fri, Jul 14, 2023 at 7:03 PM Lari Hotari wrote: > > > > Makes sense. We should use t

Re: [DISCUSS] Release Pulsar 3.0.1

Il giorno ven 14 lug 2023 alle ore 13:22 Yunze Xu ha scritto: > > -1 (binding) > > Many public interfaces are modified. I second Yunze -1 (binding) from myself as well Enrico > > https://github.com/apache/pulsar/pull/20666 > org.apache.pulsar.broker.loadbalance.extensions.filter.BrokerFilter#

Re: [VOTE] Pulsar Release 3.0.1 Candidate 1

-1 (binding) Sorry I replied in the wrong mailing list. See the reason here: https://lists.apache.org/thread/6ysc0yys9bkfbp5zky6svj3t2t5f1sy4 Thanks, Yunze On Fri, Jul 14, 2023 at 6:03 PM PengHui Li wrote: > > +1 (binding) > > Environment: > > openjdk version "17.0.7" 2023-04-18 LTS > Apache M

Re: [DISCUSS] Make the API compatibility guarantee clear

Good suggestion. We can try that. Thanks, Yunze On Fri, Jul 14, 2023 at 7:03 PM Lari Hotari wrote: > > Makes sense. We should use tooling in CI to enforce binary > compatibility of the modules that shouldn't break. > There's japicmp [1] that can be used to do this. japicmp comes with a > maven p

Re: [DISCUSS] Release Pulsar 3.0.1

-1 (binding) Many public interfaces are modified. https://github.com/apache/pulsar/pull/20666 org.apache.pulsar.broker.loadbalance.extensions.filter.BrokerFilter#filter https://github.com/apache/pulsar/pull/20677 org.apache.pulsar.common.topics.TopicCompactionStrategy#load I also found some oth

Re: [DISCUSS] Make the API compatibility guarantee clear

In addition to the rule of the patch releases, it's acceptable to have new public methods for bug fixes, though we should pay enough effort to avoid it. If so, we should not remove or change any public method. I just checked a few recent PRs in branch-3.0 and added some examples here. https://git

Re: [DISCUSS] Make the API compatibility guarantee clear

Makes sense. We should use tooling in CI to enforce binary compatibility of the modules that shouldn't break. There's japicmp [1] that can be used to do this. japicmp comes with a maven plugin [2] that needs to be configured with the rules to be used. -Lari 1 - https://siom79.github.io/japicmp/ 2

[DISCUSS] Make the API compatibility guarantee clear

Hi all, As the Pulsar community is growing, the core project could be depended on by many ecosystem projects, including protocol handlers and connectors. However, there is no clear API compatibility guarantee at the moment. For now, PIP is required when public APIs change [1]. However, I think th

Re: [DISCUSS] PIP-281: Add notifyError method on PushSource

Could you please help add a section to explain the compatibility guarantee? Others look good to me. Regards, Penghui On Fri, Jul 14, 2023 at 6:07 PM Baodi Shi wrote: > Hi, All > > I opened a new PIP design PR. > I am looking forward to your feedback. > > https://github.com/apache/pulsar/pull/20

Re: [VOTE] Pulsar Release 2.11.2 Candidate-1

+1 (binding) Environment: openjdk version "17.0.7" 2023-04-18 LTS Apache Maven 3.8.8 - Checked the signature - Build from source - Start standalone - Publish and Consume - Verified Cassandra connector - Verified stateful function Regards, Penghui On Thu, Jul 13, 2023 at 12:03 PM guo jiwei wro

[DISCUSS] PIP-281: Add notifyError method on PushSource

Hi, All I opened a new PIP design PR. I am looking forward to your feedback. https://github.com/apache/pulsar/pull/20807 This is a very simple change and is forward-compatible. Sorry, I didn't notice that this change required PIP before, so the rel

Re: [VOTE] Pulsar Release 3.0.1 Candidate 1

+1 (binding) Environment: openjdk version "17.0.7" 2023-04-18 LTS Apache Maven 3.8.8 - Checked the signature - Build from source - Start standalone - Publish and Consume - Verified Cassandra connector - Verified stateful function Regards, Penghui On Thu, Jul 13, 2023 at 2:45 PM Zike Yang wro