Il giorno ven 14 lug 2023 alle ore 13:22 Yunze Xu <x...@apache.org> ha scritto: > > -1 (binding) > > Many public interfaces are modified.
I second Yunze -1 (binding) from myself as well Enrico > > https://github.com/apache/pulsar/pull/20666 > org.apache.pulsar.broker.loadbalance.extensions.filter.BrokerFilter#filter > > https://github.com/apache/pulsar/pull/20677 > org.apache.pulsar.common.topics.TopicCompactionStrategy#load > > I also found some other issues with our PIP. > - The BrokerFilter interface is never mentioned in PIP-192 [1] > - TopicCompactionStrategy is mentioned in PIP-215[2], but this change is never > > We should not make breaking public API changes by saying they are > so-called bug fixes. If the bug cannot be fixed without introducing > any new API, just add them instead of modifying existing APIs. > > [1] https://github.com/apache/pulsar/issues/16691 > [2] https://github.com/apache/pulsar/issues/18099 > > Thanks, > Yunze > > On Mon, Jul 3, 2023 at 8:29 AM PengHui Li <peng...@apache.org> wrote: > > > > Hi Zike, > > > > I have cherry-picked 3 PRs intro branch-3.0. All of them of well-understand > > bugs and performance issues. > > > > https://github.com/apache/pulsar/pull/20647 > > https://github.com/apache/pulsar/pull/20669 > > https://github.com/apache/pulsar/pull/20607 > > > > Thanks, > > Penghui > > > > On Fri, Jun 30, 2023 at 2:48 PM Yubiao Feng > > <yubiao.f...@streamnative.io.invalid> wrote: > > > > > Hi Zike > > > > > > > https://github.com/apache/pulsar/pull/20690 > > > > > > cherry-picked into branch-3.0 > > > > > > Thanks > > > Yubiao Feng > > > > > > On Fri, Jun 30, 2023 at 12:37 PM Yubiao Feng <yubiao.f...@streamnative.io> > > > wrote: > > > > > > > Hi Zike > > > > > > > > There is a bug fix involving a regression: > > > > - https://github.com/apache/pulsar/pull/20690 > > > > > > > > Thanks > > > > Yubiao Feng > > > > > > > > On Thu, Jun 1, 2023 at 7:38 PM Zike Yang <z...@apache.org> wrote: > > > > > > > >> Hi all, > > > >> > > > >> I would like to propose releasing the Pulsar 3.0.1. > > > >> > > > >> Currently, there are 95 new commits in branch-3.0: > > > >> https://github.com/apache/pulsar/compare/v3.0.0...branch-3.0 > > > >> > > > >> And we have found that there is an issue with the pulsar-all:3.0.0 > > > >> image: https://lists.apache.org/thread/phcrm6czhyo7po6qncojk46hkytswblj > > > >> > > > >> We need to cut a new release. Please let me know if you have any > > > >> important fixes that need to be included in Pulsar 3.0.1. > > > >> > > > >> Thanks, > > > >> Zike Yang > > > >> > > > > > > >
