Re: [VOTE] PIP-250: Add proxyVersion to CommandConnect

+1 (binding) PIP passes with 3 binding +1 votes (Enrico, Yunze, Michael) and 4 non binding +1 votes (ZhangJian, Yubiao, Zike, Zixuan) Thanks, Michael On Mon, Mar 13, 2023 at 5:22 AM Zixuan Liu wrote: > > +1 (non-binding) > > Thanks, > Zixuan > > Yunze Xu 于2023年3月13日周一 17:31写道： > > > +1 (bindin

Re: [VOTE] PIP-257: Add Open ID Connect Support to Server Components

+ 1 (binding) PIP passes with 4 binding +1 votes (Lari, Dave, Enrico, and Michael) and 1 non-binding +1 (Devin) There is some final feedback I need to address on the PIP, and then I'll merge the two PRs. Thanks, Michael On Tue, Mar 28, 2023 at 11:00 AM Devin Bost wrote: > > +1 > > Devin G. Bos

Re: [DISCUSS] Dropping the StreamingDispatcher

Totally agree with it. +1 Best Mattison On Apr 6, 2023, 10:53 +0800, Devin Bost , wrote: > +1 since it can be pulled back up in git history if someone decides to do > something with it to improve it at a later time. > > I also agree that it's a pain to maintain, and I don't know anyone using > it.

[DISCUSS] Release Pulsar Node.js Client 1.8.2

Hi everyone, I would like to propose releasing the Pulsar Node.js Client v1.8.2. The current latest version (v1.8.1) has a serious problem - It does not run in Node.js version greater than 16 (Linux environment)[0]. - Also, it's not compatible with Alpine 3.15[1]. [0] https://github

Re: Pulsar Flaky test report 2023-04-03 for PR builds in CI

Great team work on all the flaky tests. It's much appreciated. - Devin On Wed, Apr 5, 2023, 4:39 PM Michael Marshall wrote: > Thanks for fixing that test Heesung, and thanks for the report Nicolo! > > - Michael > > On Wed, Apr 5, 2023 at 2:17 PM Lari Hotari wrote: > > > > Thank you Heesung for

Re: [DISCUSS] Dropping the StreamingDispatcher

+1 since it can be pulled back up in git history if someone decides to do something with it to improve it at a later time. I also agree that it's a pain to maintain, and I don't know anyone using it. I've gone through some of those code paths, and I was concerned about divergence anyway. - Devin

Re: [DISCUSS] Dropping the StreamingDispatcher

If the code isn't being used or maintained, I support removing it. The code will be available in the git history in case someone decides to resurrect it. Thanks, Michael On Wed, Apr 5, 2023 at 7:14 AM Enrico Olivelli wrote: > > Yunze, > > Il Mar 4 Apr 2023, 09:57 Yunze Xu ha scritto: > > > If t

Re: Pulsar Flaky test report 2023-04-03 for PR builds in CI

Thanks for fixing that test Heesung, and thanks for the report Nicolo! - Michael On Wed, Apr 5, 2023 at 2:17 PM Lari Hotari wrote: > > Thank you Heesung for resolving the problem so quickly. > > -Lari > > ke 5. huhtik. 2023 klo 20.23 Heesung Sohn > kirjoitti: > > > Hi, > > > > The fix PR( #1994

Re: Pulsar Flaky test report 2023-04-03 for PR builds in CI

Thank you Heesung for resolving the problem so quickly. -Lari ke 5. huhtik. 2023 klo 20.23 Heesung Sohn kirjoitti: > Hi, > > The fix PR( #19945 ) has been > merged(I also notified here, > https://github.com/apache/pulsar/issues/20007#issuecomment-149

Re: Pulsar Flaky test report 2023-04-03 for PR builds in CI

Hi, The fix PR( #19945 ) has been merged(I also notified here, https://github.com/apache/pulsar/issues/20007#issuecomment-1497679571). If this test continues to be flaky, I agree with quarantining it not to harm builds for the time being. Regards, Hees

Re: Pulsar Flaky test report 2023-04-03 for PR builds in CI

I think we might want to move ExtensibleLoadManagerImplTest to the flaky group until the fixes have been completed. Most builds fail now because of the flakiness of that test. That is blocking our progress and moving to flaky group would resolve that issue. Once that it is proven to be stable, w

Re: [DISCUSS] Dropping the StreamingDispatcher

Yunze, Il Mar 4 Apr 2023, 09:57 Yunze Xu ha scritto: > If the flaky tests were the only concern, I think we can just disable > these tests. My concern is not about the the flaky tests but a out maintenance of dead code. Whatever, this config in `ServiceConfiguration` has > existed for a lon

Re: [DISCUSS] Dropping the StreamingDispatcher

It looks like the purpose of the StreamingDispatcher was to improve performance by implementing an improved readahead mechanism. Was it actually able to accomplish this objective? If so, why do we need a separate code path for it instead of updating the existing dispatcher to use the improvement? I