Re: [VOTE] Pulsar Release 2.11.0 Candidate-5

2023-01-08 Thread Enrico Olivelli
+1 (binding) - checked signatures/digests/rat - built from source - run smoke tests on the built binaries Thanks Enrico Il giorno lun 9 gen 2023 alle ore 06:18 guo jiwei ha scritto: > > +1 (binding) > > - Checked the signature > - Build from source > - Checked license(server and shell) > - Sta

Re: [DISCUSS] PIP-239: Retry Mechanism per Message

2023-01-08 Thread Enrico Olivelli
I don't think that this is a good idea. Because IIUC we want to add a property per message that sets the maximum time of retries. Unfortunately in a real system sometimes you have to change the number of retries temporarily, for instance in case of major system failure you don't want to lose all

Re: [VOTE] PIP-239: Retry Mechanism per Message title

2023-01-08 Thread Enrico Olivelli
I am sure that this is a good idea. -1 (binding) I will follow up on the discussion thread I am sorry I am catching up late on this thread Enrico Il giorno lun 9 gen 2023 alle ore 03:51 Ran Gao ha scritto: > > +1 (non-binding) > > Thanks, > Ran Gao > > On 2023/01/08 15:05:31 Zixuan Liu wrote:

Re: [DISCUSS] Introduce oshi library to sensory OS resources

2023-01-08 Thread Enrico Olivelli
Please create a plan about how to leverage it. The PR only adds the dependency Enrico Il giorno lun 9 gen 2023 alle ore 04:26 Cong Zhao ha scritto: > > +1 > > Thanks, > Cong > > On 2022/12/19 10:19:07 mattisonc...@gmail.com wrote: > > > > Hi, All > > > > I would like to introduce a new library

Re: [VOTE] Pulsar Release 2.11.0 Candidate-5

2023-01-08 Thread guo jiwei
+1 (binding) - Checked the signature - Build from source - Checked license(server and shell) - Start standalone with zookeeper - Checked function - Checked Cassandra connector - Checked stateful function Regards Jiwei Guo (Tboy) On Wed, Jan 4, 2023 at 8:25 PM Nicolò Boschi wrote: > About Pul

Re: [DISCUSS] PIP-236: Upload AUTO_CONSUME SchemaType to Broker

2023-01-08 Thread SiNan Liu
This design also has serious compatibility problems between old and new pulsar clients and new and old brokers. Thanks, Sinan PengHui Li 于 2023年1月9日周一 上午9:51写道: > Sorry for the late reply. > > We can leverage the `ProtocolVersion` [1] to handle the compatibility > issue. > It looks like only

Re: [DISCUSS] Introduce oshi library to sensory OS resources

2023-01-08 Thread Cong Zhao
+1 Thanks, Cong On 2022/12/19 10:19:07 mattisonc...@gmail.com wrote: > > Hi, All > > I would like to introduce a new library oshi[1] to help Apache Pulsar sensory > OS resources. It can help us to get away from the complex file manipulation > and cross-platform compatibility issues in some op

Re: [VOTE] PIP-239: Retry Mechanism per Message title

2023-01-08 Thread Ran Gao
+1 (non-binding) Thanks, Ran Gao On 2023/01/08 15:05:31 Zixuan Liu wrote: > +1 (non-binding) > > Thanks, > Zixuan > > Yunze Xu 于2023年1月8日周日 22:38写道: > > > +1 (binding) > > > > Thanks, > > Yunze > > > > On Sun, Jan 8, 2023 at 4:46 PM Zike Yang wrote: > > > > > > +1 (non-binding) > > > > > > T

Re: [DISCUSS] PIP-236: Upload AUTO_CONSUME SchemaType to Broker

2023-01-08 Thread Yunze Xu
We should not use a negative enum number in PulsarApi.proto. It's unnatural. If we decide to carry the AUTO_CONSUME schema in a CommandSubscribe, it should not be treated as a negative schema type. Thanks, Yunze On Mon, Jan 9, 2023 at 9:51 AM PengHui Li wrote: > > Sorry for the late reply. > > W

Re: [DISCUSS] Introduce oshi library to sensory OS resources

2023-01-08 Thread Ran Gao
+1 Thanks, Ran Gao On 2022/12/21 09:38:01 Zike Yang wrote: > +1 > > Thanks, > Zike Yang > > On Wed, Dec 21, 2022 at 5:06 PM Yunze Xu wrote: > > > > +1 > > > > Thanks, > > Yunze > > > > On Wed, Dec 21, 2022 at 5:02 PM houxiaoyu wrote: > > > > > > +1 > > > > > > Yubiao Feng 于2022年12月21日周三 11:5

Re: [DISCUSS] PIP-236: Upload AUTO_CONSUME SchemaType to Broker

2023-01-08 Thread PengHui Li
Sorry for the late reply. We can leverage the `ProtocolVersion` [1] to handle the compatibility issue. It looks like only if the protocol_version >= 21, subscribe with the auto_consume schema IMO, both the new key-value of the subscribe command, and a specific representative are API changes. It's

Re: [VOTE] PIP-239: Retry Mechanism per Message title

2023-01-08 Thread Zixuan Liu
+1 (non-binding) Thanks, Zixuan Yunze Xu 于2023年1月8日周日 22:38写道: > +1 (binding) > > Thanks, > Yunze > > On Sun, Jan 8, 2023 at 4:46 PM Zike Yang wrote: > > > > +1 (non-binding) > > > > Thanks, > > Zike Yang > > > > On Sun, Jan 8, 2023 at 3:22 PM Haiting Jiang > wrote: > > > > > > +1 binding > >

Re: [VOTE] PIP-239: Retry Mechanism per Message title

2023-01-08 Thread Yunze Xu
+1 (binding) Thanks, Yunze On Sun, Jan 8, 2023 at 4:46 PM Zike Yang wrote: > > +1 (non-binding) > > Thanks, > Zike Yang > > On Sun, Jan 8, 2023 at 3:22 PM Haiting Jiang wrote: > > > > +1 binding > > > > Although I think we should use more unique keys for system properties in > > pulsar, > > e.

Re: [VOTE] PIP-239: Retry Mechanism per Message title

2023-01-08 Thread Zike Yang
+1 (non-binding) Thanks, Zike Yang On Sun, Jan 8, 2023 at 3:22 PM Haiting Jiang wrote: > > +1 binding > > Although I think we should use more unique keys for system properties in > pulsar, > e.g. reserve all properties prefixed with "PULSAR_" for system internal usage. > But it's another topic