+1 (binding) - checked signatures/digests/rat - built from source - run smoke tests on the built binaries
Thanks Enrico Il giorno lun 9 gen 2023 alle ore 06:18 guo jiwei <techno...@apache.org> ha scritto: > > +1 (binding) > > - Checked the signature > - Build from source > - Checked license(server and shell) > - Start standalone with zookeeper > - Checked function > - Checked Cassandra connector > - Checked stateful function > > > Regards > Jiwei Guo (Tboy) > > > On Wed, Jan 4, 2023 at 8:25 PM Nicolò Boschi <boschi1...@gmail.com> wrote: > > > About Pulsar Shell, > > 1) zip file is distributed as a commodity for Windows users since the > > .tar.gz archive is more tricky to extract. If this is a problem, we can > > discuss it in another thread > > 2) The bug on Windows is not a blocker for the release since it's not a > > regression. We could fix it in 2.11.1 > > > > Here's my vote: > > > > +1 non binding > > > > - Signature and checksum > > - LICENSE on server and shell > > > > - Rat check passes > > > > - Compile from source with JDK 17 on MacOs Intel > > > > - Run Pulsar standalone and produce-consume from CLI > > > > - Tested K8S installation with Datastax Pulsar helm chart and verified TLS, > > offloads, transactions and ElasticSearch sink > > > > - Pulsar Shell commands > > > > > > Thanks, > > Nicolò Boschi > > > > > > Il giorno mer 4 gen 2023 alle ore 12:33 丛搏 <bog...@apache.org> ha scritto: > > > > > +1 (non-binding) > > > > > > system: mac os 12.6, Apple M1 > > > maven: 3.8.5 > > > java: OpenJDK 17.0.3 > > > > > > - Checked the signature > > > - Checked LICENSE > > > - Start standalone with zookeeper stream storage > > > - Publish and consume messages > > > - Verified Function and State Function > > > - Verified Cassandra connector > > > - Build from the source package > > > - Run a simple transaction performance check > > > > > > Thanks, > > > Bo > > > > > > Yunze Xu <y...@streamnative.io.invalid> 于2023年1月4日周三 16:41写道： > > > > > > > > Okay, I will give my +1 (binding). > > > > > > > > Thanks, > > > > Yunze > > > > > > > > On Wed, Jan 4, 2023 at 4:00 PM PengHui Li <peng...@apache.org> wrote: > > > > > > > > > > I think it's ok. > > > > > 2.11.0 is the first release version of pulsar-shell > > > > > So it's not a regression that was introduced in 2.11.0 and not > > > > > critical security issues or license issues which will block users > > move > > > > > to the new version. > > > > > > > > > > Thanks, > > > > > Penghui > > > > > > > > > > > > > > > > > > > > On Wed, Jan 4, 2023 at 3:36 PM Yunze Xu <y...@streamnative.io.invalid > > > > > > > > wrote: > > > > > > > > > > > +0 (binding) > > > > > > > > > > > > - Checked the signature > > > > > > - Build from source (Java 17, Ubuntu 20.04 WSL2) > > > > > > - Start standalone with KoP branch-2.11 (ab9d761f) > > > > > > - Verify Pulsar client 2.11.0, Kafka client 3.3.1 (through KoP) > > > > > > - Verify pulsar-shell on Ubuntu 20.04 WSL2 and Windows: > > > > > > 1. Use `client` command to produce and consume messages > > > > > > 2. Use `admin` command to create, list and delete topics > > > > > > > > > > > > I didn't give +1 because I have to modify the > > > > > > `bin/pulsar-admin-common.cmd` to make `pulsar-shell` work on > > Windows. > > > > > > I left a command here: > > > > > > https://github.com/apache/pulsar/pull/17243#discussion_r1061199501 > > . > > > > > > Not sure if it's a blocker so I didn't give +1 or -1 until someone > > > > > > could explain it. > > > > > > > > > > > > Thanks, > > > > > > Yunze > > > > > > > > > > > > On Wed, Jan 4, 2023 at 2:37 PM PengHui Li <peng...@apache.org> > > > wrote: > > > > > > > > > > > > > > > I found there are both apache-pulsar-shell-2.11.0-bin.tar.gz > > and > > > > > > > apache-pulsar-shell-2.11.0-bin.zip, are they duplicates? > > > > > > > > > > > > > > I noticed here is the discussion about this part in Slack > > > > > > > > > > https://apache-pulsar.slack.com/archives/C5ZSVEN4E/p1672411025574369 > > > > > > > > > > > > > > Penghui > > > > > > > > > > > > > > On Wed, Jan 4, 2023 at 2:35 PM Yunze Xu > > > <y...@streamnative.io.invalid> > > > > > > > wrote: > > > > > > > > > > > > > > > I found there are both apache-pulsar-shell-2.11.0-bin.tar.gz > > and > > > > > > > > apache-pulsar-shell-2.11.0-bin.zip, are they duplicates? > > > > > > > > > > > > > > > > Thanks, > > > > > > > > Yunze > > > > > > > > > > > > > > > > On Mon, Jan 2, 2023 at 8:01 PM guo jiwei <techno...@apache.org > > > > > > wrote: > > > > > > > > > > > > > > > > > > This is the fifth release candidate for Apache Pulsar, > > version > > > > > > 2.11.0. > > > > > > > > > > > > > > > > > > This release contains 1617 commits by 61 contributors. > > > > > > > > > > > > > > > > > > https://github.com/apache/pulsar/compare/v2.10.2...v2.11.0-candidate-5 > > > > > > > > > > > > > > > > > > CI for this release candidate > > > > > > > > > https://github.com/Technoboy-/pulsar/pull/26 > > > > > > > > > > > > > > > > > > *** Please download, test and vote on this release. This vote > > > will > > > > > > stay > > > > > > > > open > > > > > > > > > for at least 72 hours *** > > > > > > > > > > > > > > > > > > Note that we are voting upon the source (tag), binaries are > > > provided > > > > > > for > > > > > > > > > convenience. > > > > > > > > > > > > > > > > > > Source and binary files: > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.11.0-candidate-5 > > > > > > > > > > > > > > > > > > SHA-512 checksums: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > 5bf77f600ac23c7ec72696655a49801e0755d67fb4c59c7ab30e9449b061aacef61ca227f106e6b7f5f490fc2ac57412ac2af3ff064ba1e6a31c162d4ca2ba6d > > > > > > > > > > > > > > > > > > ./apache-pulsar-2.11.0-bin.tar.gz > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > 0a3cab04b4a95ced3745d8b41fc3fa2632c91f77cb10e5c7e008b09ba2f279fc14de109626a44a9482b5354c5fa17bbc07ee369a32a252e358298e494c0fc1cb > > > > > > > > > > > > > > > > > > ./apache-pulsar-2.11.0-src.tar.gz > > > > > > > > > > > > > > > > > > Maven staging repo: > > > > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachepulsar-1203/ > > > > > > > > > > > > > > > > > > The tag to be voted upon: > > > > > > > > > v2.11.0-candidate-5 > > (97ee1a114aa1e5df05d86a9dd47f7fe7a2194211) > > > > > > > > > > > > https://github.com/apache/pulsar/releases/tag/v2.11.0-candidate-5 > > > > > > > > > > > > > > > > > > Pulsar's KEYS file containing PGP keys we use to sign the > > > release: > > > > > > > > > https://dist.apache.org/repos/dist/dev/pulsar/KEYS > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://hub.docker.com/layers/mattison/pulsar-all/2.11.0-rc5/images/sha256-548a518bb18890ddf8e48f0bad62695cfc4f743b9e1223ca45b2e03dba6e9149 > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://hub.docker.com/layers/mattison/pulsar/2.11.0-rc5/images/sha256-3b755fb67d49abeb7ab6a76b7123cc474375e3881526db26f43c8cfccdaa3cf6 > > > > > > > > > > > > > > > > > > Please download the source package, and follow the > > > > > > > > > release-candidate-validation doc to build > > > > > > > > > and run the Pulsar standalone service. > > > > > > > > > > > > https://pulsar.apache.org/contribute/validate-release-candidate > > > > > > > > > > > > > > > > > > Since the metadata store is changed from ZK to RocksDB, the > > > > > > verification > > > > > > > > of > > > > > > > > > the `stateful functions` needs to set the parameter "export > > > > > > > > > PULSAR_STANDALONE_USE_ZOOKEEPER=1" > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Regards > > > > > > > > > Jiwei Guo (Tboy) > > > > > > > > > > > > > > > > > > >
