Re: [VOTE] Pulsar Client C++ Release 3.0.0 Candidate 3

2022-10-24 Thread PengHui Li
+1 (binding) - Verified the signatures - Build from the source (osx 12.6) Thanks, Penghui On Mon, Oct 24, 2022 at 10:53 PM Yunze Xu wrote: > +1 (non-bindings) > > * verify checksum and signatures > * build from source (Ubuntu 20.04 x86_64) > * basic e2e tests with libraries built from source >

Re: [DISCUSS] Use SLASHSTAR_STYLE for Java files

2022-10-24 Thread tison
Patch merged. Be aware that we may suffer a period that new patches introduce regression for the JAVADOC_STYLE license header because we don't require the patch to be merged must be up-to-date. But the overall situation should converge. For reviewers, if you notice that a patch adds new files, yo

[DISCUSS] PIP-218: Consumer batchReceive() single partition every receive

2022-10-24 Thread 丛搏
Hi, pulsar community: I start a PIP about `User-friendly acknowledgeCumulative API on a partitioned topic or multi-topics` discuss thread: https://lists.apache.org/thread/30rwksz4gmvgspkgcfsk708sgb1n7vbo https://lists.apache.org/thread/k090ftlqc149yr1cnprxb29vxg160131 PIP: https://github.com/apa

Re: [DISCUSS] PIP-215: Configurable Topic Compaction Strategy

2022-10-24 Thread Heesung Sohn
Hi, Regarding the release plan of this strategic compaction, I think we can take a conservative approach. First, since this is required for the system topic introduced in PIP-192, we can make this strategic compaction internal-only(the PIP-192, new broker load balancer will be the only use-case i

Re: [VOTE] PIP-212: Default reppDnsResolverClass to ZkBookieRackAffinityMapping

2022-10-24 Thread Yu
Thanks, Michael! Feel free to ping me if you need a doc review. On Tue, Oct 25, 2022 at 2:17 AM Michael Marshall wrote: > +1 (binding) > > Thank you all for voting. > > I am closing the vote with 4 binding +1 votes (Dave, Enrico, PengHui, > Michael) and 2 non-binding +1 votes (Bo, Zike). > > I w

Re: [DISCUSS] PIP-215: Configurable Topic Compaction Strategy

2022-10-24 Thread Heesung Sohn
Hi, please find my answers inline. On Sun, Oct 23, 2022 at 7:11 PM PengHui Li wrote: > Sorry, heesung, > > I think I used a confusing name "leader election". > Actually, I meant to say "topic owner". > > From my understanding, the issue is if we are using the table view for a > compacted topic.

Pulsar in OpenSSF?

2022-10-24 Thread Asaf Mesika
Hi, I recently bumped into the Pulsar page in the Scorecards project of OpenSSF. I was wondering if anybody has any context/insight on that. Thanks, Asaf

Re: [PIP-214][broker]Add broker level metrics statistics and expose to prometheus discussion

2022-10-24 Thread Michael Marshall
I think this feature is already available out of the box, as Penghui suggests. You can get metrics per broker summing them up over the `instance` label or the `kubernetes_pod_name` label. These labels are added not by the broker, but instead by the prometheus scrape definition. Also, you are corre

Re: [VOTE] PIP-212: Default reppDnsResolverClass to ZkBookieRackAffinityMapping

2022-10-24 Thread Michael Marshall
+1 (binding) Thank you all for voting. I am closing the vote with 4 binding +1 votes (Dave, Enrico, PengHui, Michael) and 2 non-binding +1 votes (Bo, Zike). I will merge and cherry-pick the changes, and I'll make sure all documentation is updated. Thanks, Michael On Sun, Oct 23, 2022 at 8:49

Re: [DISCUSS] PIP-217: LoadShedding Strategy Improment

2022-10-24 Thread Heesung Sohn
Hi, Currently, the historical score is based on exponential smoothing. As you described, the current default value is conservative (by default 90%), meaning it weighs significantly more on the historical load than the current load in the formula. historicalPecentage is configurable, and one could

Re: [VOTE] Pulsar Client C++ Release 3.0.0 Candidate 3

2022-10-24 Thread Yunze Xu
+1 (non-bindings) * verify checksum and signatures * build from source (Ubuntu 20.04 x86_64) * basic e2e tests with libraries built from source * rpm packages BTW, I've created a repo here [1] to verify the binaries. In future, I will add more examples to verify the release. [1] https://github.c

[DISCUSS] PIP-217: LoadShedding Strategy Improment

2022-10-24 Thread BIGO
Hi pulsar-dev community, I raised a pip to discuss : PIP-217: LoadShedding Strategy Improment PIP link: PIP-217: LoadShedding Strategy Improment · Issue #18173 · apache/pulsar (github.com) Regards, TheTumbled.

Re: PIP-Java Client support to Cumulative Acknowledge messages for multiple partitions or topics

2022-10-24 Thread Enrico Olivelli
Penghui, Il giorno ven 21 ott 2022 alle ore 02:04 PengHui Li ha scritto: > > > while (true) { > Messages messages = consumer.batchReceive(); > Message finalMessage = null; > for (Message message : messages) { > process(message); > finalMessage = message; > } >

Re: [DISCUSS] Use SLASHSTAR_STYLE for Java files

2022-10-24 Thread tison
Patch submitted at: https://github.com/apache/pulsar/pull/18177 Although I can always reapply the formatting step, I hope with can have a timely review stage :) Best, tison. tison 于2022年10月24日周一 17:01写道: > Thanks for your feedback! Then I'm going to rebase the pull request in > days. > > Stil

[GitHub] [pulsar] philixtian added a comment to the discussion: When I set-retention for a partitioned topic by admin cli, whether it will take effect in every partitions ?

2022-10-24 Thread GitBox
GitHub user philixtian added a comment to the discussion: When I set-retention for a partitioned topic by admin cli, whether it will take effect in every partitions ? Thanks~ GitHub link: https://github.com/apache/pulsar/discussions/18168#discussioncomment-3950258 This is an automatica

Re: [VOTE] Pulsar Client C++ Release 3.0.0 Candidate 3

2022-10-24 Thread Yunze Xu
Hi Kai, Yeah, it's an issue that currently the scripts all use `git` command to determine the root directory. I'm not sure if it could be a blocker. Thanks, Yunze On Mon, Oct 24, 2022 at 2:36 PM Kai Wang wrote: > > +1 (non-binding) > > Environment: M1 macOS 12.6 and Ubuntu 20.04 x86_64 > > * ve

Re: [DISCUSS] Use SLASHSTAR_STYLE for Java files

2022-10-24 Thread tison
Thanks for your feedback! Then I'm going to rebase the pull request in days. Still waiting for comments and I may expect two or more committers help with the process if we reach a consensus. Best, tison. Zike Yang 于2022年10月24日周一 13:40写道: > +1 > > Thanks, > Zike Yang > > On Mon, Oct 24, 2022 a

[GitHub] [pulsar] Jason918 added a comment to the discussion: When I set-retention for a partitioned topic by admin cli, whether it will take effect in every partitions ?

2022-10-24 Thread GitBox
GitHub user Jason918 added a comment to the discussion: When I set-retention for a partitioned topic by admin cli, whether it will take effect in every partitions ? Yes, topic partitions share all the same policies. GitHub link: https://github.com/apache/pulsar/discussions/18168#discussionco