Patch submitted at: https://github.com/apache/pulsar/pull/18177
Although I can always reapply the formatting step, I hope with can have a timely review stage :) Best, tison. tison <wander4...@gmail.com> 于2022年10月24日周一 17:01写道： > Thanks for your feedback! Then I'm going to rebase the pull request in > days. > > Still waiting for comments and I may expect two or more committers help > with the process if we reach a consensus. > > Best, > tison. > > > Zike Yang <z...@apache.org> 于2022年10月24日周一 13:40写道： > >> +1 >> >> Thanks, >> Zike Yang >> >> On Mon, Oct 24, 2022 at 1:25 PM Yunze Xu <y...@streamnative.io.invalid> >> wrote: >> > >> > +1 for me. >> > >> > Thanks, >> > Yunze >> > >> > On Fri, Oct 21, 2022 at 9:45 AM tison <wander4...@gmail.com> wrote: >> > > >> > > Hi, >> > > >> > > Here is the pull request: https://github.com/apache/pulsar/pull/17508 >> > > >> > > Motivation: >> > > >> > > When reformatting Java files, JAVADOC_STYLE cause the license header >> be >> > > treated as doc comments and it will be affected from: >> > > >> > > /** >> > > * ... >> > > * with the License. You may obtain a copy of the License at >> > > * >> > > * http://www.apache.org/licenses/LICENSE-2.0 >> > > * >> > > * Unless required by applicable law or agreed to in writing, >> > > * ... >> > > */ >> > > >> > > to >> > > >> > > /** >> > > * ... >> > > * with the License. You may obtain a copy of the License at >> > > * <p> >> > > * http://www.apache.org/licenses/LICENSE-2.0 >> > > * <p> >> > > * Unless required by applicable law or agreed to in writing, >> > > * ... >> > > */ >> > > >> > > This is annoying and actually fails the license check, while we can >> replace >> > > JAVADOC_STYLE with SLASHSTAR_STYLE and it won't be an issue anymore. >> > > >> > > Especially after https://github.com/apache/pulsar/pull/18142 merged, >> we >> > > globally enable checkstyle rules so that the action above will become >> more >> > > and more frequent. >> > > >> > > Looking forward to your feedback. >> > > >> > > Best, >> > > tison. >> >
