[GitHub] [pulsar-client-node] nkurihar merged pull request #203: Update compatibility table in README

2022-03-14 Thread GitBox
nkurihar merged pull request #203: URL: https://github.com/apache/pulsar-client-node/pull/203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-

[GitHub] [pulsar-site] Anonymitaet commented on pull request #21: Update reporting a vulnerability documentation

2022-03-14 Thread GitBox
Anonymitaet commented on pull request #21: URL: https://github.com/apache/pulsar-site/pull/21#issuecomment-1067627368 I think one place (below) is enough since we do not want duplicated content, right? @D-2-Ed @DaveDuggins ![image](https://user-images.githubusercontent.com/50226895/

Re: [VOTE][PIP-146] ManagedCursorInfo compression

2022-03-14 Thread Zike Yang
Hi Zixuan, This proposal has 3 (+1) bindings and 0 (-1) and has stayed open for at least 48 hours. You can close this vote now and the proposal has been accepted. Thanks, Zike Yang On Tue, Mar 15, 2022 at 10:50 AM Zixuan Liu wrote: > > Hi Pulsar community, > > Thank you for your vote. Is this p

??????[VOTE] Pulsar Release 2.10.0 Candidate 3

2022-03-14 Thread zhangao
there is another problem: https://github.com/apache/pulsar/issues/14690 fix for  initialize-cluster-metadata:  https://github.com/apache/pulsar/pull/14686 --  -- ??:

[GitHub] [pulsar-site] michaeljmarshall commented on pull request #21: Update reporting a vulnerability documentation

2022-03-14 Thread GitBox
michaeljmarshall commented on pull request #21: URL: https://github.com/apache/pulsar-site/pull/21#issuecomment-1067575643 I verified that this "looks" correct. Here are screenshots: https://user-images.githubusercontent.com/47911938/158312064-247f81d3-3d47-47cd-a7c0-9077aa94ddc5.png";>

[GitHub] [pulsar-site] michaeljmarshall opened a new pull request #21: Update reporting a vulnerability documentation

2022-03-14 Thread GitBox
michaeljmarshall opened a new pull request #21: URL: https://github.com/apache/pulsar-site/pull/21 See https://github.com/apache/pulsar/pull/14610 and https://github.com/apache/pulsar/pull/14610#issuecomment-1067510855 for context. Adding some detail to the reporting a vulnerability

[GitHub] [pulsar-site] michaeljmarshall opened a new issue #20: Error when cloning git repo

2022-03-14 Thread GitBox
michaeljmarshall opened a new issue #20: URL: https://github.com/apache/pulsar-site/issues/20 When I clone this git repo on a MacOS, I get the following output/error: ``` mmarshall-rmbp16:apache michaelmarshall$ git clone g...@github.com:apache/pulsar-site.git Cloning into 'pul

Re: [VOTE] Pulsar Client Go Release 0.8.1 Candidate 1

2022-03-14 Thread Rui Fu
Thanks to everyone for the validation Close this vote: 4 +1(binding) - Matteo Merli - Hiroyuki Sakai - Hang Chen - Penghui Li 1 +1(non-binding) - Xiaolong Ran Best, Rui Fu 在 2022年3月15日 +0800 09:57,PengHui Li ,写道: > +1 (binding) > > - Checked the signature > - Build from the source code > - R

Re: [VOTE][PIP-146] ManagedCursorInfo compression

2022-03-14 Thread Zixuan Liu
Hi Pulsar community, Thank you for your vote. Is this proposal acceptable? Thanks, Zixuan Zike Yang 于2022年3月14日周一 14:26写道: > +1 > > Thanks, > Zike Yang > > On Mon, Mar 14, 2022 at 11:27 AM r...@apache.org > wrote: > > > > +1 > > > > -- > > Thanks > > Xiaolong Ran > > > > Hang Chen 于2022年3月14

[GitHub] [pulsar-manager] wynan commented on issue #409: Option to view Schema registered with topic

2022-03-14 Thread GitBox
wynan commented on issue #409: URL: https://github.com/apache/pulsar-manager/issues/409#issuecomment-1067482259 I'm wondering if this PR is still viable? I'm looking to use Pulsar to implement a data mesh and would love to expose the Schema registry more in the manager. -- This is an au

Re: [VOTE] Pulsar Client Go Release 0.8.1 Candidate 1

2022-03-14 Thread PengHui Li
+1 (binding) - Checked the signature - Build from the source code - Run tests Penghui On Tue, Mar 15, 2022 at 9:22 AM Hang Chen wrote: > +1 (binding) > > - Verify the checksum and signature > - Run perf produce and consume. > > Best, > Hang > > r...@apache.org 于2022年3月14日周一 11:28写道: > > > > +

Re: [VOTE] Pulsar Client Go Release 0.8.1 Candidate 1

2022-03-14 Thread Hang Chen
+1 (binding) - Verify the checksum and signature - Run perf produce and consume. Best, Hang r...@apache.org 于2022年3月14日周一 11:28写道: > > +1 (non-bindig) > > - Verify the checksum > - Run Action CI for all test case > > -- > Thanks > Xiaolong Ran > > Hiroyuki Sakai 于2022年3月11日周五 14:24写道: > > > +1

Re: [DISCUSS][Reader] readNext reset message position automatically when enable inclusive

2022-03-14 Thread PengHui Li
Thanks @Mattison. Yes, It's a long term fix solution, the protocol changes need to upgrade the broker and client and we can only apply the protocol changes to a major release. I think Zixuan is trying to find a short-term fix without protocol changes. Penghui On Mon, Mar 14, 2022 at 5:59 PM mat

Re: [VOTE] [PIP-144] Making SchemaRegistry implementation configurable

2022-03-14 Thread Aparajita Singh
Thanks Hang. Closing this vote with 3 (+1) bindings and 0 (-1). On Mon, 14 Mar 2022 at 19:01, Hang Chen wrote: > Hi Aparajita, > Thanks for you contribution. This proposal has 3 (+1) bindings and > 0 (-1). You can close this vote now and the proposal has been > accepted. > > Aparajita Singh

Re: [VOTE] [PIP-144] Making SchemaRegistry implementation configurable

2022-03-14 Thread Hang Chen
Hi Aparajita, Thanks for you contribution. This proposal has 3 (+1) bindings and 0 (-1). You can close this vote now and the proposal has been accepted. Aparajita Singh 于2022年3月14日周一 17:47写道: > > Thanks for reviewing and voting. Can the proposal be accepted now? > > On Mon, 14 Mar 2022 at 06:

??????[VOTE] Pulsar Release 2.10.0 Candidate 3

2022-03-14 Thread zhangao
It's bookkeeper's problem. fix pr :https://github.com/apache/bookkeeper/pull/3109/files --  -- ??: "dev"

??????[VOTE] Pulsar Release 2.10.0 Candidate 3

2022-03-14 Thread zhangao
There is problem when initialized cluster by using initialize-cluster-metadata with multiple ZK servers configed. eg: bin/pulsar initialize-cluster-metadata --cluster test --metadata-store zk1:2181,zk2:2181/test --configuration-metadata-store zk1:2181,zk2:2181/test -- 

[GitHub] [pulsar-helm-chart] HuynhKevin opened a new pull request #244: Add imagePullSecrets zookeeper

2022-03-14 Thread GitBox
HuynhKevin opened a new pull request #244: URL: https://github.com/apache/pulsar-helm-chart/pull/244 All components have the imagePullSecrets to avoid quota limit to init correctly the pods except zookeeper -- This is an automated message from the Apache Git Service. To respond to th

Re: [DISCUSS][Reader] readNext reset message position automatically when enable inclusive

2022-03-14 Thread mattison chao
Hi, Zixuan, Very glad you can notice this problem. I am preparing to submit a PIP to resolve this issue. This pip is to add a new field to the CommandSubscribe to let the broker know how to set the cursor position. Feel free to give me more good advice and let me know what you think. Best, Ma

Re: [VOTE] [PIP-144] Making SchemaRegistry implementation configurable

2022-03-14 Thread Aparajita Singh
Thanks for reviewing and voting. Can the proposal be accepted now? On Mon, 14 Mar 2022 at 06:47, Hang Chen wrote: > +1 > > Thanks, > Hang > > Aparajita Singh 于2022年3月11日周五 10:41写道: > > > > *bump* > > > > > > On Wed, 9 Mar 2022, 18:30 PengHui Li, wrote: > > > > > +1 > > > > > > Penghui > > > >

Re: [DISCUSS][Reader] readNext reset message position automatically when enable inclusive

2022-03-14 Thread PengHui Li
Hi Zixuan, We are not able to add `hasMessageAvailable()` check before `readNext()` method. For some cases, they care about if they need to do something if no messages are available, but some cases are not, just continues to read the messages from the topic, so they don't need to check if there ar

[DISCUSS][Reader] readNext reset message position automatically when enable inclusive

2022-03-14 Thread Zixuan Liu
Hi Pulsar community, Currently, the reader support sets the start message id and enables the inclusive. I have a case that always read the latest message, set the MessageId.latest as start message id with enabling the inclusive, the code so like: ``` @Test public void testReaderGetsLatestInclusiv

[GitHub] [pulsar-client-node] massakam commented on a change in pull request #200: convert worker threads to async functions

2022-03-14 Thread GitBox
massakam commented on a change in pull request #200: URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825670362 ## File path: src/Consumer.cc ## @@ -243,160 +235,229 @@ class ConsumerReceiveWorker : public Napi::AsyncWorker { private: Napi::Promise:

[GitHub] [pulsar-client-node] massakam commented on a change in pull request #200: convert worker threads to async functions

2022-03-14 Thread GitBox
massakam commented on a change in pull request #200: URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825699449 ## File path: tests/end_to_end.test.js ## @@ -302,7 +302,7 @@ const Pulsar = require('../index.js'); } await expect(consumer.rec

[GitHub] [pulsar-client-node] massakam commented on a change in pull request #200: convert worker threads to async functions

2022-03-14 Thread GitBox
massakam commented on a change in pull request #200: URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825699223 ## File path: tests/end_to_end.test.js ## @@ -106,7 +106,7 @@ const Pulsar = require('../index.js'); consumer.acknowledge(msg2);

[GitHub] [pulsar-client-node] massakam commented on a change in pull request #200: convert worker threads to async functions

2022-03-14 Thread GitBox
massakam commented on a change in pull request #200: URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825675677 ## File path: src/Consumer.cc ## @@ -243,160 +235,229 @@ class ConsumerReceiveWorker : public Napi::AsyncWorker { private: Napi::Promise:

[GitHub] [pulsar-client-node] massakam commented on a change in pull request #200: convert worker threads to async functions

2022-03-14 Thread GitBox
massakam commented on a change in pull request #200: URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825672970 ## File path: src/Consumer.cc ## @@ -243,160 +235,229 @@ class ConsumerReceiveWorker : public Napi::AsyncWorker { private: Napi::Promise:

[GitHub] [pulsar-client-node] massakam commented on a change in pull request #200: convert worker threads to async functions

2022-03-14 Thread GitBox
massakam commented on a change in pull request #200: URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825667640 ## File path: src/Consumer.cc ## @@ -243,160 +235,229 @@ class ConsumerReceiveWorker : public Napi::AsyncWorker { private: Napi::Promise:

[GitHub] [pulsar-client-node] massakam commented on a change in pull request #200: convert worker threads to async functions

2022-03-14 Thread GitBox
massakam commented on a change in pull request #200: URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825664237 ## File path: src/Consumer.cc ## @@ -225,14 +214,17 @@ class ConsumerReceiveWorker : public Napi::AsyncWorker { ~ConsumerReceiveWorker() {}

[GitHub] [pulsar-client-node] massakam commented on a change in pull request #200: convert worker threads to async functions

2022-03-14 Thread GitBox
massakam commented on a change in pull request #200: URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825685738 ## File path: src/Consumer.cc ## @@ -79,144 +81,131 @@ void MessageListener(pulsar_consumer_t *cConsumer, pulsar_message_t *cMessage, v list

[GitHub] [pulsar-client-node] massakam commented on a change in pull request #200: convert worker threads to async functions

2022-03-14 Thread GitBox
massakam commented on a change in pull request #200: URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825615679 ## File path: src/Consumer.cc ## @@ -79,144 +81,131 @@ void MessageListener(pulsar_consumer_t *cConsumer, pulsar_message_t *cMessage, v list

[GitHub] [pulsar-client-node] massakam commented on a change in pull request #200: convert worker threads to async functions

2022-03-14 Thread GitBox
massakam commented on a change in pull request #200: URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825675677 ## File path: src/Consumer.cc ## @@ -243,160 +235,229 @@ class ConsumerReceiveWorker : public Napi::AsyncWorker { private: Napi::Promise:

[GitHub] [pulsar-client-node] massakam commented on a change in pull request #200: convert worker threads to async functions

2022-03-14 Thread GitBox
massakam commented on a change in pull request #200: URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825672970 ## File path: src/Consumer.cc ## @@ -243,160 +235,229 @@ class ConsumerReceiveWorker : public Napi::AsyncWorker { private: Napi::Promise:

[GitHub] [pulsar-client-node] massakam commented on a change in pull request #200: convert worker threads to async functions

2022-03-14 Thread GitBox
massakam commented on a change in pull request #200: URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825670362 ## File path: src/Consumer.cc ## @@ -243,160 +235,229 @@ class ConsumerReceiveWorker : public Napi::AsyncWorker { private: Napi::Promise:

[GitHub] [pulsar-client-node] massakam commented on a change in pull request #200: convert worker threads to async functions

2022-03-14 Thread GitBox
massakam commented on a change in pull request #200: URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825667640 ## File path: src/Consumer.cc ## @@ -243,160 +235,229 @@ class ConsumerReceiveWorker : public Napi::AsyncWorker { private: Napi::Promise:

[GitHub] [pulsar-client-node] massakam commented on a change in pull request #200: convert worker threads to async functions

2022-03-14 Thread GitBox
massakam commented on a change in pull request #200: URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825664237 ## File path: src/Consumer.cc ## @@ -225,14 +214,17 @@ class ConsumerReceiveWorker : public Napi::AsyncWorker { ~ConsumerReceiveWorker() {}

[GitHub] [pulsar-client-node] massakam commented on a change in pull request #200: convert worker threads to async functions

2022-03-14 Thread GitBox
massakam commented on a change in pull request #200: URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825638693 ## File path: src/Consumer.cc ## @@ -79,144 +81,131 @@ void MessageListener(pulsar_consumer_t *cConsumer, pulsar_message_t *cMessage, v list