RobertIndie commented on a change in pull request #48:
URL: https://github.com/apache/pulsar-dotpulsar/pull/48#discussion_r498644121
##
File path: src/DotPulsar/Abstractions/IPulsarClient.cs
##
@@ -35,5 +38,10 @@ public interface IPulsarClient : IAsyncDisposable
/// Cr
RobertIndie commented on a change in pull request #48:
URL: https://github.com/apache/pulsar-dotpulsar/pull/48#discussion_r498599360
##
File path: src/DotPulsar/Abstractions/IMessageRouter.cs
##
@@ -0,0 +1,25 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "Lice
hrsakai merged pull request #126:
URL: https://github.com/apache/pulsar-client-node/pull/126
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
savearray2 commented on pull request #125:
URL:
https://github.com/apache/pulsar-client-node/pull/125#issuecomment-702408336
@hrsakai
Thank you for your time.
I've completed the changes you've requested.
The interface is now as follows:
```js
const topicsPattern = 'persi
alanhoff commented on a change in pull request #126:
URL: https://github.com/apache/pulsar-client-node/pull/126#discussion_r498361935
##
File path: tests/producer.test.js
##
@@ -56,6 +56,24 @@ const Pulsar = require('../index.js');
batchingEnabled: true,
}))
alanhoff commented on a change in pull request #126:
URL: https://github.com/apache/pulsar-client-node/pull/126#discussion_r498350224
##
File path: tests/producer.test.js
##
@@ -56,6 +56,24 @@ const Pulsar = require('../index.js');
batchingEnabled: true,
}))
savearray2 commented on pull request #125:
URL:
https://github.com/apache/pulsar-client-node/pull/125#issuecomment-702208980
@hrsakai
Thank you for your response.
I will make changes to use ```topicsPattern``` instead of the proposed
```subscriptionMode``` for this feature and n
2020-09-30 10:19:03 UTC - Milos Matijasevic: @Milos Matijasevic has joined the
channel
2020-09-30 18:42:38 UTC - Lari Hotari: Thank you @jia zhai for reviewing and
merging the PRs. What is the process to back port the fixes to 2.6 branch? It
would be nice to get the fixes in 2.6.2 .
20
