RobertIndie commented on a change in pull request #48: URL: https://github.com/apache/pulsar-dotpulsar/pull/48#discussion_r498599360
########## File path: src/DotPulsar/Abstractions/IMessageRouter.cs ########## @@ -0,0 +1,25 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +namespace DotPulsar.Abstractions +{ + using DotPulsar.Internal; + public interface IMessageRouter + { + /// <summary> + /// Choose a partition. + /// </summary> + int ChoosePartition(MessageMetadata? message, PartitionedTopicMetadata partitionedTopic); Review comment: There are some refactoring issues involving the Producer by setting the messageMetadata to not Nullable. Therefore, I want to reconstruct the Producer and the PartitionedProducer before making any changes here. The PartitionTopicMetdata and ChoosePartition defined here are to be consistent with JavaClient. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
