[GitHub] [pulsar-dotpulsar] Chickenzilla commented on a change in pull request #23: Allow for concurrent message production

Chickenzilla commented on a change in pull request #23: URL: https://github.com/apache/pulsar-dotpulsar/pull/23#discussion_r449695256 ## File path: src/DotPulsar/Internal/ProducerChannel.cs ## @@ -90,18 +90,16 @@ public Task Send(MessageMetadata metadata, ReadOnlySequence<

[GitHub] [pulsar-dotpulsar] Chickenzilla commented on a change in pull request #23: Allow for concurrent message production

Chickenzilla commented on a change in pull request #23: URL: https://github.com/apache/pulsar-dotpulsar/pull/23#discussion_r449695256 ## File path: src/DotPulsar/Internal/ProducerChannel.cs ## @@ -90,18 +90,16 @@ public Task Send(MessageMetadata metadata, ReadOnlySequence<

[GitHub] [pulsar-dotpulsar] blankensteiner commented on a change in pull request #23: Allow for concurrent message production

blankensteiner commented on a change in pull request #23: URL: https://github.com/apache/pulsar-dotpulsar/pull/23#discussion_r449674317 ## File path: src/DotPulsar/Internal/ProducerChannel.cs ## @@ -90,18 +90,16 @@ public Task Send(MessageMetadata metadata, ReadOnlySequence<

[GitHub] [pulsar-client-node] psr323 commented on issue #100: Listener for Consumers

psr323 commented on issue #100: URL: https://github.com/apache/pulsar-client-node/issues/100#issuecomment-653521772 @equanz Any tentative dates for the version 1.2.0? This is an automated message from the Apache Git Service.

[GitHub] [pulsar-dotpulsar] blankensteiner commented on a change in pull request #23: Allow for concurrent message production

blankensteiner commented on a change in pull request #23: URL: https://github.com/apache/pulsar-dotpulsar/pull/23#discussion_r449553066 ## File path: src/DotPulsar/DotPulsar.csproj ## @@ -23,7 +23,7 @@ - + Review comment: I don't know the

[GitHub] [pulsar-client-node] massakam merged pull request #101: Get redelivery count

massakam merged pull request #101: URL: https://github.com/apache/pulsar-client-node/pull/101 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar-client-node] massakam commented on pull request #101: Get redelivery count

massakam commented on pull request #101: URL: https://github.com/apache/pulsar-client-node/pull/101#issuecomment-653497111 @dionjansen Hmm... I don't know why it failed, but all the tests passed on Jenkins. ``` PASS tests/consumer.test.js Consumer Create ✓ No T

[GitHub] [pulsar-client-node] massakam commented on pull request #101: Get redelivery count

massakam commented on pull request #101: URL: https://github.com/apache/pulsar-client-node/pull/101#issuecomment-653493731 retest this please This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [pulsar-client-node] massakam removed a comment on pull request #101: Get redelivery count

massakam removed a comment on pull request #101: URL: https://github.com/apache/pulsar-client-node/pull/101#issuecomment-653493731 retest this please This is an automated message from the Apache Git Service. To respond to th

[GitHub] [pulsar-client-node] massakam commented on pull request #101: Get redelivery count

massakam commented on pull request #101: URL: https://github.com/apache/pulsar-client-node/pull/101#issuecomment-653492247 retest this please This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [pulsar-client-node] massakam removed a comment on pull request #101: Get redelivery count

massakam removed a comment on pull request #101: URL: https://github.com/apache/pulsar-client-node/pull/101#issuecomment-653492247 retest this please This is an automated message from the Apache Git Service. To respond to th

[GitHub] [pulsar-dotpulsar] Chickenzilla commented on a change in pull request #23: Allow for concurrent message production

Chickenzilla commented on a change in pull request #23: URL: https://github.com/apache/pulsar-dotpulsar/pull/23#discussion_r449524039 ## File path: src/DotPulsar/Internal/SequenceId.cs ## @@ -12,21 +12,24 @@ * limitations under the License. */ +using System.Threading; +

[GitHub] [pulsar-client-node] dionjansen edited a comment on pull request #101: Get redelivery count

dionjansen edited a comment on pull request #101: URL: https://github.com/apache/pulsar-client-node/pull/101#issuecomment-653489056 @massakam sorry for the mess I hadn't actually ran the code locally, linter works fine for me now. One unit test is failing though: ``` FAIL tests

[GitHub] [pulsar-client-node] dionjansen edited a comment on pull request #101: Get redelivery count

dionjansen edited a comment on pull request #101: URL: https://github.com/apache/pulsar-client-node/pull/101#issuecomment-653489056 @massakam sorry for the mess I hadn't actually ran the code locally, linter works fine for me now. One unit test is failing though: ``` FAIL tests

[GitHub] [pulsar-client-node] dionjansen commented on pull request #101: Get redelivery count

dionjansen commented on pull request #101: URL: https://github.com/apache/pulsar-client-node/pull/101#issuecomment-653489056 @massakam sorry for the mess I hadn't actually ran the code locally, linter works fine for me now. One unit test is failing though: ``` FAIL tests/consum

[GitHub] [pulsar-dotpulsar] Chickenzilla commented on a change in pull request #23: Allow for concurrent message production

Chickenzilla commented on a change in pull request #23: URL: https://github.com/apache/pulsar-dotpulsar/pull/23#discussion_r449519578 ## File path: src/DotPulsar/Internal/RequestResponseHandler.cs ## @@ -53,31 +54,40 @@ private void SetRequestId(BaseCommand cmd) sw

[GitHub] [pulsar-dotpulsar] Chickenzilla commented on a change in pull request #23: Allow for concurrent message production

Chickenzilla commented on a change in pull request #23: URL: https://github.com/apache/pulsar-dotpulsar/pull/23#discussion_r449516395 ## File path: src/DotPulsar/Internal/ProducerChannel.cs ## @@ -90,18 +90,16 @@ public Task Send(MessageMetadata metadata, ReadOnlySequence<

[GitHub] [pulsar-dotpulsar] Chickenzilla commented on a change in pull request #23: Allow for concurrent message production

Chickenzilla commented on a change in pull request #23: URL: https://github.com/apache/pulsar-dotpulsar/pull/23#discussion_r449513485 ## File path: src/DotPulsar/DotPulsar.csproj ## @@ -23,7 +23,7 @@ - + Review comment: Ahh, so this is be

[GitHub] [pulsar-dotpulsar] blankensteiner commented on pull request #23: Allow for concurrent message production

blankensteiner commented on pull request #23: URL: https://github.com/apache/pulsar-dotpulsar/pull/23#issuecomment-653474661 Hi @Chickenzilla Welcome back! :-) > I believe you may have a race condition waiting in your SequenceId that my code side-steps Yeah, we need so

[GitHub] [pulsar-dotpulsar] blankensteiner commented on a change in pull request #23: Allow for concurrent message production

blankensteiner commented on a change in pull request #23: URL: https://github.com/apache/pulsar-dotpulsar/pull/23#discussion_r449505264 ## File path: src/DotPulsar/Internal/ProducerChannel.cs ## @@ -90,18 +90,16 @@ public Task Send(MessageMetadata metadata, ReadOnlySequence<

Slack digest for #dev - 2020-07-03

2020-07-02 18:42:26 UTC - Devin G. Bost: I’m looking for Go more specifically. Sorry, I was vague haha 2020-07-02 23:24:34 UTC - Tamer: 2020-07-02 23:25:59 UTC - Tamer: This what I use in the

[GitHub] [pulsar-manager] Omega-Ariston commented on issue #282: Could we add a dashboard in the home page ?

Omega-Ariston commented on issue #282: URL: https://github.com/apache/pulsar-manager/issues/282#issuecomment-653441452 > Yes, I think this is a good idea. I'll mark it help-wanted first. If anyone wants to do it, please refer to the following step. > > 1. Get the total number of `clu

[GitHub] [pulsar-client-node] massakam commented on a change in pull request #101: Get redelivery count

massakam commented on a change in pull request #101: URL: https://github.com/apache/pulsar-client-node/pull/101#discussion_r449416029 ## File path: tests/end_to_end.test.js ## @@ -116,6 +116,52 @@ const Pulsar = require('../index.js'); await client.close(); }); +

[GitHub] [pulsar-client-node] massakam commented on a change in pull request #101: Get redelivery count

massakam commented on a change in pull request #101: URL: https://github.com/apache/pulsar-client-node/pull/101#discussion_r449416195 ## File path: tests/end_to_end.test.js ## @@ -116,6 +116,52 @@ const Pulsar = require('../index.js'); await client.close(); }); +

[GitHub] [pulsar-client-node] massakam commented on pull request #101: Get redelivery count

massakam commented on pull request #101: URL: https://github.com/apache/pulsar-client-node/pull/101#issuecomment-653391952 There are some lint errors in the test code. ``` /pulsar-client-node/tests/end_to_end.test.js 135:27 error Strings must use singlequote quotes 150:14

[GitHub] [pulsar-client-node] massakam commented on a change in pull request #101: Get redelivery count

massakam commented on a change in pull request #101: URL: https://github.com/apache/pulsar-client-node/pull/101#discussion_r449415870 ## File path: tests/end_to_end.test.js ## @@ -116,6 +116,52 @@ const Pulsar = require('../index.js'); await client.close(); }); +

[GitHub] [pulsar-client-node] massakam removed a comment on pull request #101: Get redelivery count

massakam removed a comment on pull request #101: URL: https://github.com/apache/pulsar-client-node/pull/101#issuecomment-653389146 retest this please This is an automated message from the Apache Git Service. To respond to th

[GitHub] [pulsar-client-node] massakam commented on pull request #101: Get redelivery count

massakam commented on pull request #101: URL: https://github.com/apache/pulsar-client-node/pull/101#issuecomment-653389146 retest this please This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [pulsar-client-node] massakam removed a comment on pull request #101: Get redelivery count

massakam removed a comment on pull request #101: URL: https://github.com/apache/pulsar-client-node/pull/101#issuecomment-653387998 retest this please This is an automated message from the Apache Git Service. To respond to th

[GitHub] [pulsar-client-node] massakam commented on pull request #101: Get redelivery count

massakam commented on pull request #101: URL: https://github.com/apache/pulsar-client-node/pull/101#issuecomment-653387998 retest this please This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [pulsar-client-node] equanz commented on issue #100: Listener for Consumers

equanz commented on issue #100: URL: https://github.com/apache/pulsar-client-node/issues/100#issuecomment-653388179 Current version is 1.1.0(https://github.com/apache/pulsar-client-node/tags). Issue will be fixed in 1.2.0(unreleased). -