Chickenzilla commented on a change in pull request #23:
URL: https://github.com/apache/pulsar-dotpulsar/pull/23#discussion_r449519578
##########
File path: src/DotPulsar/Internal/RequestResponseHandler.cs
##########
@@ -53,31 +54,40 @@ private void SetRequestId(BaseCommand cmd)
switch (cmd.CommandType)
{
case BaseCommand.Type.Seek:
- cmd.Seek.RequestId = _requestId++;
+ cmd.Seek.RequestId = _requestId.FetchNext();
+ _pastInitialRequestId = true;
Review comment:
Yes, or even just hoisting the boolean set/check into that class. I
agree that would look cleaner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
